All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: Antonio Argenziano <antonio.argenziano@intel.com>,
	igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t v4 02/11] lib/igt_gt: add intel_measure_ring_size
Date: Fri, 23 Feb 2018 09:29:24 +0000	[thread overview]
Message-ID: <151937816437.26255.2699092724391385897@mail.alporthouse.com> (raw)
In-Reply-To: <20180221231947.4184-2-antonio.argenziano@intel.com>

Quoting Antonio Argenziano (2018-02-21 23:19:38)
> +unsigned int
> +gem_measure_ring_inflight(int fd, unsigned int engine, enum measure_ring_flags flags)
> +{
> +       struct sigaction old_sa, sa = { .sa_handler = alarm_handler };
> +       struct drm_i915_gem_exec_object2 obj[2];
> +       struct drm_i915_gem_execbuffer2 execbuf;
> +       const uint32_t bbe = MI_BATCH_BUFFER_END;
> +       unsigned int count, last;
> +       struct itimerval itv;
> +       IGT_CORK_HANDLE(cork);

An improvement we can make here is to iterate over all engines and
report the minimum ring size (for engine==-1). Something like,

if (engine == ~0u) {
	unsigned int min = ~0u;

	for_each_physical_engine(fd, engine) {
		unsigned int this = gem_measure_ring_inflight(fd, engine, flags);
		if (this < min)
			min = this;
	}

	return min;
}
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  reply	other threads:[~2018-02-23  9:29 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-21 23:19 [igt-dev] [PATCH i-g-t v4 01/11] lib/igt_dummyload: add igt_cork Antonio Argenziano
2018-02-21 23:19 ` [igt-dev] [PATCH i-g-t v4 02/11] lib/igt_gt: add intel_measure_ring_size Antonio Argenziano
2018-02-23  9:29   ` Chris Wilson [this message]
2018-02-23 23:16     ` Antonio Argenziano
2018-02-21 23:19 ` [igt-dev] [PATCH i-g-t v4 03/11] tests/gem_exec_schedule: use new common functions Antonio Argenziano
2018-02-21 23:19 ` [igt-dev] [PATCH i-g-t v4 04/11] tests/gem_exec_fence: " Antonio Argenziano
2018-02-21 23:19 ` [igt-dev] [PATCH i-g-t v4 05/11] tests/gem_exec_latency: " Antonio Argenziano
2018-02-21 23:19 ` [igt-dev] [PATCH i-g-t v4 06/11] tests/gem_wait: use igt_cork Antonio Argenziano
2018-02-21 23:19 ` [igt-dev] [PATCH i-g-t v4 07/11] tests/gem_eio: " Antonio Argenziano
2018-02-21 23:19 ` [igt-dev] [PATCH i-g-t v4 08/11] tests/gem_exec_await: use intel_measure_ring_size Antonio Argenziano
2018-02-21 23:19 ` [igt-dev] [PATCH i-g-t v4 09/11] tests/gem_ringfill: " Antonio Argenziano
2018-02-21 23:19 ` [igt-dev] [PATCH i-g-t v4 10/11] tests/gem_busy: Use intel_measure_ring_size Antonio Argenziano
2018-02-21 23:39   ` Chris Wilson
2018-02-21 23:19 ` [igt-dev] [PATCH i-g-t v4 11/11] igt: Use lib gem_execbuf where possible Antonio Argenziano
2018-02-21 23:42   ` Chris Wilson
2018-02-23  0:54   ` [igt-dev] [PATCH i-g-t v3] " Antonio Argenziano
2018-02-23  9:21     ` Chris Wilson
2018-02-23 10:01       ` Chris Wilson
2018-02-23 16:17         ` Antonio Argenziano
2018-02-21 23:26 ` [igt-dev] [PATCH i-g-t v4 01/11] lib/igt_dummyload: add igt_cork Chris Wilson
2018-02-22  0:17 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,v4,01/11] " Patchwork
2018-02-22  0:31 ` [igt-dev] [PATCH i-g-t v5] " Antonio Argenziano
2018-02-22  0:46   ` Chris Wilson
2018-02-22 17:35   ` [igt-dev] [PATCH i-g-t v6] " Antonio Argenziano
2018-02-22  0:52 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,v5] lib/igt_dummyload: add igt_cork (rev2) Patchwork
2018-02-22  4:47 ` [igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,v4,01/11] lib/igt_dummyload: add igt_cork Patchwork
2018-02-22  5:57 ` [igt-dev] ✗ Fi.CI.IGT: failure for series starting with [i-g-t,v5] lib/igt_dummyload: add igt_cork (rev2) Patchwork
2018-02-22 21:40 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,v6] lib/igt_dummyload: add igt_cork (rev3) Patchwork
2018-02-23  1:45 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,v6] lib/igt_dummyload: add igt_cork (rev4) Patchwork
2018-02-23  4:47 ` [igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,v6] lib/igt_dummyload: add igt_cork (rev3) Patchwork
2018-02-23  8:19 ` [igt-dev] ✗ Fi.CI.IGT: warning for series starting with [i-g-t,v6] lib/igt_dummyload: add igt_cork (rev4) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=151937816437.26255.2699092724391385897@mail.alporthouse.com \
    --to=chris@chris-wilson.co.uk \
    --cc=antonio.argenziano@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.