From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 471C5C433F5 for ; Fri, 13 May 2022 16:52:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1382627AbiEMQwi (ORCPT ); Fri, 13 May 2022 12:52:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48424 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1382552AbiEMQue (ORCPT ); Fri, 13 May 2022 12:50:34 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 81C4E54FAC for ; Fri, 13 May 2022 09:50:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652460613; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=33oKxA4Na7t/dSRQE6iTTpYQb3oMGj6G5wXczQ6on5U=; b=HgzI0KNdDK+GaLqXXntnFdmsTtCrzBTsA1x4LoxshCzVb2GT7YfPciupJxRsyYvW6Sfav+ W5XFtqCxtjDAppwGCFQcsfV2gKK0yhZOsc/J4NKpJDbCuIkHQbocYL3wX17jyHWnKAqxhK 6RBtqwYE6CCNDhP2MF123EVttIFKxqc= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-182-E_epyNm9N-Gqr5RiMsj8Zg-1; Fri, 13 May 2022 12:50:10 -0400 X-MC-Unique: E_epyNm9N-Gqr5RiMsj8Zg-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DCFA7294EDF4; Fri, 13 May 2022 16:50:09 +0000 (UTC) Received: from [10.22.11.63] (unknown [10.22.11.63]) by smtp.corp.redhat.com (Postfix) with ESMTP id AE6ED438BD9; Fri, 13 May 2022 16:50:09 +0000 (UTC) Message-ID: <151959a6-e691-c905-fe05-c6fd3f616f25@redhat.com> Date: Fri, 13 May 2022 12:50:09 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH] kselftest/cgroup: fix test_stress.sh to use OUTPUT dir Content-Language: en-US To: Tejun Heo Cc: Phil Auld , lkml , =?UTF-8?Q?Michal_Koutn=c3=bd?= References: <20220512143439.26104-1-pauld@redhat.com> From: Waiman Long In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/13/22 12:20, Tejun Heo wrote: > Can you send a quick patch? Will do. Cheers, Longman > > Thanks. > > On Fri, May 13, 2022 at 6:19 AM Waiman Long wrote: >> >> On 5/12/22 10:34, Phil Auld wrote: >>> Running cgroup kselftest with O= fails to run the with_stress test due >>> to hardcoded ./test_core. Find test_core binary using the OUTPUT directory. >>> >>> Fixes: 1a99fcc035fb ("selftests: cgroup: Run test_core under interfering stress") >>> Signed-off-by: Phil Auld >>> --- >>> tools/testing/selftests/cgroup/test_stress.sh | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/tools/testing/selftests/cgroup/test_stress.sh b/tools/testing/selftests/cgroup/test_stress.sh >>> index 15d9d5896394..109c044f715f 100755 >>> --- a/tools/testing/selftests/cgroup/test_stress.sh >>> +++ b/tools/testing/selftests/cgroup/test_stress.sh >>> @@ -1,4 +1,4 @@ >>> #!/bin/bash >>> # SPDX-License-Identifier: GPL-2.0 >>> >>> -./with_stress.sh -s subsys -s fork ./test_core >>> +./with_stress.sh -s subsys -s fork ${OUTPUT}/test_core >> >> I would suggest using "${OUTPUT:-.}" as the variable OUTPUT may not be >> defined if test_stress.sh is run interactively. >> >> Cheers, >> Longman >> >