From: "Tobin C. Harding" <email@example.com> To: Andrew Morton <firstname.lastname@example.org> Cc: "Tobin C. Harding" <email@example.com>, Joe Perches <firstname.lastname@example.org>, Andy Whitcroft <email@example.com>, firstname.lastname@example.org Subject: [PATCH v4 0/4] checkpatch: warn for use of %px Date: Tue, 27 Feb 2018 14:04:04 +1100 [thread overview] Message-ID: <email@example.com> (raw) Hi Andrew, This is a resurrection of a patch set from last December. There was some confusion (on my behalf) as to how patches to checkpatch got into the mainline. Are you willing (and able) to take patches to checkpatch.pl? Patch 1 through 3 are cleanup/refactoring patches. Patch 3 makes checkpatch emit a warning for usage of specifier %px. You may remember that the initial idea for this was from yourself, v1 requested permission to use 'Suggested-by' tag. I didn't get comment on that so v2 removed the tag. (I'm not totally across when one should add the 'Suggested-by' tag.) v3 was an Epic fail, not testing final patch series before submission. Joe, I removed your 'Acked-by' tag because the patch you originally acked is different after rebasing. I kept the Co-Developed-by tag because the code you wrote is still there I just had to massage it a bit since the check for deprecated %p[Ff] has been added since we did v2. (Sorry about the noise with v3, I hacked that version together as a RESEND, a v1, and then finally decided on a v3 and failed to test it after rebase :( And now I am going to violate the 1 version per day rule to boot. thanks for your patience, Tobin. Tested on a bunch of old patches and a hand rolled printk test module to stress test printk %p extensions. v4: - actually rebase the patch set properly - remove 'Acked-by' tag for Joe v3: - rebase onto 4.16-rc3 - separate 'remove unused variable' into it's own patch v2: - change new sub name stat_real() -> get_stat_real() - add new sub get_stat_here() - move the addition of new sub routines into separate patches - add 'Acked-by' tag for Joe - remove 'Suggested-by' tag for Andrew Morton Tobin C. Harding (4): checkpatch: add sub routine get_stat_real() checkpatch: remove unused variable declarations checkpatch: add sub routine get_stat_here() checkpatch: warn for use of %px scripts/checkpatch.pl | 130 +++++++++++++++++++++++++------------------------- 1 file changed, 66 insertions(+), 64 deletions(-) -- 2.7.4
next reply other threads:[~2018-02-27 3:04 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-02-27 3:04 Tobin C. Harding [this message] 2018-02-27 3:04 ` [PATCH v4 1/4] checkpatch: add sub routine get_stat_real() Tobin C. Harding 2018-02-27 3:04 ` [PATCH v4 2/4] checkpatch: remove unused variable declarations Tobin C. Harding 2018-02-27 3:04 ` [PATCH v4 3/4] checkpatch: add sub routine get_stat_here() Tobin C. Harding 2018-02-27 3:04 ` [PATCH v4 4/4] checkpatch: warn for use of %px Tobin C. Harding 2018-03-02 23:46 ` [PATCH v4 0/4] " Andrew Morton
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH v4 0/4] checkpatch: warn for use of %px' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.