From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zhiyong Tao Subject: Re: [PATCH v2 3/4] pinctrl: add mt2712 pinctrl driver Date: Wed, 28 Feb 2018 15:46:16 +0800 Message-ID: <1519803976.23198.6.camel@mhfsdcap03> References: <1519634042-12063-1-git-send-email-zhiyong.tao@mediatek.com> <1519634042-12063-4-git-send-email-zhiyong.tao@mediatek.com> <1519802048.8089.17.camel@mtkswgap22> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1519802048.8089.17.camel@mtkswgap22> Sender: linux-kernel-owner@vger.kernel.org To: Sean Wang Cc: robh+dt@kernel.org, linus.walleij@linaro.org, mark.rutland@arm.com, matthias.bgg@gmail.com, devicetree@vger.kernel.org, hongkun.cao@mediatek.com, srv_heupstream@mediatek.com, linux-gpio@vger.kernel.org, biao.huang@mediatek.com, erin.lo@mediatek.com, liguo.zhang@mediatek.com, linux-kernel@vger.kernel.org, hongzhou.yang@mediatek.com, linux-mediatek@lists.infradead.org, yingjoe.chen@mediatek.com, linux-arm-kernel@lists.infradead.org List-Id: linux-gpio@vger.kernel.org On Wed, 2018-02-28 at 15:14 +0800, Sean Wang wrote: > Hi, Zhiyong > > all seems better than v1, but some nitpicking is addressed as below > > Sean > > On Mon, 2018-02-26 at 16:34 +0800, Zhiyong Tao wrote: > > The commit includes mt2712 pinctrl driver. > > > > Signed-off-by: Zhiyong Tao > > --- > > drivers/pinctrl/mediatek/Kconfig | 7 + > > drivers/pinctrl/mediatek/Makefile | 1 + > > drivers/pinctrl/mediatek/pinctrl-mt2712.c | 639 ++++++++ > > drivers/pinctrl/mediatek/pinctrl-mtk-mt2712.h | 1973 +++++++++++++++++++++++++ > > 4 files changed, 2620 insertions(+) > > create mode 100644 drivers/pinctrl/mediatek/pinctrl-mt2712.c > > create mode 100644 drivers/pinctrl/mediatek/pinctrl-mtk-mt2712.h > > > > diff --git a/drivers/pinctrl/mediatek/Kconfig b/drivers/pinctrl/mediatek/Kconfig > > index 3e59874..b24bc76 100644 > > --- a/drivers/pinctrl/mediatek/Kconfig > > +++ b/drivers/pinctrl/mediatek/Kconfig > > @@ -32,6 +32,13 @@ config PINCTRL_MT8127 > > select PINCTRL_MTK > > > > # For ARMv8 SoCs > > +config PINCTRL_MT2712 > > + bool "Mediatek MT2712 pin control" > > > should be MediaTek for normal ==> Thanks for your suggestion. We will correct it in v3. > > > + depends on OF > > + depends on ARM64 || COMPILE_TEST > > + default ARM64 && ARCH_MEDIATEK > > + select PINCTRL_MTK > > + > > config PINCTRL_MT7622 > > bool "MediaTek MT7622 pin control" > > depends on OF > > diff --git a/drivers/pinctrl/mediatek/Makefile b/drivers/pinctrl/mediatek/Makefile > > index ed7d2b2..7959e77 100644 > > --- a/drivers/pinctrl/mediatek/Makefile > > +++ b/drivers/pinctrl/mediatek/Makefile > > @@ -4,6 +4,7 @@ obj-$(CONFIG_PINCTRL_MTK) += pinctrl-mtk-common.o > > > > # SoC Drivers > > obj-$(CONFIG_PINCTRL_MT2701) += pinctrl-mt2701.o > > +obj-$(CONFIG_PINCTRL_MT2712) += pinctrl-mt2712.o > > obj-$(CONFIG_PINCTRL_MT8135) += pinctrl-mt8135.o > > obj-$(CONFIG_PINCTRL_MT8127) += pinctrl-mt8127.o > > obj-$(CONFIG_PINCTRL_MT7622) += pinctrl-mt7622.o > > diff --git a/drivers/pinctrl/mediatek/pinctrl-mt2712.c b/drivers/pinctrl/mediatek/pinctrl-mt2712.c > > new file mode 100644 > > index 0000000..b6ae71b > > --- /dev/null > > +++ b/drivers/pinctrl/mediatek/pinctrl-mt2712.c > > @@ -0,0 +1,639 @@ > > +/* > > + * Copyright (c) 2014-2015 MediaTek Inc. > > + * Author: Hongzhou.Yang > > + * > > + * This program is free software; you can redistribute it and/or modify > > + * it under the terms of the GNU General Public License version 2 as > > + * published by the Free Software Foundation. > > + * > > + * This program is distributed in the hope that it will be useful, > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > > + * GNU General Public License for more details. > > + */ > > + > > suggest to consider more on using SPDX identifiers and > using right data for both fields Copyright and Author ==> Thanks for your suggestion. We will correct it in v3. > > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > + > > +#include "pinctrl-mtk-common.h" > > +#include "pinctrl-mtk-mt2712.h" > > + > > <...> > > > diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-mt2712.h b/drivers/pinctrl/mediatek/pinctrl-mtk-mt2712.h > > new file mode 100644 > > index 0000000..71f4190 > > --- /dev/null > > +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-mt2712.h > > @@ -0,0 +1,1973 @@ > > +/* > > + * Copyright (C) 2015 MediaTek Inc. > > + * > > + * This program is free software: you can redistribute it and/or modify > > + * it under the terms of the GNU General Public License version 2 as > > + * published by the Free Software Foundation. > > + * > > + * This program is distributed in the hope that it will be useful, > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > > + * GNU General Public License for more details. > > + */ > > Ditto > > > +#ifndef PINCTRL_MTK_MT2712_H > > +#define PINCTRL_MTK_MT2712_H > > + > > <...> > > > + > > +#endif /* __PINCTRL_MTK_MT2712_H */ > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752063AbeB1Hqn (ORCPT ); Wed, 28 Feb 2018 02:46:43 -0500 Received: from mailgw02.mediatek.com ([1.203.163.81]:59761 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751423AbeB1Hql (ORCPT ); Wed, 28 Feb 2018 02:46:41 -0500 X-UUID: 7a8b5a36d57b48b99095f900001d64f1-20180228 Message-ID: <1519803976.23198.6.camel@mhfsdcap03> Subject: Re: [PATCH v2 3/4] pinctrl: add mt2712 pinctrl driver From: Zhiyong Tao To: Sean Wang CC: , , , , , , , , , , , , , , , Date: Wed, 28 Feb 2018 15:46:16 +0800 In-Reply-To: <1519802048.8089.17.camel@mtkswgap22> References: <1519634042-12063-1-git-send-email-zhiyong.tao@mediatek.com> <1519634042-12063-4-git-send-email-zhiyong.tao@mediatek.com> <1519802048.8089.17.camel@mtkswgap22> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2018-02-28 at 15:14 +0800, Sean Wang wrote: > Hi, Zhiyong > > all seems better than v1, but some nitpicking is addressed as below > > Sean > > On Mon, 2018-02-26 at 16:34 +0800, Zhiyong Tao wrote: > > The commit includes mt2712 pinctrl driver. > > > > Signed-off-by: Zhiyong Tao > > --- > > drivers/pinctrl/mediatek/Kconfig | 7 + > > drivers/pinctrl/mediatek/Makefile | 1 + > > drivers/pinctrl/mediatek/pinctrl-mt2712.c | 639 ++++++++ > > drivers/pinctrl/mediatek/pinctrl-mtk-mt2712.h | 1973 +++++++++++++++++++++++++ > > 4 files changed, 2620 insertions(+) > > create mode 100644 drivers/pinctrl/mediatek/pinctrl-mt2712.c > > create mode 100644 drivers/pinctrl/mediatek/pinctrl-mtk-mt2712.h > > > > diff --git a/drivers/pinctrl/mediatek/Kconfig b/drivers/pinctrl/mediatek/Kconfig > > index 3e59874..b24bc76 100644 > > --- a/drivers/pinctrl/mediatek/Kconfig > > +++ b/drivers/pinctrl/mediatek/Kconfig > > @@ -32,6 +32,13 @@ config PINCTRL_MT8127 > > select PINCTRL_MTK > > > > # For ARMv8 SoCs > > +config PINCTRL_MT2712 > > + bool "Mediatek MT2712 pin control" > > > should be MediaTek for normal ==> Thanks for your suggestion. We will correct it in v3. > > > + depends on OF > > + depends on ARM64 || COMPILE_TEST > > + default ARM64 && ARCH_MEDIATEK > > + select PINCTRL_MTK > > + > > config PINCTRL_MT7622 > > bool "MediaTek MT7622 pin control" > > depends on OF > > diff --git a/drivers/pinctrl/mediatek/Makefile b/drivers/pinctrl/mediatek/Makefile > > index ed7d2b2..7959e77 100644 > > --- a/drivers/pinctrl/mediatek/Makefile > > +++ b/drivers/pinctrl/mediatek/Makefile > > @@ -4,6 +4,7 @@ obj-$(CONFIG_PINCTRL_MTK) += pinctrl-mtk-common.o > > > > # SoC Drivers > > obj-$(CONFIG_PINCTRL_MT2701) += pinctrl-mt2701.o > > +obj-$(CONFIG_PINCTRL_MT2712) += pinctrl-mt2712.o > > obj-$(CONFIG_PINCTRL_MT8135) += pinctrl-mt8135.o > > obj-$(CONFIG_PINCTRL_MT8127) += pinctrl-mt8127.o > > obj-$(CONFIG_PINCTRL_MT7622) += pinctrl-mt7622.o > > diff --git a/drivers/pinctrl/mediatek/pinctrl-mt2712.c b/drivers/pinctrl/mediatek/pinctrl-mt2712.c > > new file mode 100644 > > index 0000000..b6ae71b > > --- /dev/null > > +++ b/drivers/pinctrl/mediatek/pinctrl-mt2712.c > > @@ -0,0 +1,639 @@ > > +/* > > + * Copyright (c) 2014-2015 MediaTek Inc. > > + * Author: Hongzhou.Yang > > + * > > + * This program is free software; you can redistribute it and/or modify > > + * it under the terms of the GNU General Public License version 2 as > > + * published by the Free Software Foundation. > > + * > > + * This program is distributed in the hope that it will be useful, > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > > + * GNU General Public License for more details. > > + */ > > + > > suggest to consider more on using SPDX identifiers and > using right data for both fields Copyright and Author ==> Thanks for your suggestion. We will correct it in v3. > > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > + > > +#include "pinctrl-mtk-common.h" > > +#include "pinctrl-mtk-mt2712.h" > > + > > <...> > > > diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-mt2712.h b/drivers/pinctrl/mediatek/pinctrl-mtk-mt2712.h > > new file mode 100644 > > index 0000000..71f4190 > > --- /dev/null > > +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-mt2712.h > > @@ -0,0 +1,1973 @@ > > +/* > > + * Copyright (C) 2015 MediaTek Inc. > > + * > > + * This program is free software: you can redistribute it and/or modify > > + * it under the terms of the GNU General Public License version 2 as > > + * published by the Free Software Foundation. > > + * > > + * This program is distributed in the hope that it will be useful, > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > > + * GNU General Public License for more details. > > + */ > > Ditto > > > +#ifndef PINCTRL_MTK_MT2712_H > > +#define PINCTRL_MTK_MT2712_H > > + > > <...> > > > + > > +#endif /* __PINCTRL_MTK_MT2712_H */ > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: zhiyong.tao@mediatek.com (Zhiyong Tao) Date: Wed, 28 Feb 2018 15:46:16 +0800 Subject: [PATCH v2 3/4] pinctrl: add mt2712 pinctrl driver In-Reply-To: <1519802048.8089.17.camel@mtkswgap22> References: <1519634042-12063-1-git-send-email-zhiyong.tao@mediatek.com> <1519634042-12063-4-git-send-email-zhiyong.tao@mediatek.com> <1519802048.8089.17.camel@mtkswgap22> Message-ID: <1519803976.23198.6.camel@mhfsdcap03> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, 2018-02-28 at 15:14 +0800, Sean Wang wrote: > Hi, Zhiyong > > all seems better than v1, but some nitpicking is addressed as below > > Sean > > On Mon, 2018-02-26 at 16:34 +0800, Zhiyong Tao wrote: > > The commit includes mt2712 pinctrl driver. > > > > Signed-off-by: Zhiyong Tao > > --- > > drivers/pinctrl/mediatek/Kconfig | 7 + > > drivers/pinctrl/mediatek/Makefile | 1 + > > drivers/pinctrl/mediatek/pinctrl-mt2712.c | 639 ++++++++ > > drivers/pinctrl/mediatek/pinctrl-mtk-mt2712.h | 1973 +++++++++++++++++++++++++ > > 4 files changed, 2620 insertions(+) > > create mode 100644 drivers/pinctrl/mediatek/pinctrl-mt2712.c > > create mode 100644 drivers/pinctrl/mediatek/pinctrl-mtk-mt2712.h > > > > diff --git a/drivers/pinctrl/mediatek/Kconfig b/drivers/pinctrl/mediatek/Kconfig > > index 3e59874..b24bc76 100644 > > --- a/drivers/pinctrl/mediatek/Kconfig > > +++ b/drivers/pinctrl/mediatek/Kconfig > > @@ -32,6 +32,13 @@ config PINCTRL_MT8127 > > select PINCTRL_MTK > > > > # For ARMv8 SoCs > > +config PINCTRL_MT2712 > > + bool "Mediatek MT2712 pin control" > > > should be MediaTek for normal ==> Thanks for your suggestion. We will correct it in v3. > > > + depends on OF > > + depends on ARM64 || COMPILE_TEST > > + default ARM64 && ARCH_MEDIATEK > > + select PINCTRL_MTK > > + > > config PINCTRL_MT7622 > > bool "MediaTek MT7622 pin control" > > depends on OF > > diff --git a/drivers/pinctrl/mediatek/Makefile b/drivers/pinctrl/mediatek/Makefile > > index ed7d2b2..7959e77 100644 > > --- a/drivers/pinctrl/mediatek/Makefile > > +++ b/drivers/pinctrl/mediatek/Makefile > > @@ -4,6 +4,7 @@ obj-$(CONFIG_PINCTRL_MTK) += pinctrl-mtk-common.o > > > > # SoC Drivers > > obj-$(CONFIG_PINCTRL_MT2701) += pinctrl-mt2701.o > > +obj-$(CONFIG_PINCTRL_MT2712) += pinctrl-mt2712.o > > obj-$(CONFIG_PINCTRL_MT8135) += pinctrl-mt8135.o > > obj-$(CONFIG_PINCTRL_MT8127) += pinctrl-mt8127.o > > obj-$(CONFIG_PINCTRL_MT7622) += pinctrl-mt7622.o > > diff --git a/drivers/pinctrl/mediatek/pinctrl-mt2712.c b/drivers/pinctrl/mediatek/pinctrl-mt2712.c > > new file mode 100644 > > index 0000000..b6ae71b > > --- /dev/null > > +++ b/drivers/pinctrl/mediatek/pinctrl-mt2712.c > > @@ -0,0 +1,639 @@ > > +/* > > + * Copyright (c) 2014-2015 MediaTek Inc. > > + * Author: Hongzhou.Yang > > + * > > + * This program is free software; you can redistribute it and/or modify > > + * it under the terms of the GNU General Public License version 2 as > > + * published by the Free Software Foundation. > > + * > > + * This program is distributed in the hope that it will be useful, > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > > + * GNU General Public License for more details. > > + */ > > + > > suggest to consider more on using SPDX identifiers and > using right data for both fields Copyright and Author ==> Thanks for your suggestion. We will correct it in v3. > > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > + > > +#include "pinctrl-mtk-common.h" > > +#include "pinctrl-mtk-mt2712.h" > > + > > <...> > > > diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-mt2712.h b/drivers/pinctrl/mediatek/pinctrl-mtk-mt2712.h > > new file mode 100644 > > index 0000000..71f4190 > > --- /dev/null > > +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-mt2712.h > > @@ -0,0 +1,1973 @@ > > +/* > > + * Copyright (C) 2015 MediaTek Inc. > > + * > > + * This program is free software: you can redistribute it and/or modify > > + * it under the terms of the GNU General Public License version 2 as > > + * published by the Free Software Foundation. > > + * > > + * This program is distributed in the hope that it will be useful, > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > > + * GNU General Public License for more details. > > + */ > > Ditto > > > +#ifndef PINCTRL_MTK_MT2712_H > > +#define PINCTRL_MTK_MT2712_H > > + > > <...> > > > + > > +#endif /* __PINCTRL_MTK_MT2712_H */ > >