From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zhiyong Tao Subject: Re: [PATCH v2 4/4] pintcrl: support bias-disable of generic and special pins simultaneously Date: Wed, 28 Feb 2018 15:49:17 +0800 Message-ID: <1519804157.23198.9.camel@mhfsdcap03> References: <1519634042-12063-1-git-send-email-zhiyong.tao@mediatek.com> <1519634042-12063-5-git-send-email-zhiyong.tao@mediatek.com> <1519803217.8089.31.camel@mtkswgap22> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1519803217.8089.31.camel@mtkswgap22> Sender: linux-kernel-owner@vger.kernel.org To: Sean Wang Cc: robh+dt@kernel.org, linus.walleij@linaro.org, mark.rutland@arm.com, matthias.bgg@gmail.com, devicetree@vger.kernel.org, hongkun.cao@mediatek.com, srv_heupstream@mediatek.com, linux-gpio@vger.kernel.org, biao.huang@mediatek.com, erin.lo@mediatek.com, liguo.zhang@mediatek.com, linux-kernel@vger.kernel.org, hongzhou.yang@mediatek.com, linux-mediatek@lists.infradead.org, yingjoe.chen@mediatek.com, linux-arm-kernel@lists.infradead.org List-Id: linux-gpio@vger.kernel.org On Wed, 2018-02-28 at 15:33 +0800, Sean Wang wrote: > On Mon, 2018-02-26 at 16:34 +0800, Zhiyong Tao wrote: > > For generic pins, parameter "arg" is 0 or 1. > > For special pins, bias-disable is set by R0R1, > > so we need transmited "00" to set bias-disable > > When we set "bias-disable" as high-z property, > > the parameter should be "MTK_PUPD_SET_R1R0_00". > > > > Signed-off-by: Zhiyong Tao > > --- > > drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 13 +++++++++++-- > > 1 file changed, 11 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c > > index 3cf384f..e88ba04 100644 > > --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c > > +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c > > @@ -301,8 +301,17 @@ static int mtk_pconf_set_pull_select(struct mtk_pinctrl *pctl, > > * resistor bit, so we need this special handle. > > */ > > if (pctl->devdata->spec_pull_set) { > > - ret = pctl->devdata->spec_pull_set(mtk_get_regmap(pctl, pin), > > - pin, pctl->devdata->port_align, isup, arg); > > + if (enable) { > > + ret = pctl->devdata->spec_pull_set( > > + mtk_get_regmap(pctl, pin), pin, > > + pctl->devdata->port_align, isup, > > + arg); > > + } else { > > + ret = pctl->devdata->spec_pull_set( > > + mtk_get_regmap(pctl, pin), pin, > > + pctl->devdata->port_align, isup, > > + MTK_PUPD_SET_R1R0_00); > > + } > > > it looks like you can use as following snippet with reusing original > logic and less effort on maintaining these common code (?) ==> Thanks for your suggestion very much. It seems better. I will change it in v3. > > > if (pctl->devdata->spec_pull_set) { > + if (!enable) > + arg = MTK_PUPD_SET_R1R0_00; > > ret = pctl->devdata->spec_pull_set(mtk_get_regmap(pctl, pin), > pin, pctl->devdata->port_align, isup, arg); > > > Also, it's better to add more comments to such kind of special path for > allowing future SoCs to follow and extend more easily. ==> Thanks for your suggestion very much. I will add more comments here. > > > if (!ret) > > return 0; > > } > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752125AbeB1Hta (ORCPT ); Wed, 28 Feb 2018 02:49:30 -0500 Received: from Mailgw01.mediatek.com ([1.203.163.78]:57792 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1750846AbeB1Ht2 (ORCPT ); Wed, 28 Feb 2018 02:49:28 -0500 X-UUID: 2dc1f6d5a1d04a8e85e080fe08fc03be-20180228 Message-ID: <1519804157.23198.9.camel@mhfsdcap03> Subject: Re: [PATCH v2 4/4] pintcrl: support bias-disable of generic and special pins simultaneously From: Zhiyong Tao To: Sean Wang CC: , , , , , , , , , , , , , , , Date: Wed, 28 Feb 2018 15:49:17 +0800 In-Reply-To: <1519803217.8089.31.camel@mtkswgap22> References: <1519634042-12063-1-git-send-email-zhiyong.tao@mediatek.com> <1519634042-12063-5-git-send-email-zhiyong.tao@mediatek.com> <1519803217.8089.31.camel@mtkswgap22> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2018-02-28 at 15:33 +0800, Sean Wang wrote: > On Mon, 2018-02-26 at 16:34 +0800, Zhiyong Tao wrote: > > For generic pins, parameter "arg" is 0 or 1. > > For special pins, bias-disable is set by R0R1, > > so we need transmited "00" to set bias-disable > > When we set "bias-disable" as high-z property, > > the parameter should be "MTK_PUPD_SET_R1R0_00". > > > > Signed-off-by: Zhiyong Tao > > --- > > drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 13 +++++++++++-- > > 1 file changed, 11 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c > > index 3cf384f..e88ba04 100644 > > --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c > > +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c > > @@ -301,8 +301,17 @@ static int mtk_pconf_set_pull_select(struct mtk_pinctrl *pctl, > > * resistor bit, so we need this special handle. > > */ > > if (pctl->devdata->spec_pull_set) { > > - ret = pctl->devdata->spec_pull_set(mtk_get_regmap(pctl, pin), > > - pin, pctl->devdata->port_align, isup, arg); > > + if (enable) { > > + ret = pctl->devdata->spec_pull_set( > > + mtk_get_regmap(pctl, pin), pin, > > + pctl->devdata->port_align, isup, > > + arg); > > + } else { > > + ret = pctl->devdata->spec_pull_set( > > + mtk_get_regmap(pctl, pin), pin, > > + pctl->devdata->port_align, isup, > > + MTK_PUPD_SET_R1R0_00); > > + } > > > it looks like you can use as following snippet with reusing original > logic and less effort on maintaining these common code (?) ==> Thanks for your suggestion very much. It seems better. I will change it in v3. > > > if (pctl->devdata->spec_pull_set) { > + if (!enable) > + arg = MTK_PUPD_SET_R1R0_00; > > ret = pctl->devdata->spec_pull_set(mtk_get_regmap(pctl, pin), > pin, pctl->devdata->port_align, isup, arg); > > > Also, it's better to add more comments to such kind of special path for > allowing future SoCs to follow and extend more easily. ==> Thanks for your suggestion very much. I will add more comments here. > > > if (!ret) > > return 0; > > } > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: zhiyong.tao@mediatek.com (Zhiyong Tao) Date: Wed, 28 Feb 2018 15:49:17 +0800 Subject: [PATCH v2 4/4] pintcrl: support bias-disable of generic and special pins simultaneously In-Reply-To: <1519803217.8089.31.camel@mtkswgap22> References: <1519634042-12063-1-git-send-email-zhiyong.tao@mediatek.com> <1519634042-12063-5-git-send-email-zhiyong.tao@mediatek.com> <1519803217.8089.31.camel@mtkswgap22> Message-ID: <1519804157.23198.9.camel@mhfsdcap03> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, 2018-02-28 at 15:33 +0800, Sean Wang wrote: > On Mon, 2018-02-26 at 16:34 +0800, Zhiyong Tao wrote: > > For generic pins, parameter "arg" is 0 or 1. > > For special pins, bias-disable is set by R0R1, > > so we need transmited "00" to set bias-disable > > When we set "bias-disable" as high-z property, > > the parameter should be "MTK_PUPD_SET_R1R0_00". > > > > Signed-off-by: Zhiyong Tao > > --- > > drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 13 +++++++++++-- > > 1 file changed, 11 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c > > index 3cf384f..e88ba04 100644 > > --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c > > +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c > > @@ -301,8 +301,17 @@ static int mtk_pconf_set_pull_select(struct mtk_pinctrl *pctl, > > * resistor bit, so we need this special handle. > > */ > > if (pctl->devdata->spec_pull_set) { > > - ret = pctl->devdata->spec_pull_set(mtk_get_regmap(pctl, pin), > > - pin, pctl->devdata->port_align, isup, arg); > > + if (enable) { > > + ret = pctl->devdata->spec_pull_set( > > + mtk_get_regmap(pctl, pin), pin, > > + pctl->devdata->port_align, isup, > > + arg); > > + } else { > > + ret = pctl->devdata->spec_pull_set( > > + mtk_get_regmap(pctl, pin), pin, > > + pctl->devdata->port_align, isup, > > + MTK_PUPD_SET_R1R0_00); > > + } > > > it looks like you can use as following snippet with reusing original > logic and less effort on maintaining these common code (?) ==> Thanks for your suggestion very much. It seems better. I will change it in v3. > > > if (pctl->devdata->spec_pull_set) { > + if (!enable) > + arg = MTK_PUPD_SET_R1R0_00; > > ret = pctl->devdata->spec_pull_set(mtk_get_regmap(pctl, pin), > pin, pctl->devdata->port_align, isup, arg); > > > Also, it's better to add more comments to such kind of special path for > allowing future SoCs to follow and extend more easily. ==> Thanks for your suggestion very much. I will add more comments here. > > > if (!ret) > > return 0; > > } > >