All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH v3 0/4] Initial support for NXP iMX8 (imx8mq-evk)
@ 2018-02-28  8:37 Erik Larsson
  2018-02-28  8:37 ` [Buildroot] [PATCH v3 1/4] imx-mkimage: new package Erik Larsson
                   ` (3 more replies)
  0 siblings, 4 replies; 9+ messages in thread
From: Erik Larsson @ 2018-02-28  8:37 UTC (permalink / raw)
  To: buildroot

This series provides initial support for NXP iMX8 (imx8mq-evk).

This series of patches are tested against NXP imx8mq-evk.
It only handles basic support for iIMX8M, currently no
support for GPU, VPU and other HW features. This series
makes it possible to build a minimal system for imx8mq-evk.

Changes since v2
================
  - Build kernel, u-boot, atf based on tags instead of branches.
  - Make sure to assign BR2_PACKAGE_FREESCALE_IMX_PLATFORM to IMX8M.
  - Remove kernel defconfig from board folder and use arch default in kernel tree.
  - Split third commit into two commits.

Changes since v1
================
  - Removed new imx-atf package, use boot/arm-trusted-firmware.
  - Move imx-mkimage from package/freescale-imx to package.
  - Add upstream URL for imx-mkimage in Config.in.host.
  - Fix install command syntax for imx-mkimage package.
  - Use Makefile in imx-mkimage to build imx-boot-imx8mqevk-sd.bin instead of doing that in the post-script.sh
  - Split third commit into two, one for firmware-img package and one for iMX8 board.

Erik Larsson (4):
  imx-mkimage: new package
  freescale-imx: add new device iMX8mq
  firmware-imx: add support for iMX8M firmware
  configs/freescale_imx8mqevk: new defconfig

 .../common/imx/genimage.cfg.template_imx8          | 40 ++++++++++++++++++++++
 board/freescale/common/imx/post-image.sh           | 10 ++++--
 configs/freescale_imx8mqevk_defconfig              | 38 ++++++++++++++++++++
 package/Config.in.host                             |  1 +
 package/freescale-imx/Config.in                    |  5 ++-
 package/freescale-imx/firmware-imx/Config.in       |  2 +-
 package/freescale-imx/firmware-imx/firmware-imx.mk |  8 +++++
 .../imx-mkimage/0001-remove-git-build-info.patch   | 29 ++++++++++++++++
 package/imx-mkimage/Config.in.host                 | 11 ++++++
 package/imx-mkimage/imx-mkimage.hash               |  3 ++
 package/imx-mkimage/imx-mkimage.mk                 | 39 +++++++++++++++++++++
 11 files changed, 181 insertions(+), 5 deletions(-)
 create mode 100644 board/freescale/common/imx/genimage.cfg.template_imx8
 create mode 100644 configs/freescale_imx8mqevk_defconfig
 create mode 100644 package/imx-mkimage/0001-remove-git-build-info.patch
 create mode 100644 package/imx-mkimage/Config.in.host
 create mode 100644 package/imx-mkimage/imx-mkimage.hash
 create mode 100644 package/imx-mkimage/imx-mkimage.mk

-- 
2.7.4

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Buildroot] [PATCH v3 1/4] imx-mkimage: new package
  2018-02-28  8:37 [Buildroot] [PATCH v3 0/4] Initial support for NXP iMX8 (imx8mq-evk) Erik Larsson
@ 2018-02-28  8:37 ` Erik Larsson
  2018-02-28  8:37 ` [Buildroot] [PATCH v3 2/4] freescale-imx: add new device iMX8mq Erik Larsson
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 9+ messages in thread
From: Erik Larsson @ 2018-02-28  8:37 UTC (permalink / raw)
  To: buildroot

This package add support for imx-mkimage for iMX8M.
Currently the only hardware it's tested for.

Signed-off-by: Erik Larsson <karl.erik.larsson@gmail.com>
Signed-off-by: Christopher Dahlberg <crille.dahlberg@gmail.com>
---
v3: Use BR2_TARGET_UBOOT_FORMAT_CUSTOM_NAME in U-Boot so we don't
    need to copy u-boot.bin to u-boot-nodtb.bin (suggested by Baruch)
    Update license to GPL-2.0+ (suggested by Marcus F.)
v2: Moved package from package/freescale-imx to package (suggested by Thomas P.)
    Add upstread URL in Config.in (suggested by Thomas P.)
    Fix install syntax in imx-mkimage.mk (suggested by Thomas P.)
    Use Makefile in imx-mkimage to build imx-boot-imx8mqevk-sd.bin instead of doing that in the post-script.sh (suggested Baruch)
---
 package/Config.in.host                             |  1 +
 .../imx-mkimage/0001-remove-git-build-info.patch   | 29 ++++++++++++++++
 package/imx-mkimage/Config.in.host                 | 11 ++++++
 package/imx-mkimage/imx-mkimage.hash               |  3 ++
 package/imx-mkimage/imx-mkimage.mk                 | 39 ++++++++++++++++++++++
 5 files changed, 83 insertions(+)
 create mode 100644 package/imx-mkimage/0001-remove-git-build-info.patch
 create mode 100644 package/imx-mkimage/Config.in.host
 create mode 100644 package/imx-mkimage/imx-mkimage.hash
 create mode 100644 package/imx-mkimage/imx-mkimage.mk

diff --git a/package/Config.in.host b/package/Config.in.host
index 199a8e9..06ef5cb 100644
--- a/package/Config.in.host
+++ b/package/Config.in.host
@@ -24,6 +24,7 @@ menu "Host utilities"
 	source "package/go-bootstrap/Config.in.host"
 	source "package/google-breakpad/Config.in.host"
 	source "package/gptfdisk/Config.in.host"
+	source "package/imx-mkimage/Config.in.host"
 	source "package/imx-usb-loader/Config.in.host"
 	source "package/jq/Config.in.host"
 	source "package/jsmin/Config.in.host"
diff --git a/package/imx-mkimage/0001-remove-git-build-info.patch b/package/imx-mkimage/0001-remove-git-build-info.patch
new file mode 100644
index 0000000..9f8da02
--- /dev/null
+++ b/package/imx-mkimage/0001-remove-git-build-info.patch
@@ -0,0 +1,29 @@
+From d1bb893300b1bd80eaac27fcc8eb4347f56f83b4 Mon Sep 17 00:00:00 2001
+From: Erik Larsson <erik.larsson@combitech.se>
+Date: Thu, 22 Feb 2018 09:56:53 +0100
+Subject: [PATCH] Remove buildinformation step.
+
+Signed-off-by: Erik Larsson <erik.larsson@combitech.se>
+Signed-off-by: Christopher Dahlberg <crille.dahlberg@gmail.com>
+---
+ Makefile | 4 +---
+ 1 file changed, 1 insertion(+), 3 deletions(-)
+
+diff --git a/Makefile b/Makefile
+index 4b449ad..4042a39 100644
+--- a/Makefile
++++ b/Makefile
+@@ -33,9 +33,7 @@ $(MKIMG): buildinfo $(SRCS)
+ bin: $(MKIMG)
+ 
+ buildinfo:
+-	@echo -n '#define MKIMAGE_COMMIT 0x' > src/build_info.h
+-	@git rev-parse --short=8 HEAD >> src/build_info.h
+-	@echo '' >> src/build_info.h
++	@echo "#define MKIMAGE_COMMIT 0x0000" > src/build_info.h
+ 
+ help:
+ 	@echo $(CURR_DIR)
+-- 
+2.7.4
+
diff --git a/package/imx-mkimage/Config.in.host b/package/imx-mkimage/Config.in.host
new file mode 100644
index 0000000..411f67c
--- /dev/null
+++ b/package/imx-mkimage/Config.in.host
@@ -0,0 +1,11 @@
+config BR2_PACKAGE_HOST_IMX_MKIMAGE
+	bool "host imx-mkimage"
+	select BR2_PACKAGE_HOST_UBOOT_TOOLS
+	select BR2_PACKAGE_HOST_UBOOT_TOOLS_FIT_SUPPORT
+	depends on BR2_LINUX_KERNEL
+	depends on BR2_TARGET_UBOOT
+	help
+	  imx-mkimage is used to combine input images and generate
+	  final boot image with appropriate IVT set.
+
+	  https://source.codeaurora.org/external/imx/imx-mkimage
diff --git a/package/imx-mkimage/imx-mkimage.hash b/package/imx-mkimage/imx-mkimage.hash
new file mode 100644
index 0000000..08d31ce
--- /dev/null
+++ b/package/imx-mkimage/imx-mkimage.hash
@@ -0,0 +1,3 @@
+# Locally calculated
+sha256 4ddb144520001c33baa24493f68ef2ea9434ac36bf3ae223f78d7ec581aa484c  imx-mkimage-imx_4.9.51_imx8m_beta.tar.gz
+sha256 231f7edcc7352d7734a96eef0b8030f77982678c516876fcb81e25b32d68564c  iMX8dv/COPYING
diff --git a/package/imx-mkimage/imx-mkimage.mk b/package/imx-mkimage/imx-mkimage.mk
new file mode 100644
index 0000000..506ae75
--- /dev/null
+++ b/package/imx-mkimage/imx-mkimage.mk
@@ -0,0 +1,39 @@
+################################################################################
+#
+# imx-mkimage
+#
+################################################################################
+
+IMX_MKIMAGE_VERSION = imx_4.9.51_imx8m_beta
+IMX_MKIMAGE_SITE = https://source.codeaurora.org/external/imx/imx-mkimage
+IMX_MKIMAGE_SITE_METHOD = git
+IMX_MKIMAGE_LICENSE = GPL-2.0+
+IMX_MKIMAGE_LICENSE_FILES = iMX8dv/COPYING
+HOST_IMX_MKIMAGE_DEPENDENCIES = uboot linux firmware-imx arm-trusted-firmware
+
+define HOST_IMX_MKIMAGE_BUILD_CMDS
+	# These files are generated by firmware-imx, uboot and arm-trusted-firmware
+	# Copy the files into the iMX8M folder to make building of this package simple
+	# The NXP engineers has constructed to buildprocess with a bunch of hardcoded
+	# file names and pathes.
+
+	# Currently this only supports iMX8M. When more hardware is available
+	# this needs to be selectable based on iMX8-version (iMX8M,iMXQ etc).
+	cp $(BINARIES_DIR)/u-boot-spl.bin $(@D)/iMX8M
+	cp $(BINARIES_DIR)/lpddr4_pmu_train* $(@D)/iMX8M
+	cp $(BINARIES_DIR)/fsl-imx8mq-evk.dtb $(@D)/iMX8M
+	cp $(BINARIES_DIR)/bl31.bin $(@D)/iMX8M
+	cp ${BINARIES_DIR}/u-boot-nodtb.bin $(@D)/iMX8M
+
+	# In soc.mk it's hardcoded that the mkimage tool is named mkimage_uboot
+	# and that it's located in the iMX8M folder.
+	cp $(HOST_DIR)/bin/mkimage $(@D)/iMX8M/mkimage_uboot
+
+	$(MAKE) -C $(@D) SOC=iMX8M flash_spl_uboot
+endef
+
+define HOST_IMX_MKIMAGE_INSTALL_CMDS
+	$(INSTALL) -D -m 755 $(@D)/iMX8M/flash.bin $(BINARIES_DIR)/imx-boot-imx8mqevk-sd.bin
+endef
+
+$(eval $(host-generic-package))
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [Buildroot] [PATCH v3 2/4] freescale-imx: add new device iMX8mq
  2018-02-28  8:37 [Buildroot] [PATCH v3 0/4] Initial support for NXP iMX8 (imx8mq-evk) Erik Larsson
  2018-02-28  8:37 ` [Buildroot] [PATCH v3 1/4] imx-mkimage: new package Erik Larsson
@ 2018-02-28  8:37 ` Erik Larsson
  2018-03-01 10:35   ` Gary Bisson
  2018-02-28  8:37 ` [Buildroot] [PATCH v3 3/4] firmware-imx: add support for iMX8M firmware Erik Larsson
  2018-02-28  8:37 ` [Buildroot] [PATCH v3 4/4] configs/freescale_imx8mqevk: new defconfig Erik Larsson
  3 siblings, 1 reply; 9+ messages in thread
From: Erik Larsson @ 2018-02-28  8:37 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Erik Larsson <karl.erik.larsson@gmail.com>
Signed-off-by: Christopher Dahlberg <crille.dahlberg@gmail.com>
---
 package/freescale-imx/Config.in | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/package/freescale-imx/Config.in b/package/freescale-imx/Config.in
index b5e5ab2..fe993f3 100644
--- a/package/freescale-imx/Config.in
+++ b/package/freescale-imx/Config.in
@@ -1,6 +1,6 @@
 menuconfig BR2_PACKAGE_FREESCALE_IMX
 	bool "Freescale i.MX libraries"
-	depends on BR2_arm
+	depends on BR2_arm || BR2_aarch64
 	help
 	  Those packages provide hardware acceleration for GPU or VPU,
 	  hardware optimization or some hardware tools for Freescale
@@ -40,6 +40,8 @@ config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX6UL
 config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX7
 	bool "imx7d/imx7ulp"
 
+config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8M
+	bool "imx8m"
 endchoice
 
 config BR2_PACKAGE_FREESCALE_IMX_PLATFORM
@@ -54,6 +56,7 @@ config BR2_PACKAGE_FREESCALE_IMX_PLATFORM
 	default "IMX6S" if BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX6S
 	default "IMX6UL" if BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX6UL
 	default "IMX7" if BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX7
+	default "IMX8" if BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8M
 
 config BR2_PACKAGE_FREESCALE_IMX_HAS_VPU
 	bool
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [Buildroot] [PATCH v3 3/4] firmware-imx: add support for iMX8M firmware
  2018-02-28  8:37 [Buildroot] [PATCH v3 0/4] Initial support for NXP iMX8 (imx8mq-evk) Erik Larsson
  2018-02-28  8:37 ` [Buildroot] [PATCH v3 1/4] imx-mkimage: new package Erik Larsson
  2018-02-28  8:37 ` [Buildroot] [PATCH v3 2/4] freescale-imx: add new device iMX8mq Erik Larsson
@ 2018-02-28  8:37 ` Erik Larsson
  2018-02-28  8:37 ` [Buildroot] [PATCH v3 4/4] configs/freescale_imx8mqevk: new defconfig Erik Larsson
  3 siblings, 0 replies; 9+ messages in thread
From: Erik Larsson @ 2018-02-28  8:37 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Erik Larsson <karl.erik.larsson@gmail.com>
Signed-off-by: Christopher Dahlberg <crille.dahlberg@gmail.com>
---
v3: Split v2 commit into two commits (suggested by Garry B.)
v2: Split v1 commit into two commits (suggested by Baruch)
---
 package/freescale-imx/firmware-imx/Config.in       | 2 +-
 package/freescale-imx/firmware-imx/firmware-imx.mk | 8 ++++++++
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/package/freescale-imx/firmware-imx/Config.in b/package/freescale-imx/firmware-imx/Config.in
index fca280a..56d5b80 100644
--- a/package/freescale-imx/firmware-imx/Config.in
+++ b/package/freescale-imx/firmware-imx/Config.in
@@ -1,6 +1,6 @@
 config BR2_PACKAGE_FIRMWARE_IMX
 	bool "firmware-imx"
-	depends on BR2_arm # Only relevant for i.MX
+	depends on BR2_arm || BR2_aarch64 # Only relevant for i.MX
 	help
 	  Firmware blobs for the Freescale i.MX SoCs.
 
diff --git a/package/freescale-imx/firmware-imx/firmware-imx.mk b/package/freescale-imx/firmware-imx/firmware-imx.mk
index 630afca..f03daf2 100644
--- a/package/freescale-imx/firmware-imx/firmware-imx.mk
+++ b/package/freescale-imx/firmware-imx/firmware-imx.mk
@@ -18,6 +18,13 @@ define FIRMWARE_IMX_EXTRACT_CMDS
 	$(call FREESCALE_IMX_EXTRACT_HELPER,$(DL_DIR)/$(FIRMWARE_IMX_SOURCE))
 endef
 
+ifeq ($(BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8M),y)
+FIRMWARE_IMX_INSTALL_IMAGES = YES
+define FIRMWARE_IMX_INSTALL_IMAGES_CMDS
+	cp $(@D)/firmware/ddr/synopsys/lpddr4_pmu_train_*.bin $(BINARIES_DIR)
+	cp $(@D)/firmware/hdmi/cadence/signed_hdmi_imx8m.bin $(BINARIES_DIR)
+endef
+else
 define FIRMWARE_IMX_INSTALL_TARGET_CMDS
 	mkdir -p $(TARGET_DIR)/lib/firmware/imx
 	for blobdir in $(FIRMWARE_IMX_BLOBS); do \
@@ -27,5 +34,6 @@ define FIRMWARE_IMX_INSTALL_TARGET_CMDS
 	mv $(TARGET_DIR)/lib/firmware/imx/epdc/epdc_ED060XH2C1.fw.nonrestricted \
 		$(TARGET_DIR)/lib/firmware/imx/epdc/epdc_ED060XH2C1.fw
 endef
+endif
 
 $(eval $(generic-package))
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [Buildroot] [PATCH v3 4/4] configs/freescale_imx8mqevk: new defconfig
  2018-02-28  8:37 [Buildroot] [PATCH v3 0/4] Initial support for NXP iMX8 (imx8mq-evk) Erik Larsson
                   ` (2 preceding siblings ...)
  2018-02-28  8:37 ` [Buildroot] [PATCH v3 3/4] firmware-imx: add support for iMX8M firmware Erik Larsson
@ 2018-02-28  8:37 ` Erik Larsson
  2018-03-01 10:42   ` Gary Bisson
  3 siblings, 1 reply; 9+ messages in thread
From: Erik Larsson @ 2018-02-28  8:37 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Erik Larsson <karl.erik.larsson@gmail.com>
Signed-off-by: Christopher Dahlberg <crille.dahlberg@gmail.com>
---
v3: Change commit message (suggested by Thomas P.)
    Make sure to use tags instead of branches in kernel,bootloader and ATF repositorires (Arnout V.)
    Use BR2_LINUX_KERNEL_USE_ARCH_DEFAULT_CONFIG instead of copy kernel defconfig to board folder (suggested by Arnout V.)
    Split v2 commit into two commits
---
 .../common/imx/genimage.cfg.template_imx8          | 40 ++++++++++++++++++++++
 board/freescale/common/imx/post-image.sh           | 10 ++++--
 configs/freescale_imx8mqevk_defconfig              | 38 ++++++++++++++++++++
 3 files changed, 85 insertions(+), 3 deletions(-)
 create mode 100644 board/freescale/common/imx/genimage.cfg.template_imx8
 create mode 100644 configs/freescale_imx8mqevk_defconfig

diff --git a/board/freescale/common/imx/genimage.cfg.template_imx8 b/board/freescale/common/imx/genimage.cfg.template_imx8
new file mode 100644
index 0000000..138beff
--- /dev/null
+++ b/board/freescale/common/imx/genimage.cfg.template_imx8
@@ -0,0 +1,40 @@
+# Minimal SD card image for the Freescale boards Template for SPL Boot
+#
+# We mimic the .sdcard Freescale's image format:
+# * the SD card must have 33 kB free space at the beginning,
+# * U-Boot is integrated into imx-boot-imx8mqevk-sd.bin and is dumped as is,
+# * a FAT partition at offset 64MB is containing Image and DTB files
+# * a single root filesystem partition is required (ext2, ext3 or ext4)
+#
+
+image boot.vfat {
+  vfat {
+    files = {
+      %FILES%
+    }
+  }
+  size = 64M
+}
+
+image sdcard.img {
+  hdimage {
+  }
+
+  partition imx-boot {
+    in-partition-table = "no"
+    image = "imx-boot-imx8mqevk-sd.bin"
+    offset = 33K
+  }
+
+  partition boot {
+    partition-type = 0xC
+    bootable = "true"
+    image = "boot.vfat"
+    offset = 8M
+  }
+
+  partition rootfs {
+    partition-type = 0x83
+    image = "rootfs.ext2"
+  }
+}
diff --git a/board/freescale/common/imx/post-image.sh b/board/freescale/common/imx/post-image.sh
index b239743..264c8a4 100755
--- a/board/freescale/common/imx/post-image.sh
+++ b/board/freescale/common/imx/post-image.sh
@@ -7,10 +7,10 @@
 #
 dtb_list()
 {
-	local DTB_LIST="$(sed -n 's/^BR2_LINUX_KERNEL_INTREE_DTS_NAME="\([a-z0-9 \-]*\)"$/\1/p' ${BR2_CONFIG})"
+	local DTB_LIST="$(sed -n 's/^BR2_LINUX_KERNEL_INTREE_DTS_NAME="\([\/a-z0-9 \-]*\)"$/\1/p' ${BR2_CONFIG})"
 
 	for dt in $DTB_LIST; do
-		echo -n "\"$dt.dtb\", "
+		echo -n "\"`basename $dt`.dtb\", "
 	done
 }
 
@@ -23,6 +23,8 @@ linux_image()
 {
 	if grep -Eq "^BR2_LINUX_KERNEL_UIMAGE=y$" ${BR2_CONFIG}; then
 		echo "\"uImage\""
+	elif grep -Eq "^BR2_LINUX_KERNEL_IMAGE=y$" ${BR2_CONFIG}; then
+		echo "\"Image\""
 	else
 		echo "\"zImage\""
 	fi
@@ -30,7 +32,9 @@ linux_image()
 
 genimage_type()
 {
-	if grep -Eq "^BR2_TARGET_UBOOT_SPL=y$" ${BR2_CONFIG}; then
+	if grep -Eq "^BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8M=y$" ${BR2_CONFIG}; then
+		echo "genimage.cfg.template_imx8"
+	elif grep -Eq "^BR2_TARGET_UBOOT_SPL=y$" ${BR2_CONFIG}; then
 		echo "genimage.cfg.template_spl"
 	else
 		echo "genimage.cfg.template"
diff --git a/configs/freescale_imx8mqevk_defconfig b/configs/freescale_imx8mqevk_defconfig
new file mode 100644
index 0000000..eae2c2a
--- /dev/null
+++ b/configs/freescale_imx8mqevk_defconfig
@@ -0,0 +1,38 @@
+BR2_aarch64=y
+BR2_ARM_FPU_VFPV3=y
+BR2_TOOLCHAIN_EXTERNAL=y
+BR2_TARGET_GENERIC_GETTY_PORT="ttymxc0"
+BR2_ROOTFS_POST_IMAGE_SCRIPT="board/freescale/common/imx/post-image.sh"
+BR2_LINUX_KERNEL=y
+BR2_LINUX_KERNEL_CUSTOM_GIT=y
+BR2_LINUX_KERNEL_CUSTOM_REPO_URL="https://source.codeaurora.org/external/imx/linux-imx"
+BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="rel_imx_4.9.51_8mq_beta"
+BR2_LINUX_KERNEL_USE_ARCH_DEFAULT_CONFIG=y
+BR2_LINUX_KERNEL_DTS_SUPPORT=y
+BR2_LINUX_KERNEL_INTREE_DTS_NAME="freescale/fsl-imx8mq-evk"
+BR2_PACKAGE_FREESCALE_IMX=y
+BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8M=y
+BR2_PACKAGE_FIRMWARE_IMX=y
+BR2_TARGET_ROOTFS_EXT2=y
+BR2_TARGET_ROOTFS_EXT2_4=y
+BR2_TARGET_ROOTFS_EXT2_SIZE="120M"
+BR2_TARGET_ARM_TRUSTED_FIRMWARE=y
+BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_GIT=y
+BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_REPO_URL="https://source.codeaurora.org/external/imx/imx-atf"
+BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_REPO_VERSION="rel_imx_4.9.51_8mq_beta"
+BR2_TARGET_ARM_TRUSTED_FIRMWARE_PLATFORM="imx8mq"
+BR2_TARGET_ARM_TRUSTED_FIRMWARE_BL31=y
+BR2_TARGET_UBOOT=y
+BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
+BR2_TARGET_UBOOT_CUSTOM_GIT=y
+BR2_TARGET_UBOOT_CUSTOM_REPO_URL="https://source.codeaurora.org/external/imx/uboot-imx"
+BR2_TARGET_UBOOT_CUSTOM_REPO_VERSION="o8.0.0_1.3.0_8m-prc"
+BR2_TARGET_UBOOT_BOARD_DEFCONFIG="imx8mq_evk"
+BR2_TARGET_UBOOT_FORMAT_IMX=y
+BR2_TARGET_UBOOT_FORMAT_CUSTOM=y
+BR2_TARGET_UBOOT_FORMAT_CUSTOM_NAME="u-boot-nodtb.bin"
+BR2_TARGET_UBOOT_SPL=y
+BR2_PACKAGE_HOST_DOSFSTOOLS=y
+BR2_PACKAGE_HOST_GENIMAGE=y
+BR2_PACKAGE_HOST_IMX_MKIMAGE=y
+BR2_PACKAGE_HOST_MTOOLS=y
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [Buildroot] [PATCH v3 2/4] freescale-imx: add new device iMX8mq
  2018-02-28  8:37 ` [Buildroot] [PATCH v3 2/4] freescale-imx: add new device iMX8mq Erik Larsson
@ 2018-03-01 10:35   ` Gary Bisson
  0 siblings, 0 replies; 9+ messages in thread
From: Gary Bisson @ 2018-03-01 10:35 UTC (permalink / raw)
  To: buildroot

Hi Erik,

On Wed, Feb 28, 2018 at 9:37 AM, Erik Larsson
<karl.erik.larsson@gmail.com> wrote:
> Signed-off-by: Erik Larsson <karl.erik.larsson@gmail.com>
> Signed-off-by: Christopher Dahlberg <crille.dahlberg@gmail.com>
> ---
>  package/freescale-imx/Config.in | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/package/freescale-imx/Config.in b/package/freescale-imx/Config.in
> index b5e5ab2..fe993f3 100644
> --- a/package/freescale-imx/Config.in
> +++ b/package/freescale-imx/Config.in
> @@ -1,6 +1,6 @@
>  menuconfig BR2_PACKAGE_FREESCALE_IMX
>         bool "Freescale i.MX libraries"
> -       depends on BR2_arm
> +       depends on BR2_arm || BR2_aarch64
>         help
>           Those packages provide hardware acceleration for GPU or VPU,
>           hardware optimization or some hardware tools for Freescale
> @@ -40,6 +40,8 @@ config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX6UL
>  config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX7
>         bool "imx7d/imx7ulp"
>
> +config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8M
> +       bool "imx8m"
>  endchoice
>
>  config BR2_PACKAGE_FREESCALE_IMX_PLATFORM
> @@ -54,6 +56,7 @@ config BR2_PACKAGE_FREESCALE_IMX_PLATFORM
>         default "IMX6S" if BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX6S
>         default "IMX6UL" if BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX6UL
>         default "IMX7" if BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX7
> +       default "IMX8" if BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8M
>
>  config BR2_PACKAGE_FREESCALE_IMX_HAS_VPU
>         bool
> --
> 2.7.4

The patch looks good but I'd change the title.

It should be "i.MX8M" (missing '.' and capital M). Also I'd drop the
'q' since this will apply to all 8M variants.

I'd prefer: "freescale-imx: add config option for i.MX8M"

Not sure it needs to respin the patch, might be changed when applied.

Regards,
Gary

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Buildroot] [PATCH v3 4/4] configs/freescale_imx8mqevk: new defconfig
  2018-02-28  8:37 ` [Buildroot] [PATCH v3 4/4] configs/freescale_imx8mqevk: new defconfig Erik Larsson
@ 2018-03-01 10:42   ` Gary Bisson
  2018-03-01 11:08     ` Erik Larsson
  0 siblings, 1 reply; 9+ messages in thread
From: Gary Bisson @ 2018-03-01 10:42 UTC (permalink / raw)
  To: buildroot

Hi Erik,

On Wed, Feb 28, 2018 at 9:37 AM, Erik Larsson
<karl.erik.larsson@gmail.com> wrote:
> Signed-off-by: Erik Larsson <karl.erik.larsson@gmail.com>
> Signed-off-by: Christopher Dahlberg <crille.dahlberg@gmail.com>
> ---
> v3: Change commit message (suggested by Thomas P.)
>     Make sure to use tags instead of branches in kernel,bootloader and ATF repositorires (Arnout V.)
>     Use BR2_LINUX_KERNEL_USE_ARCH_DEFAULT_CONFIG instead of copy kernel defconfig to board folder (suggested by Arnout V.)
>     Split v2 commit into two commits
> ---
>  .../common/imx/genimage.cfg.template_imx8          | 40 ++++++++++++++++++++++
>  board/freescale/common/imx/post-image.sh           | 10 ++++--
>  configs/freescale_imx8mqevk_defconfig              | 38 ++++++++++++++++++++
>  3 files changed, 85 insertions(+), 3 deletions(-)
>  create mode 100644 board/freescale/common/imx/genimage.cfg.template_imx8
>  create mode 100644 configs/freescale_imx8mqevk_defconfig
>
> diff --git a/board/freescale/common/imx/genimage.cfg.template_imx8 b/board/freescale/common/imx/genimage.cfg.template_imx8
> new file mode 100644
> index 0000000..138beff
> --- /dev/null
> +++ b/board/freescale/common/imx/genimage.cfg.template_imx8
> @@ -0,0 +1,40 @@
> +# Minimal SD card image for the Freescale boards Template for SPL Boot
> +#
> +# We mimic the .sdcard Freescale's image format:
> +# * the SD card must have 33 kB free space at the beginning,
> +# * U-Boot is integrated into imx-boot-imx8mqevk-sd.bin and is dumped as is,
> +# * a FAT partition at offset 64MB is containing Image and DTB files
> +# * a single root filesystem partition is required (ext2, ext3 or ext4)
> +#
> +
> +image boot.vfat {
> +  vfat {
> +    files = {
> +      %FILES%
> +    }
> +  }
> +  size = 64M
> +}
> +
> +image sdcard.img {
> +  hdimage {
> +  }
> +
> +  partition imx-boot {
> +    in-partition-table = "no"
> +    image = "imx-boot-imx8mqevk-sd.bin"
> +    offset = 33K
> +  }
> +
> +  partition boot {
> +    partition-type = 0xC
> +    bootable = "true"
> +    image = "boot.vfat"
> +    offset = 8M
> +  }
> +
> +  partition rootfs {
> +    partition-type = 0x83
> +    image = "rootfs.ext2"
> +  }
> +}
> diff --git a/board/freescale/common/imx/post-image.sh b/board/freescale/common/imx/post-image.sh
> index b239743..264c8a4 100755
> --- a/board/freescale/common/imx/post-image.sh
> +++ b/board/freescale/common/imx/post-image.sh
> @@ -7,10 +7,10 @@
>  #
>  dtb_list()
>  {
> -       local DTB_LIST="$(sed -n 's/^BR2_LINUX_KERNEL_INTREE_DTS_NAME="\([a-z0-9 \-]*\)"$/\1/p' ${BR2_CONFIG})"
> +       local DTB_LIST="$(sed -n 's/^BR2_LINUX_KERNEL_INTREE_DTS_NAME="\([\/a-z0-9 \-]*\)"$/\1/p' ${BR2_CONFIG})"
>
>         for dt in $DTB_LIST; do
> -               echo -n "\"$dt.dtb\", "
> +               echo -n "\"`basename $dt`.dtb\", "
>         done
>  }
>
> @@ -23,6 +23,8 @@ linux_image()
>  {
>         if grep -Eq "^BR2_LINUX_KERNEL_UIMAGE=y$" ${BR2_CONFIG}; then
>                 echo "\"uImage\""
> +       elif grep -Eq "^BR2_LINUX_KERNEL_IMAGE=y$" ${BR2_CONFIG}; then
> +               echo "\"Image\""
>         else
>                 echo "\"zImage\""
>         fi
> @@ -30,7 +32,9 @@ linux_image()
>
>  genimage_type()
>  {
> -       if grep -Eq "^BR2_TARGET_UBOOT_SPL=y$" ${BR2_CONFIG}; then
> +       if grep -Eq "^BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8M=y$" ${BR2_CONFIG}; then
> +               echo "genimage.cfg.template_imx8"
> +       elif grep -Eq "^BR2_TARGET_UBOOT_SPL=y$" ${BR2_CONFIG}; then
>                 echo "genimage.cfg.template_spl"
>         else
>                 echo "genimage.cfg.template"
> diff --git a/configs/freescale_imx8mqevk_defconfig b/configs/freescale_imx8mqevk_defconfig
> new file mode 100644
> index 0000000..eae2c2a
> --- /dev/null
> +++ b/configs/freescale_imx8mqevk_defconfig
> @@ -0,0 +1,38 @@
> +BR2_aarch64=y
> +BR2_ARM_FPU_VFPV3=y
> +BR2_TOOLCHAIN_EXTERNAL=y
> +BR2_TARGET_GENERIC_GETTY_PORT="ttymxc0"
> +BR2_ROOTFS_POST_IMAGE_SCRIPT="board/freescale/common/imx/post-image.sh"
> +BR2_LINUX_KERNEL=y
> +BR2_LINUX_KERNEL_CUSTOM_GIT=y
> +BR2_LINUX_KERNEL_CUSTOM_REPO_URL="https://source.codeaurora.org/external/imx/linux-imx"
> +BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="rel_imx_4.9.51_8mq_beta"
> +BR2_LINUX_KERNEL_USE_ARCH_DEFAULT_CONFIG=y
> +BR2_LINUX_KERNEL_DTS_SUPPORT=y
> +BR2_LINUX_KERNEL_INTREE_DTS_NAME="freescale/fsl-imx8mq-evk"
> +BR2_PACKAGE_FREESCALE_IMX=y
> +BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8M=y
> +BR2_PACKAGE_FIRMWARE_IMX=y
> +BR2_TARGET_ROOTFS_EXT2=y
> +BR2_TARGET_ROOTFS_EXT2_4=y
> +BR2_TARGET_ROOTFS_EXT2_SIZE="120M"
> +BR2_TARGET_ARM_TRUSTED_FIRMWARE=y
> +BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_GIT=y
> +BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_REPO_URL="https://source.codeaurora.org/external/imx/imx-atf"
> +BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_REPO_VERSION="rel_imx_4.9.51_8mq_beta"
> +BR2_TARGET_ARM_TRUSTED_FIRMWARE_PLATFORM="imx8mq"
> +BR2_TARGET_ARM_TRUSTED_FIRMWARE_BL31=y
> +BR2_TARGET_UBOOT=y
> +BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
> +BR2_TARGET_UBOOT_CUSTOM_GIT=y
> +BR2_TARGET_UBOOT_CUSTOM_REPO_URL="https://source.codeaurora.org/external/imx/uboot-imx"
> +BR2_TARGET_UBOOT_CUSTOM_REPO_VERSION="o8.0.0_1.3.0_8m-prc"

Why do you use the Android Oreo version of U-Boot?

Might be more consistent to use the same rel_imx_4.9.51_8mq_beta tag.

Regards,
Gary

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Buildroot] [PATCH v3 4/4] configs/freescale_imx8mqevk: new defconfig
  2018-03-01 10:42   ` Gary Bisson
@ 2018-03-01 11:08     ` Erik Larsson
  2018-03-01 14:18       ` Gary Bisson
  0 siblings, 1 reply; 9+ messages in thread
From: Erik Larsson @ 2018-03-01 11:08 UTC (permalink / raw)
  To: buildroot

Hi Gary,

2018-03-01 11:42 GMT+01:00 Gary Bisson <gary.bisson@boundarydevices.com>:
> Hi Erik,
>
> On Wed, Feb 28, 2018 at 9:37 AM, Erik Larsson
> <karl.erik.larsson@gmail.com> wrote:
>> Signed-off-by: Erik Larsson <karl.erik.larsson@gmail.com>
>> Signed-off-by: Christopher Dahlberg <crille.dahlberg@gmail.com>
>> ---
>> v3: Change commit message (suggested by Thomas P.)
>>     Make sure to use tags instead of branches in kernel,bootloader and ATF repositorires (Arnout V.)
>>     Use BR2_LINUX_KERNEL_USE_ARCH_DEFAULT_CONFIG instead of copy kernel defconfig to board folder (suggested by Arnout V.)
>>     Split v2 commit into two commits
>> ---
>>  .../common/imx/genimage.cfg.template_imx8          | 40 ++++++++++++++++++++++
>>  board/freescale/common/imx/post-image.sh           | 10 ++++--
>>  configs/freescale_imx8mqevk_defconfig              | 38 ++++++++++++++++++++
>>  3 files changed, 85 insertions(+), 3 deletions(-)
>>  create mode 100644 board/freescale/common/imx/genimage.cfg.template_imx8
>>  create mode 100644 configs/freescale_imx8mqevk_defconfig
>>
>> diff --git a/board/freescale/common/imx/genimage.cfg.template_imx8 b/board/freescale/common/imx/genimage.cfg.template_imx8
>> new file mode 100644
>> index 0000000..138beff
>> --- /dev/null
>> +++ b/board/freescale/common/imx/genimage.cfg.template_imx8
>> @@ -0,0 +1,40 @@
>> +# Minimal SD card image for the Freescale boards Template for SPL Boot
>> +#
>> +# We mimic the .sdcard Freescale's image format:
>> +# * the SD card must have 33 kB free space at the beginning,
>> +# * U-Boot is integrated into imx-boot-imx8mqevk-sd.bin and is dumped as is,
>> +# * a FAT partition at offset 64MB is containing Image and DTB files
>> +# * a single root filesystem partition is required (ext2, ext3 or ext4)
>> +#
>> +
>> +image boot.vfat {
>> +  vfat {
>> +    files = {
>> +      %FILES%
>> +    }
>> +  }
>> +  size = 64M
>> +}
>> +
>> +image sdcard.img {
>> +  hdimage {
>> +  }
>> +
>> +  partition imx-boot {
>> +    in-partition-table = "no"
>> +    image = "imx-boot-imx8mqevk-sd.bin"
>> +    offset = 33K
>> +  }
>> +
>> +  partition boot {
>> +    partition-type = 0xC
>> +    bootable = "true"
>> +    image = "boot.vfat"
>> +    offset = 8M
>> +  }
>> +
>> +  partition rootfs {
>> +    partition-type = 0x83
>> +    image = "rootfs.ext2"
>> +  }
>> +}
>> diff --git a/board/freescale/common/imx/post-image.sh b/board/freescale/common/imx/post-image.sh
>> index b239743..264c8a4 100755
>> --- a/board/freescale/common/imx/post-image.sh
>> +++ b/board/freescale/common/imx/post-image.sh
>> @@ -7,10 +7,10 @@
>>  #
>>  dtb_list()
>>  {
>> -       local DTB_LIST="$(sed -n 's/^BR2_LINUX_KERNEL_INTREE_DTS_NAME="\([a-z0-9 \-]*\)"$/\1/p' ${BR2_CONFIG})"
>> +       local DTB_LIST="$(sed -n 's/^BR2_LINUX_KERNEL_INTREE_DTS_NAME="\([\/a-z0-9 \-]*\)"$/\1/p' ${BR2_CONFIG})"
>>
>>         for dt in $DTB_LIST; do
>> -               echo -n "\"$dt.dtb\", "
>> +               echo -n "\"`basename $dt`.dtb\", "
>>         done
>>  }
>>
>> @@ -23,6 +23,8 @@ linux_image()
>>  {
>>         if grep -Eq "^BR2_LINUX_KERNEL_UIMAGE=y$" ${BR2_CONFIG}; then
>>                 echo "\"uImage\""
>> +       elif grep -Eq "^BR2_LINUX_KERNEL_IMAGE=y$" ${BR2_CONFIG}; then
>> +               echo "\"Image\""
>>         else
>>                 echo "\"zImage\""
>>         fi
>> @@ -30,7 +32,9 @@ linux_image()
>>
>>  genimage_type()
>>  {
>> -       if grep -Eq "^BR2_TARGET_UBOOT_SPL=y$" ${BR2_CONFIG}; then
>> +       if grep -Eq "^BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8M=y$" ${BR2_CONFIG}; then
>> +               echo "genimage.cfg.template_imx8"
>> +       elif grep -Eq "^BR2_TARGET_UBOOT_SPL=y$" ${BR2_CONFIG}; then
>>                 echo "genimage.cfg.template_spl"
>>         else
>>                 echo "genimage.cfg.template"
>> diff --git a/configs/freescale_imx8mqevk_defconfig b/configs/freescale_imx8mqevk_defconfig
>> new file mode 100644
>> index 0000000..eae2c2a
>> --- /dev/null
>> +++ b/configs/freescale_imx8mqevk_defconfig
>> @@ -0,0 +1,38 @@
>> +BR2_aarch64=y
>> +BR2_ARM_FPU_VFPV3=y
>> +BR2_TOOLCHAIN_EXTERNAL=y
>> +BR2_TARGET_GENERIC_GETTY_PORT="ttymxc0"
>> +BR2_ROOTFS_POST_IMAGE_SCRIPT="board/freescale/common/imx/post-image.sh"
>> +BR2_LINUX_KERNEL=y
>> +BR2_LINUX_KERNEL_CUSTOM_GIT=y
>> +BR2_LINUX_KERNEL_CUSTOM_REPO_URL="https://source.codeaurora.org/external/imx/linux-imx"
>> +BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="rel_imx_4.9.51_8mq_beta"
>> +BR2_LINUX_KERNEL_USE_ARCH_DEFAULT_CONFIG=y
>> +BR2_LINUX_KERNEL_DTS_SUPPORT=y
>> +BR2_LINUX_KERNEL_INTREE_DTS_NAME="freescale/fsl-imx8mq-evk"
>> +BR2_PACKAGE_FREESCALE_IMX=y
>> +BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8M=y
>> +BR2_PACKAGE_FIRMWARE_IMX=y
>> +BR2_TARGET_ROOTFS_EXT2=y
>> +BR2_TARGET_ROOTFS_EXT2_4=y
>> +BR2_TARGET_ROOTFS_EXT2_SIZE="120M"
>> +BR2_TARGET_ARM_TRUSTED_FIRMWARE=y
>> +BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_GIT=y
>> +BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_REPO_URL="https://source.codeaurora.org/external/imx/imx-atf"
>> +BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_REPO_VERSION="rel_imx_4.9.51_8mq_beta"
>> +BR2_TARGET_ARM_TRUSTED_FIRMWARE_PLATFORM="imx8mq"
>> +BR2_TARGET_ARM_TRUSTED_FIRMWARE_BL31=y
>> +BR2_TARGET_UBOOT=y
>> +BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
>> +BR2_TARGET_UBOOT_CUSTOM_GIT=y
>> +BR2_TARGET_UBOOT_CUSTOM_REPO_URL="https://source.codeaurora.org/external/imx/uboot-imx"
>> +BR2_TARGET_UBOOT_CUSTOM_REPO_VERSION="o8.0.0_1.3.0_8m-prc"
>
> Why do you use the Android Oreo version of U-Boot?
>
> Might be more consistent to use the same rel_imx_4.9.51_8mq_beta tag.

My first version had the branch imx_4.9.51_imx8m_beta, but as Baruch
pointed our for me it should be a tag or a commit and not a branch in
the config. He proposed this tag because it's "close" the to the
imx_4.9.51_imx8m_beta-branch. I thought that was a good tag to build
from. Building from rel_imx_4.9.51_8mq_beta is just "older" then
o8.0.0_1.3.0_8m-prc and don't have some bug fixes from NXP side in it.

To be honest I think "you guys" needs to advice me here. :)

>
> Regards,
> Gary

Regards,
Erik

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Buildroot] [PATCH v3 4/4] configs/freescale_imx8mqevk: new defconfig
  2018-03-01 11:08     ` Erik Larsson
@ 2018-03-01 14:18       ` Gary Bisson
  0 siblings, 0 replies; 9+ messages in thread
From: Gary Bisson @ 2018-03-01 14:18 UTC (permalink / raw)
  To: buildroot

Hi Erik,

On Thu, Mar 1, 2018 at 12:08 PM, Erik Larsson
<karl.erik.larsson@gmail.com> wrote:
> Hi Gary,
>
> 2018-03-01 11:42 GMT+01:00 Gary Bisson <gary.bisson@boundarydevices.com>:
>> Hi Erik,
>>
>> On Wed, Feb 28, 2018 at 9:37 AM, Erik Larsson
>> <karl.erik.larsson@gmail.com> wrote:
>>> Signed-off-by: Erik Larsson <karl.erik.larsson@gmail.com>
>>> Signed-off-by: Christopher Dahlberg <crille.dahlberg@gmail.com>
>>> ---
>>> v3: Change commit message (suggested by Thomas P.)
>>>     Make sure to use tags instead of branches in kernel,bootloader and ATF repositorires (Arnout V.)
>>>     Use BR2_LINUX_KERNEL_USE_ARCH_DEFAULT_CONFIG instead of copy kernel defconfig to board folder (suggested by Arnout V.)
>>>     Split v2 commit into two commits
>>> ---
>>>  .../common/imx/genimage.cfg.template_imx8          | 40 ++++++++++++++++++++++
>>>  board/freescale/common/imx/post-image.sh           | 10 ++++--
>>>  configs/freescale_imx8mqevk_defconfig              | 38 ++++++++++++++++++++
>>>  3 files changed, 85 insertions(+), 3 deletions(-)
>>>  create mode 100644 board/freescale/common/imx/genimage.cfg.template_imx8
>>>  create mode 100644 configs/freescale_imx8mqevk_defconfig
>>>
>>> diff --git a/board/freescale/common/imx/genimage.cfg.template_imx8 b/board/freescale/common/imx/genimage.cfg.template_imx8
>>> new file mode 100644
>>> index 0000000..138beff
>>> --- /dev/null
>>> +++ b/board/freescale/common/imx/genimage.cfg.template_imx8
>>> @@ -0,0 +1,40 @@
>>> +# Minimal SD card image for the Freescale boards Template for SPL Boot
>>> +#
>>> +# We mimic the .sdcard Freescale's image format:
>>> +# * the SD card must have 33 kB free space at the beginning,
>>> +# * U-Boot is integrated into imx-boot-imx8mqevk-sd.bin and is dumped as is,
>>> +# * a FAT partition at offset 64MB is containing Image and DTB files
>>> +# * a single root filesystem partition is required (ext2, ext3 or ext4)
>>> +#
>>> +
>>> +image boot.vfat {
>>> +  vfat {
>>> +    files = {
>>> +      %FILES%
>>> +    }
>>> +  }
>>> +  size = 64M
>>> +}
>>> +
>>> +image sdcard.img {
>>> +  hdimage {
>>> +  }
>>> +
>>> +  partition imx-boot {
>>> +    in-partition-table = "no"
>>> +    image = "imx-boot-imx8mqevk-sd.bin"
>>> +    offset = 33K
>>> +  }
>>> +
>>> +  partition boot {
>>> +    partition-type = 0xC
>>> +    bootable = "true"
>>> +    image = "boot.vfat"
>>> +    offset = 8M
>>> +  }
>>> +
>>> +  partition rootfs {
>>> +    partition-type = 0x83
>>> +    image = "rootfs.ext2"
>>> +  }
>>> +}
>>> diff --git a/board/freescale/common/imx/post-image.sh b/board/freescale/common/imx/post-image.sh
>>> index b239743..264c8a4 100755
>>> --- a/board/freescale/common/imx/post-image.sh
>>> +++ b/board/freescale/common/imx/post-image.sh
>>> @@ -7,10 +7,10 @@
>>>  #
>>>  dtb_list()
>>>  {
>>> -       local DTB_LIST="$(sed -n 's/^BR2_LINUX_KERNEL_INTREE_DTS_NAME="\([a-z0-9 \-]*\)"$/\1/p' ${BR2_CONFIG})"
>>> +       local DTB_LIST="$(sed -n 's/^BR2_LINUX_KERNEL_INTREE_DTS_NAME="\([\/a-z0-9 \-]*\)"$/\1/p' ${BR2_CONFIG})"
>>>
>>>         for dt in $DTB_LIST; do
>>> -               echo -n "\"$dt.dtb\", "
>>> +               echo -n "\"`basename $dt`.dtb\", "
>>>         done
>>>  }
>>>
>>> @@ -23,6 +23,8 @@ linux_image()
>>>  {
>>>         if grep -Eq "^BR2_LINUX_KERNEL_UIMAGE=y$" ${BR2_CONFIG}; then
>>>                 echo "\"uImage\""
>>> +       elif grep -Eq "^BR2_LINUX_KERNEL_IMAGE=y$" ${BR2_CONFIG}; then
>>> +               echo "\"Image\""
>>>         else
>>>                 echo "\"zImage\""
>>>         fi
>>> @@ -30,7 +32,9 @@ linux_image()
>>>
>>>  genimage_type()
>>>  {
>>> -       if grep -Eq "^BR2_TARGET_UBOOT_SPL=y$" ${BR2_CONFIG}; then
>>> +       if grep -Eq "^BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8M=y$" ${BR2_CONFIG}; then
>>> +               echo "genimage.cfg.template_imx8"
>>> +       elif grep -Eq "^BR2_TARGET_UBOOT_SPL=y$" ${BR2_CONFIG}; then
>>>                 echo "genimage.cfg.template_spl"
>>>         else
>>>                 echo "genimage.cfg.template"
>>> diff --git a/configs/freescale_imx8mqevk_defconfig b/configs/freescale_imx8mqevk_defconfig
>>> new file mode 100644
>>> index 0000000..eae2c2a
>>> --- /dev/null
>>> +++ b/configs/freescale_imx8mqevk_defconfig
>>> @@ -0,0 +1,38 @@
>>> +BR2_aarch64=y
>>> +BR2_ARM_FPU_VFPV3=y
>>> +BR2_TOOLCHAIN_EXTERNAL=y
>>> +BR2_TARGET_GENERIC_GETTY_PORT="ttymxc0"
>>> +BR2_ROOTFS_POST_IMAGE_SCRIPT="board/freescale/common/imx/post-image.sh"
>>> +BR2_LINUX_KERNEL=y
>>> +BR2_LINUX_KERNEL_CUSTOM_GIT=y
>>> +BR2_LINUX_KERNEL_CUSTOM_REPO_URL="https://source.codeaurora.org/external/imx/linux-imx"
>>> +BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="rel_imx_4.9.51_8mq_beta"
>>> +BR2_LINUX_KERNEL_USE_ARCH_DEFAULT_CONFIG=y
>>> +BR2_LINUX_KERNEL_DTS_SUPPORT=y
>>> +BR2_LINUX_KERNEL_INTREE_DTS_NAME="freescale/fsl-imx8mq-evk"
>>> +BR2_PACKAGE_FREESCALE_IMX=y
>>> +BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8M=y
>>> +BR2_PACKAGE_FIRMWARE_IMX=y
>>> +BR2_TARGET_ROOTFS_EXT2=y
>>> +BR2_TARGET_ROOTFS_EXT2_4=y
>>> +BR2_TARGET_ROOTFS_EXT2_SIZE="120M"
>>> +BR2_TARGET_ARM_TRUSTED_FIRMWARE=y
>>> +BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_GIT=y
>>> +BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_REPO_URL="https://source.codeaurora.org/external/imx/imx-atf"
>>> +BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_REPO_VERSION="rel_imx_4.9.51_8mq_beta"
>>> +BR2_TARGET_ARM_TRUSTED_FIRMWARE_PLATFORM="imx8mq"
>>> +BR2_TARGET_ARM_TRUSTED_FIRMWARE_BL31=y
>>> +BR2_TARGET_UBOOT=y
>>> +BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
>>> +BR2_TARGET_UBOOT_CUSTOM_GIT=y
>>> +BR2_TARGET_UBOOT_CUSTOM_REPO_URL="https://source.codeaurora.org/external/imx/uboot-imx"
>>> +BR2_TARGET_UBOOT_CUSTOM_REPO_VERSION="o8.0.0_1.3.0_8m-prc"
>>
>> Why do you use the Android Oreo version of U-Boot?
>>
>> Might be more consistent to use the same rel_imx_4.9.51_8mq_beta tag.
>
> My first version had the branch imx_4.9.51_imx8m_beta, but as Baruch
> pointed our for me it should be a tag or a commit and not a branch in
> the config. He proposed this tag because it's "close" the to the
> imx_4.9.51_imx8m_beta-branch. I thought that was a good tag to build
> from. Building from rel_imx_4.9.51_8mq_beta is just "older" then
> o8.0.0_1.3.0_8m-prc and don't have some bug fixes from NXP side in it.
>
> To be honest I think "you guys" needs to advice me here. :)

True, it is closer to latest commit of the branch. It used to be quite
different between android/linux U-Boot trees but it seems this time
they used the same branch (and different configs) so it's ok.

Thanks for the reminder about that change.

Regards,
Gary

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2018-03-01 14:18 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-28  8:37 [Buildroot] [PATCH v3 0/4] Initial support for NXP iMX8 (imx8mq-evk) Erik Larsson
2018-02-28  8:37 ` [Buildroot] [PATCH v3 1/4] imx-mkimage: new package Erik Larsson
2018-02-28  8:37 ` [Buildroot] [PATCH v3 2/4] freescale-imx: add new device iMX8mq Erik Larsson
2018-03-01 10:35   ` Gary Bisson
2018-02-28  8:37 ` [Buildroot] [PATCH v3 3/4] firmware-imx: add support for iMX8M firmware Erik Larsson
2018-02-28  8:37 ` [Buildroot] [PATCH v3 4/4] configs/freescale_imx8mqevk: new defconfig Erik Larsson
2018-03-01 10:42   ` Gary Bisson
2018-03-01 11:08     ` Erik Larsson
2018-03-01 14:18       ` Gary Bisson

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.