From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lucas Stach Subject: Re: [PATCH 1/5] drm/prime: fix potential race in drm_gem_map_detach Date: Wed, 28 Feb 2018 10:48:27 +0100 Message-ID: <1519811307.6253.5.camel@pengutronix.de> References: <20180227115000.4105-1-christian.koenig@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by gabe.freedesktop.org (Postfix) with ESMTPS id DA3156E915 for ; Wed, 28 Feb 2018 09:50:38 +0000 (UTC) In-Reply-To: <20180227115000.4105-1-christian.koenig@amd.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Christian =?ISO-8859-1?Q?K=F6nig?= , dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGkgQ2hyaXN0aWFuLAoKQW0gRGllbnN0YWcsIGRlbiAyNy4wMi4yMDE4LCAxMjo0OSArMDEwMCBz Y2hyaWViIENocmlzdGlhbiBLw7ZuaWc6Cj4gVW5waW4gdGhlIEdFTSBvYmplY3Qgb25seSBhZnRl ciBmcmVlaW5nIHRoZSBzZyB0YWJsZS4KCldoYXQgaXMgdGhlIHJhY2UgdGhhdCBpcyBiZWluZyBm aXhlZCBoZXJlPyBUaGUgU0cgdGFibGUgaXMgcHJpdmF0ZSB0bwp0aGUgaW1wb3J0ZXIgYW5kIHRo ZSBpbXBvcnRlciBzaG91bGQgaG9wZWZ1bGx5IG9ubHkgY2FsbCBtYXBfZGV0YWNoIGlmCml0IGlz IGRvbmUgd2l0aCBhbGwgb3BlcmF0aW9ucyB1c2luZyB0aGUgU0cgdGFibGUuIFRodXMgaXQgc2hv dWxkbid0Cm1hdHRlciB0aGF0IHRoZSBTRyB0YWJsZSBtaWdodCBwb2ludCB0byBtb3ZlZCBwYWdl cyBkdXJpbmcgZXhlY3V0aW9uIG9mCnRoaXMgZnVuY3Rpb24uCgpSZWdhcmRzLApMdWNhcwoKPiBT aWduZWQtb2ZmLWJ5OiBDaHJpc3RpYW4gS8O2bmlnIDxjaHJpc3RpYW4ua29lbmlnQGFtZC5jb20+ Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fcHJpbWUuYyB8IDMyICsrKysrKysrKysrKysr KystLS0tLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAxNiBpbnNlcnRpb25zKCspLCAx NiBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9wcmlt ZS5jCj4gYi9kcml2ZXJzL2dwdS9kcm0vZHJtX3ByaW1lLmMKPiBpbmRleCBlODJhOTc2ZjBmYmEu LmMzOGRhY2RhNjExOSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX3ByaW1lLmMK PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX3ByaW1lLmMKPiBAQCAtMjMwLDI2ICsyMzAsMjYg QEAgdm9pZCBkcm1fZ2VtX21hcF9kZXRhY2goc3RydWN0IGRtYV9idWYKPiAqZG1hX2J1ZiwKPiAg CXN0cnVjdCBkcm1fcHJpbWVfYXR0YWNobWVudCAqcHJpbWVfYXR0YWNoID0gYXR0YWNoLT5wcml2 Owo+ICAJc3RydWN0IGRybV9nZW1fb2JqZWN0ICpvYmogPSBkbWFfYnVmLT5wcml2Owo+ICAJc3Ry dWN0IGRybV9kZXZpY2UgKmRldiA9IG9iai0+ZGV2Owo+IC0Jc3RydWN0IHNnX3RhYmxlICpzZ3Q7 Cj4gIAo+IC0JaWYgKGRldi0+ZHJpdmVyLT5nZW1fcHJpbWVfdW5waW4pCj4gLQkJZGV2LT5kcml2 ZXItPmdlbV9wcmltZV91bnBpbihvYmopOwo+ICsJaWYgKHByaW1lX2F0dGFjaCkgewo+ICsJCXN0 cnVjdCBzZ190YWJsZSAqc2d0ID0gcHJpbWVfYXR0YWNoLT5zZ3Q7Cj4gIAo+IC0JaWYgKCFwcmlt ZV9hdHRhY2gpCj4gLQkJcmV0dXJuOwo+IC0KPiAtCXNndCA9IHByaW1lX2F0dGFjaC0+c2d0Owo+ IC0JaWYgKHNndCkgewo+IC0JCWlmIChwcmltZV9hdHRhY2gtPmRpciAhPSBETUFfTk9ORSkKPiAt CQkJZG1hX3VubWFwX3NnX2F0dHJzKGF0dGFjaC0+ZGV2LCBzZ3QtPnNnbCwKPiBzZ3QtPm5lbnRz LAo+IC0JCQkJCSAgIHByaW1lX2F0dGFjaC0+ZGlyLAo+IC0JCQkJCSAgIERNQV9BVFRSX1NLSVBf Q1BVX1NZTkMpOwo+IC0JCXNnX2ZyZWVfdGFibGUoc2d0KTsKPiArCQlpZiAoc2d0KSB7Cj4gKwkJ CWlmIChwcmltZV9hdHRhY2gtPmRpciAhPSBETUFfTk9ORSkKPiArCQkJCWRtYV91bm1hcF9zZ19h dHRycyhhdHRhY2gtPmRldiwgc2d0LQo+ID5zZ2wsCj4gKwkJCQkJCSAgIHNndC0+bmVudHMsCj4g KwkJCQkJCSAgIHByaW1lX2F0dGFjaC0KPiA+ZGlyLAo+ICsJCQkJCQkgICBETUFfQVRUUl9TS0lQ X0NQVQo+IF9TWU5DKTsKPiArCQkJc2dfZnJlZV90YWJsZShzZ3QpOwo+ICsJCX0KPiArCj4gKwkJ a2ZyZWUoc2d0KTsKPiArCQlrZnJlZShwcmltZV9hdHRhY2gpOwo+ICsJCWF0dGFjaC0+cHJpdiA9 IE5VTEw7Cj4gIAl9Cj4gIAo+IC0Ja2ZyZWUoc2d0KTsKPiAtCWtmcmVlKHByaW1lX2F0dGFjaCk7 Cj4gLQlhdHRhY2gtPnByaXYgPSBOVUxMOwo+ICsJaWYgKGRldi0+ZHJpdmVyLT5nZW1fcHJpbWVf dW5waW4pCj4gKwkJZGV2LT5kcml2ZXItPmdlbV9wcmltZV91bnBpbihvYmopOwo+ICB9Cj4gIEVY UE9SVF9TWU1CT0woZHJtX2dlbV9tYXBfZGV0YWNoKTsKPiAgCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRl dmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=