From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Linux PCI <linux-pci@vger.kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
the arch/x86 maintainers <x86@kernel.org>,
Jean Delvare <jdelvare@suse.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 1/4] dmi: Introduce dmi_get_bios_year() helper
Date: Wed, 28 Feb 2018 12:14:04 +0200 [thread overview]
Message-ID: <1519812844.10722.253.camel@linux.intel.com> (raw)
In-Reply-To: <CAJZ5v0hK3fvgL42qowQFBbcG5JABec42R781vBbia0Z2MQy31w@mail.gmail.com>
On Mon, 2018-02-26 at 10:29 +0100, Rafael J. Wysocki wrote:
> On Sun, Feb 25, 2018 at 2:23 PM, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Fri, 2018-02-23 at 15:35 -0600, Bjorn Helgaas wrote:
> > > but making this inline looks similar to this, which
> > > wasn't well-received:
> > >
> > > https://lkml.kernel.org/r/CA+55aFypU331cQy-
> > > 6ZJ6szF=2KVLqcbwCUGd+gTwPViRqRWN+g@mail.gmail.com
> >
> > "Yes, that header file is already full of random inline functions,
> > but
> > they are generally wrapper functions that don't really do anything,
> > ..."
> >
> > I think the function above is exactly from the "wrapper that doesn't
> > really do anything" category.
>
> Yes, but honestly does it need to be inline even so?
>
> Why don't you simply put the wrapper into dmi_scan.c and export it?
Taking into consideration that there are few comments to be addressed
and series had been applied, I will send a fix up series where I move
this to be a normal function.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2018-02-28 10:14 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-22 12:59 [PATCH v1 1/4] dmi: Introduce dmi_get_bios_year() helper Andy Shevchenko
2018-02-22 12:59 ` [PATCH v1 2/4] x86/pci: Re-use new " Andy Shevchenko
2018-02-23 8:25 ` [tip:x86/platform] x86/pci: Simplify code by using the " tip-bot for Andy Shevchenko
2018-02-23 21:39 ` [PATCH v1 2/4] x86/pci: Re-use " Bjorn Helgaas
2018-02-26 16:28 ` Jean Delvare
2018-02-28 10:29 ` Andy Shevchenko
2018-02-28 10:33 ` Rafael J. Wysocki
2018-02-28 19:21 ` Jean Delvare
2018-02-28 19:34 ` Andy Shevchenko
2018-02-22 12:59 ` [PATCH v1 3/4] ACPI / sleep: " Andy Shevchenko
2018-02-23 8:25 ` [tip:x86/platform] ACPI/sleep: Simplify code by using the " tip-bot for Andy Shevchenko
2018-02-26 16:31 ` [PATCH v1 3/4] ACPI / sleep: Re-use " Jean Delvare
2018-02-22 12:59 ` [PATCH v1 4/4] pci: " Andy Shevchenko
2018-02-23 8:26 ` [tip:x86/platform] pci: Simplify code by using the " tip-bot for Andy Shevchenko
2018-02-23 21:40 ` [PATCH v1 4/4] pci: Re-use " Bjorn Helgaas
2018-02-25 13:27 ` Andy Shevchenko
2018-02-26 18:19 ` Bjorn Helgaas
2018-02-28 10:12 ` Andy Shevchenko
2018-02-28 15:17 ` Bjorn Helgaas
2018-02-26 20:40 ` Jean Delvare
2018-02-23 8:24 ` [tip:x86/platform] dmi: Introduce the dmi_get_bios_year() helper function tip-bot for Andy Shevchenko
2018-02-23 21:35 ` [PATCH v1 1/4] dmi: Introduce dmi_get_bios_year() helper Bjorn Helgaas
2018-02-25 13:23 ` Andy Shevchenko
2018-02-26 9:29 ` Rafael J. Wysocki
2018-02-28 10:14 ` Andy Shevchenko [this message]
2018-02-27 9:14 ` Jean Delvare
2018-02-28 10:33 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1519812844.10722.253.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=hpa@zytor.com \
--cc=jdelvare@suse.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.