On Wed, 2018-02-28 at 16:33 +0000, Andrew Cooper wrote: > On 28/02/18 16:22, George Dunlap wrote: > > > > I kind of feel like there was a reason for the init / alloc > > difference; > > but as you say, at the moment all the schedulers are basically > > identical. In the unlikely event that we need separate callbacks, > > we > > can introduce them at such time as we have a need for them. > > > > Reviewed-by: George Dunlap > > It looks like it was the cpupool work (c/s 78be3dbb, 2010) which > split > alloc/free domdata() out of init/destroy domain() and made the latter > effectively redundant. > Yes. As far as I can see/tell (I wasn't here), that commit introduced alloc_domdata because there was the need to allocate the per-scheduler domain data, without immediately assigning it to sched_priv. I guess something like this that Andrew is doing could have been done at that point. It just was not. :-) Regards, Dario -- <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Software Engineer @ SUSE https://www.suse.com/