From: Krzysztof Kozlowski <krzk@kernel.org>
To: Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
Krzysztof Kozlowski <krzk@kernel.org>,
Vladimir Zapolskiy <vz@mleia.com>,
Kamil Konieczny <k.konieczny@partner.samsung.com>,
Tero Kristo <t-kristo@ti.com>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-samsung-soc@vger.kernel.org
Subject: [PATCH 2/4] crypto: omap-sham - Fix misleading indentation
Date: Thu, 1 Mar 2018 21:50:11 +0100 [thread overview]
Message-ID: <1519937413-24468-2-git-send-email-krzk@kernel.org> (raw)
In-Reply-To: <1519937413-24468-1-git-send-email-krzk@kernel.org>
Commit 8043bb1ae03c ("crypto: omap-sham - convert driver logic to use
sgs for data xmit") removed the if() clause leaving the statement as is.
The intention was in that case to finish the request always so the goto
instruction seems sensible.
Remove the indentation to fix Smatch warning:
drivers/crypto/omap-sham.c:1761 omap_sham_done_task() warn: inconsistent indenting
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/crypto/omap-sham.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/omap-sham.c b/drivers/crypto/omap-sham.c
index 7650b1b449bb..6cb6ab6f52c0 100644
--- a/drivers/crypto/omap-sham.c
+++ b/drivers/crypto/omap-sham.c
@@ -1758,7 +1758,7 @@ static void omap_sham_done_task(unsigned long data)
if (test_and_clear_bit(FLAGS_OUTPUT_READY, &dd->flags)) {
/* hash or semi-hash ready */
clear_bit(FLAGS_DMA_READY, &dd->flags);
- goto finish;
+ goto finish;
}
}
--
2.7.4
next prev parent reply other threads:[~2018-03-01 20:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-01 20:50 [PATCH 1/4] crypto: omap-sham: Remove useless check for non-null request Krzysztof Kozlowski
2018-03-01 20:50 ` Krzysztof Kozlowski [this message]
2018-03-05 8:59 ` [PATCH 2/4] crypto: omap-sham - Fix misleading indentation Tero Kristo
2018-03-05 8:59 ` Tero Kristo
2018-03-01 20:50 ` [PATCH 3/4] crypto: s5p-sss: Remove useless check for non-null request Krzysztof Kozlowski
2018-03-01 20:50 ` [PATCH 4/4] crypto: s5p-sss - Constify pointed data (arguments and local variables) Krzysztof Kozlowski
2018-03-05 8:58 ` [PATCH 1/4] crypto: omap-sham: Remove useless check for non-null request Tero Kristo
2018-03-05 8:58 ` Tero Kristo
2018-03-09 15:19 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1519937413-24468-2-git-send-email-krzk@kernel.org \
--to=krzk@kernel.org \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=k.konieczny@partner.samsung.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=t-kristo@ti.com \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.