All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>
To: Ananth N Mavinakayanahalli <ananth@linux.vnet.ibm.com>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Michael Ellerman <mpe@ellerman.id.au>
Cc: Ingo Molnar <mingo@redhat.com>,
	Namhyung Kim <namhyung@kernel.org>,
	linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: [PATCH 2/2] perf: powerpc: choose LEP with kretprobes
Date: Thu, 16 Feb 2017 13:47:39 +0530	[thread overview]
Message-ID: <151bc1f382d804c8f776caa891b34ffa029b98d9.1487232416.git.naveen.n.rao@linux.vnet.ibm.com> (raw)
In-Reply-To: <cover.1487232416.git.naveen.n.rao@linux.vnet.ibm.com>
In-Reply-To: <cover.1487232416.git.naveen.n.rao@linux.vnet.ibm.com>

perf now uses an offset from _text/_stext for kretprobes, rather than
the actual function name. As such, let's choose the LEP for powerpc
ABIv2 so as to ensure the probe gets hit.

Signed-off-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
---
 tools/perf/arch/powerpc/util/sym-handling.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/tools/perf/arch/powerpc/util/sym-handling.c b/tools/perf/arch/powerpc/util/sym-handling.c
index 1030a6e504bb..9fe0f20aa56f 100644
--- a/tools/perf/arch/powerpc/util/sym-handling.c
+++ b/tools/perf/arch/powerpc/util/sym-handling.c
@@ -79,11 +79,8 @@ void arch__fix_tev_from_maps(struct perf_probe_event *pev,
 	 * However, if the user specifies an offset, we fall back to using the
 	 * GEP since all userspace applications (objdump/readelf) show function
 	 * disassembly with offsets from the GEP.
-	 *
-	 * In addition, we shouldn't specify an offset for kretprobes.
 	 */
-	if (pev->point.offset || (!pev->uprobes && pev->point.retprobe) ||
-	    !map || !sym)
+	if (pev->point.offset || !map || !sym)
 		return;
 
 	lep_offset = PPC64_LOCAL_ENTRY_OFFSET(sym->arch_sym);
-- 
2.11.0

  parent reply	other threads:[~2017-02-16  8:19 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-14  8:31 [PATCH] kretprobes: reject registration if a symbol offset is specified Naveen N. Rao
2017-02-14  8:41 ` Ananth N Mavinakayanahalli
2017-02-14 10:32 ` Masami Hiramatsu
2017-02-15 17:53   ` Naveen N. Rao
2017-02-15 18:17     ` [PATCH 1/3] kretprobes: ensure probe location is at function entry Naveen N. Rao
2017-02-15 18:17       ` [PATCH 2/3] trace/kprobes: allow return probes with offsets and absolute addresses Naveen N. Rao
2017-02-15 23:43         ` Masami Hiramatsu
2017-02-15 18:17       ` [PATCH 3/3] perf: revert "perf probe: Fix probing kretprobes" Naveen N. Rao
2017-02-15 23:43         ` Masami Hiramatsu
2017-02-15 23:39       ` [PATCH 1/3] kretprobes: ensure probe location is at function entry Masami Hiramatsu
2017-02-16  7:51         ` Naveen N. Rao
2017-02-16  8:17       ` [PATCH 0/2] powerpc: kretprobe updates Naveen N. Rao
2017-02-16  8:17         ` [PATCH 1/2] powerpc: kretprobes: override default function entry offset Naveen N. Rao
2017-02-16  8:17         ` Naveen N. Rao [this message]
2017-02-17 10:44         ` [PATCH 0/2] powerpc: kretprobe updates Masami Hiramatsu
2017-02-17 20:42           ` Arnaldo Carvalho de Melo
2017-02-17 20:50             ` PowerMac G5 Quad Strage lspci luigi burdo
2017-02-19  4:42             ` [PATCH 0/2] powerpc: kretprobe updates Masami Hiramatsu
2017-02-20  9:50               ` Naveen N. Rao
2017-02-21 13:07                 ` Masami Hiramatsu
2017-02-22 13:39                   ` Naveen N. Rao
2017-02-20  9:46             ` Naveen N. Rao
2017-02-20 11:43             ` Naveen N. Rao
2017-02-21 13:06               ` Masami Hiramatsu
2017-02-15 23:28     ` [PATCH] kretprobes: reject registration if a symbol offset is specified Masami Hiramatsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=151bc1f382d804c8f776caa891b34ffa029b98d9.1487232416.git.naveen.n.rao@linux.vnet.ibm.com \
    --to=naveen.n.rao@linux.vnet.ibm.com \
    --cc=acme@kernel.org \
    --cc=ananth@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mhiramat@kernel.org \
    --cc=mingo@redhat.com \
    --cc=mpe@ellerman.id.au \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.