All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] slub: use jitter-free reference while printing age
@ 2018-03-08  6:53 Chintan Pandya
  2018-03-08 18:12 ` Christopher Lameter
  0 siblings, 1 reply; 3+ messages in thread
From: Chintan Pandya @ 2018-03-08  6:53 UTC (permalink / raw)
  To: cl, penberg, rientjes, iamjoonsoo.kim, akpm
  Cc: linux-mm, linux-kernel, Chintan Pandya

When SLUB_DEBUG catches the some issues, it prints
all the required debug info. However, in few cases
where allocation and free of the object has have
happened in a very short time, 'age' might mislead.
See the example below,

[ 6044.137581] =============================================================================
[ 6044.145863] BUG kmalloc-256 (Tainted: G        W  O   ): Poison overwritten
[ 6044.152889] -----------------------------------------------------------------------------
...
[ 6044.170804] INFO: Allocated in binder_transaction+0x4b0/0x2448 age=731 cpu=3 pid=5314
...
[ 6044.216696] INFO: Freed in binder_free_transaction+0x2c/0x58 age=735 cpu=6 pid=2079
...
[ 6044.494293] Object fffffff14956a870: 6b 6b 6b 6b 6b 6b 6b 6b 67 6b 6b 6b 6b 6b 6b a5  kkkkkkkkgkkkk

In this case, object got freed later but 'age'
shows otherwise. This could be because, while
printing this info, we print allocation traces
first and free traces thereafter. In between,
if we get schedule out or jiffies increment,
(jiffies - t->when) could become meaningless.

Use the jitter free reference to calculate age.

Change-Id: I0846565807a4229748649bbecb1ffb743d71fcd8
Signed-off-by: Chintan Pandya <cpandya@codeaurora.org>
---
Changes from V1->V2
 * Use 'age' with common jiffies for both prints
 * Trimmed commit text for clear visibility 

 mm/slub.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/mm/slub.c b/mm/slub.c
index e381728..d92218e 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -598,13 +598,13 @@ static void init_tracking(struct kmem_cache *s, void *object)
 	set_track(s, object, TRACK_ALLOC, 0UL);
 }
 
-static void print_track(const char *s, struct track *t)
+static void print_track(const char *s, struct track *t, unsigned long pr_time)
 {
 	if (!t->addr)
 		return;
 
 	pr_err("INFO: %s in %pS age=%lu cpu=%u pid=%d\n",
-	       s, (void *)t->addr, jiffies - t->when, t->cpu, t->pid);
+	       s, (void *)t->addr, pr_time - t->when, t->cpu, t->pid);
 #ifdef CONFIG_STACKTRACE
 	{
 		int i;
@@ -619,11 +619,12 @@ static void print_track(const char *s, struct track *t)
 
 static void print_tracking(struct kmem_cache *s, void *object)
 {
+	unsigned long pr_time = jiffies;
 	if (!(s->flags & SLAB_STORE_USER))
 		return;
 
-	print_track("Allocated", get_track(s, object, TRACK_ALLOC));
-	print_track("Freed", get_track(s, object, TRACK_FREE));
+	print_track("Allocated", get_track(s, object, TRACK_ALLOC), pr_time);
+	print_track("Freed", get_track(s, object, TRACK_FREE), pr_time);
 }
 
 static void print_page_info(struct page *page)
-- 
Qualcomm India Private Limited, on behalf of Qualcomm Innovation
Center, Inc., is a member of Code Aurora Forum, a Linux Foundation
Collaborative Project

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] slub: use jitter-free reference while printing age
  2018-03-08  6:53 [PATCH v2] slub: use jitter-free reference while printing age Chintan Pandya
@ 2018-03-08 18:12 ` Christopher Lameter
  2018-03-09  5:18   ` Chintan Pandya
  0 siblings, 1 reply; 3+ messages in thread
From: Christopher Lameter @ 2018-03-08 18:12 UTC (permalink / raw)
  To: Chintan Pandya
  Cc: penberg, rientjes, iamjoonsoo.kim, akpm, linux-mm, linux-kernel

On Thu, 8 Mar 2018, Chintan Pandya wrote:

> In this case, object got freed later but 'age'
> shows otherwise. This could be because, while
> printing this info, we print allocation traces
> first and free traces thereafter. In between,
> if we get schedule out or jiffies increment,
> (jiffies - t->when) could become meaningless.

Could you show the new output style too?

Acked-by: Christoph Lameter <cl@linux.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] slub: use jitter-free reference while printing age
  2018-03-08 18:12 ` Christopher Lameter
@ 2018-03-09  5:18   ` Chintan Pandya
  0 siblings, 0 replies; 3+ messages in thread
From: Chintan Pandya @ 2018-03-09  5:18 UTC (permalink / raw)
  To: Christopher Lameter
  Cc: penberg, rientjes, iamjoonsoo.kim, akpm, linux-mm, linux-kernel



On 3/8/2018 11:42 PM, Christopher Lameter wrote:
> On Thu, 8 Mar 2018, Chintan Pandya wrote:
> 
>> In this case, object got freed later but 'age'
>> shows otherwise. This could be because, while
>> printing this info, we print allocation traces
>> first and free traces thereafter. In between,
>> if we get schedule out or jiffies increment,
>> (jiffies - t->when) could become meaningless.
> 
> Could you show the new output style too?

New output will exactly be same. 'age' is still
staying with single jiffies ref in both prints.

> 
> Acked-by: Christoph Lameter <cl@linux.com>
Thanks


Chintan
-- 
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center,
Inc. is a member of the Code Aurora Forum, a Linux Foundation
Collaborative Project

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-03-09  5:18 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-08  6:53 [PATCH v2] slub: use jitter-free reference while printing age Chintan Pandya
2018-03-08 18:12 ` Christopher Lameter
2018-03-09  5:18   ` Chintan Pandya

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.