From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcel Ziswiler Subject: Re: [PATCH v2] ARM: tegra: fix ulpi regression on tegra20 Date: Thu, 8 Mar 2018 14:31:26 +0000 Message-ID: <1520519485.23006.6.camel@toradex.com> References: <20180222143825.1517-1-marcel@ziswiler.com> <20180308141501.GH3529@ulmo> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180308141501.GH3529@ulmo> Content-Language: en-US Content-ID: <5172D0DCC432A84FB5D47AB81AFAED9A@eurprd05.prod.outlook.com> Sender: linux-kernel-owner@vger.kernel.org To: "thierry.reding@gmail.com" Cc: "linux-kernel@vger.kernel.org" , "robh+dt@kernel.org" , "jonathanh@nvidia.com" , "linux@armlinux.org.uk" , "devicetree@vger.kernel.org" , "digetx@gmail.com" , "mark.rutland@arm.com" , "linux-arm-kernel@lists.infradead.org" , "linux-tegra@vger.kernel.org" List-Id: linux-tegra@vger.kernel.org T24gVGh1LCAyMDE4LTAzLTA4IGF0IDE1OjE1ICswMTAwLCBUaGllcnJ5IFJlZGluZyB3cm90ZToN Cj4gT24gVGh1LCBGZWIgMjIsIDIwMTggYXQgMDM6Mzg6MjVQTSArMDEwMCwgTWFyY2VsIFppc3dp bGVyIHdyb3RlOg0KPiA+IEZyb206IE1hcmNlbCBaaXN3aWxlciA8bWFyY2VsLnppc3dpbGVyQHRv cmFkZXguY29tPg0KPiA+IA0KPiA+IFNpbmNlIGNvbW1pdCBmOGY4ZjFkMDQ0OTQgKCJjbGs6IERv bid0IHRvdWNoIGhhcmR3YXJlIHdoZW4NCj4gPiByZXBhcmVudGluZw0KPiA+IGR1cmluZyByZWdp c3RyYXRpb24iKSBVTFBJIGhhcyBiZWVuIGJyb2tlbiBvbiBUZWdyYTIwIGxlYWRpbmcgdG8NCj4g PiB0aGUNCj4gPiBmb2xsb3dpbmcgZXJyb3IgbWVzc2FnZSBkdXJpbmcgYm9vdDoNCj4gPiANCj4g PiBbICAgIDEuOTc0Njk4XSB1bHBpX3BoeV9wb3dlcl9vbjogdWxwaSB3cml0ZSBmYWlsZWQNCj4g PiBbICAgIDEuOTc5Mzg0XSB0ZWdyYS1laGNpIGM1MDA0MDAwLnVzYjogRmFpbGVkIHRvIHBvd2Vy IG9uIHRoZSBwaHkNCj4gPiBbICAgIDEuOTg1NDM0XSB0ZWdyYS1laGNpOiBwcm9iZSBvZiBjNTAw NDAwMC51c2IgZmFpbGVkIHdpdGggZXJyb3INCj4gPiAtMTEwDQo+ID4gDQo+ID4gRGVidWdnaW5n IHRocm91Z2ggdGhlIGNoYW5nZXMgYW5kIGZpbmFsbHkgYWxzbyBjb25zdWx0aW5nIHRoZSBUUk0N Cj4gPiByZXZlYWxlZCB0aGF0IHJhdGhlciB0aGFuIHRoZSBDREVWMiBjbG9jayBvZmYgT1NDIHJl cXVpcmluZyBzdWNoDQo+ID4gcGluDQo+ID4gbXV4aW5nIGFjdHVhbGx5IHRoZSBQTExfUF9PVVQ0 IGNsb2NrIGlzIGluIHVzZS4gSXQgbG9va3MgbGlrZSBzbw0KPiA+IGZhciBpdA0KPiA+IGp1c3Qg d29ya2VkIGJ5IGNoYW5jZSBvZiB0aGF0IG9uZSBoYXZpbmcgYmVlbiBlbmFibGVkIHdoaWNoDQo+ ID4gU3RlcGhlbidzDQo+ID4gY29tbWl0IG5vdyBjaGFuZ2VkIHdoZW4gcmVwYXJlbnRpbmcgc2Ns ayBhd2F5IGZyb20gcGxsX3Bfb3V0NA0KPiA+IGxlYXZpbmcNCj4gPiB0aGF0IG9uZSBkaXNhYmxl ZC4gRml4IHRoaXMgYnkgcHJvcGVybHkgYXNzaWduaW5nIHRoZSBQTExfUF9PVVQ0DQo+ID4gY2xv Y2sNCj4gPiBhcyB0aGUgVUxQSSBQSFkgY2xvY2suDQo+ID4gDQo+ID4gU2lnbmVkLW9mZi1ieTog TWFyY2VsIFppc3dpbGVyIDxtYXJjZWwuemlzd2lsZXJAdG9yYWRleC5jb20+DQo+ID4gDQo+ID4g LS0tDQo+ID4gDQo+ID4gQ2hhbmdlcyBpbiB2MjoNCj4gPiAtIFVwZGF0ZWQgZGV2aWNlIHRyZWUg YmluZGluZyBkb2N1bWVudGF0aW9uIGFzIHdlbGwuDQo+ID4gLSBDQ2luZyBEbWl0cnkgYXMgd2Vs bC4NCj4gPiANCj4gPiAgRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3BoeS9udmlk aWEsdGVncmEyMC11c2ItcGh5LnR4dCB8DQo+ID4gNCArKystDQo+ID4gIGFyY2gvYXJtL2Jvb3Qv ZHRzL3RlZ3JhMjAuZHRzaSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfA0KPiA+ IDIgKy0NCj4gPiAgMiBmaWxlcyBjaGFuZ2VkLCA0IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25z KC0pDQo+IA0KPiBBcHBsaWVkLCB0aG91Z2ggSSd2ZSBzcGxpdCB0aGlzIGludG8gdHdvIHNlcGFy YXRlIHBhdGNoZXMsIG9uZSBnb2luZw0KPiBpbnRvIGZvci00LjE3L2R0LWJpbmRpbmdzIGFuZCB0 aGUgb3RoZXIgZ29pbmcgaW50byBmb3ItNC4xNy9hcm0vZHQuDQoNClRoYW5rcywgVGhpZXJyeSEN Cg0KQlRXOiBEbyB5b3Uga25vdyB3aGF0IGlzIGhhcHBlbmluZyB3aXRoIG15IFQzMCBVU0IgcGF0 Y2g/IElzIHRoZXJlDQphbnl0aGluZyBJIG1heSBkbyBhYm91dCBpdD8NCg0KPiBUaGFua3MsDQo+ IFRoaWVycnk= From mboxrd@z Thu Jan 1 00:00:00 1970 From: marcel.ziswiler@toradex.com (Marcel Ziswiler) Date: Thu, 8 Mar 2018 14:31:26 +0000 Subject: [PATCH v2] ARM: tegra: fix ulpi regression on tegra20 In-Reply-To: <20180308141501.GH3529@ulmo> References: <20180222143825.1517-1-marcel@ziswiler.com> <20180308141501.GH3529@ulmo> Message-ID: <1520519485.23006.6.camel@toradex.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, 2018-03-08 at 15:15 +0100, Thierry Reding wrote: > On Thu, Feb 22, 2018 at 03:38:25PM +0100, Marcel Ziswiler wrote: > > From: Marcel Ziswiler > > > > Since commit f8f8f1d04494 ("clk: Don't touch hardware when > > reparenting > > during registration") ULPI has been broken on Tegra20 leading to > > the > > following error message during boot: > > > > [ 1.974698] ulpi_phy_power_on: ulpi write failed > > [ 1.979384] tegra-ehci c5004000.usb: Failed to power on the phy > > [ 1.985434] tegra-ehci: probe of c5004000.usb failed with error > > -110 > > > > Debugging through the changes and finally also consulting the TRM > > revealed that rather than the CDEV2 clock off OSC requiring such > > pin > > muxing actually the PLL_P_OUT4 clock is in use. It looks like so > > far it > > just worked by chance of that one having been enabled which > > Stephen's > > commit now changed when reparenting sclk away from pll_p_out4 > > leaving > > that one disabled. Fix this by properly assigning the PLL_P_OUT4 > > clock > > as the ULPI PHY clock. > > > > Signed-off-by: Marcel Ziswiler > > > > --- > > > > Changes in v2: > > - Updated device tree binding documentation as well. > > - CCing Dmitry as well. > > > > Documentation/devicetree/bindings/phy/nvidia,tegra20-usb-phy.txt | > > 4 +++- > > arch/arm/boot/dts/tegra20.dtsi | > > 2 +- > > 2 files changed, 4 insertions(+), 2 deletions(-) > > Applied, though I've split this into two separate patches, one going > into for-4.17/dt-bindings and the other going into for-4.17/arm/dt. Thanks, Thierry! BTW: Do you know what is happening with my T30 USB patch? Is there anything I may do about it? > Thanks, > Thierry