All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Schake <stschake@gmail.com>
To: eric@anholt.net
Cc: airlied@linux.ie, linux-rpi-kernel@lists.infradead.org,
	dri-devel@lists.freedesktop.org,
	Stefan Schake <stschake@gmail.com>
Subject: [PATCH v2 0/4] drm/vc4: Improve alpha format plane support
Date: Fri,  9 Mar 2018 01:53:33 +0100	[thread overview]
Message-ID: <1520556817-97297-1-git-send-email-stschake@gmail.com> (raw)

This series improves the handling of alpha formats with the VC4 HVS
compositor. Alpha formats are marked as premultiplied as is standard
for DRM. Further fix a display corruption issue when planes with
per-pixel alpha try blending from the (nonexistent) background by
selectively enabling a black background color fill.

This series follows the changes suggested by Eric Anholt in a previous
patch discussion:

https://patchwork.freedesktop.org/patch/207667/

A simple test program for the display corruption issue is available:

https://github.com/stschake/vc4-alpha-test

v2 of the series fixes the has_alpha confusion and moves needs_bg_fill
into the plane state. This unfortunately necessitated moving the plane
state to a header where it can be referenced from vc4_crtc.

Stefan Schake (4):
  drm/vc4: Set premultiplied for alpha formats
  drm/vc4: Check if plane requires background fill
  drm/vc4: Move plane state to header
  drm/vc4: Enable background color fill when necessary

 drivers/gpu/drm/vc4/vc4_crtc.c  | 25 +++++++++++++++
 drivers/gpu/drm/vc4/vc4_drv.h   | 60 ++++++++++++++++++++++++++++++++++++
 drivers/gpu/drm/vc4/vc4_plane.c | 68 ++++++++---------------------------------
 drivers/gpu/drm/vc4/vc4_regs.h  |  1 +
 4 files changed, 99 insertions(+), 55 deletions(-)

-- 
2.7.4

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

             reply	other threads:[~2018-03-09  0:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-09  0:53 Stefan Schake [this message]
2018-03-09  0:53 ` [PATCH v2 1/4] drm/vc4: Set premultiplied for alpha formats Stefan Schake
2018-03-09  0:53 ` [PATCH v2 2/4] drm/vc4: Check if plane requires background fill Stefan Schake
2018-03-09  0:53 ` [PATCH v2 3/4] drm/vc4: Move plane state to header Stefan Schake
2018-03-09  0:53 ` [PATCH v2 4/4] drm/vc4: Enable background color fill when necessary Stefan Schake
2018-03-09 20:51 ` [PATCH v2 0/4] drm/vc4: Improve alpha format plane support Eric Anholt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1520556817-97297-1-git-send-email-stschake@gmail.com \
    --to=stschake@gmail.com \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=eric@anholt.net \
    --cc=linux-rpi-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.