From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46290) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ewSsZ-0005dJ-LL for qemu-devel@nongnu.org; Thu, 15 Mar 2018 09:25:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ewSsU-0003Fz-OU for qemu-devel@nongnu.org; Thu, 15 Mar 2018 09:25:11 -0400 Received: from [112.64.68.174] (port=38627 helo=robinhe-hp.sh.intel.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ewSsT-0003AR-V1 for qemu-devel@nongnu.org; Thu, 15 Mar 2018 09:25:06 -0400 From: junyan.he@intel.com Date: Tue, 13 Mar 2018 16:33:44 +0800 Message-Id: <1520930033-18885-2-git-send-email-junyan.he@intel.com> In-Reply-To: <1520930033-18885-1-git-send-email-junyan.he@intel.com> References: <1520930033-18885-1-git-send-email-junyan.he@intel.com> Subject: [Qemu-devel] [PATCH 01/10] RFC: Add save and support snapshot dependency function to block driver. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, mreitz@redhat.com, pbonzini@redhat.com, crosthwaite.peter@gmail.com, quintela@redhat.com, rth@twiddle.net, dgilbert@redhat.com, famz@redhat.com, Junyan He From: Junyan He We want to support incremental snapshot saving, this needs the file system support dependency saving. Later snapshots may ref the dependent snapshot's content, and most time should be cluster aligned. Add a query function to check whether the file system support this, and use the save_dependency function to do the real work. Signed-off-by: Junyan He --- include/block/block_int.h | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/include/block/block_int.h b/include/block/block_int.h index 64a5700..be1eca3 100644 --- a/include/block/block_int.h +++ b/include/block/block_int.h @@ -274,6 +274,15 @@ struct BlockDriver { const char *snapshot_id, const char *name, Error **errp); + int (*bdrv_snapshot_save_dependency)(BlockDriverState *bs, + const char *depend_snapshot_id, + int64_t depend_offset, + int64_t depend_size, + int64_t offset, + Error **errp); + int (*bdrv_snapshot_support_dependency)(BlockDriverState *bs, + int32_t *alignment); + int (*bdrv_get_info)(BlockDriverState *bs, BlockDriverInfo *bdi); ImageInfoSpecific *(*bdrv_get_specific_info)(BlockDriverState *bs); -- 2.7.4