All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: <linux-i2c@vger.kernel.org>, <linux-renesas-soc@vger.kernel.org>,
	Eugeniu Rosca <erosca@de.adit-jv.com>
Subject: [PATCH] i2c: rcar: initialize earlier using subsys_initcall()
Date: Fri, 16 Mar 2018 12:58:52 +0200	[thread overview]
Message-ID: <1521197932-2073-1-git-send-email-vladimir_zapolskiy@mentor.com> (raw)

From: Eugeniu Rosca <erosca@de.adit-jv.com>

The purpose of this patch looks pretty similar to:
104522806a7d ("i2c: designware: dw_i2c_init_driver as subsys initcall")
74f56c4ad4e4 ("i2c-bfin-twi: move setup to the earlier subsys initcall")
b8680784875b ("i2c-gpio: Move initialization code to subsys_initcall()")
5d3f33318a6c ("[PATCH] i2c-imx: make bus available early")
ccb3bc16b489 ("i2c-sh_mobile: change module_init() to subsys_initcall()")
18dc83a6ea48 ("i2c: i2c-s3c2410: Initialise Samsung I2C controller early")
2514cca06be9 ("[ARM] 5394/1: Add static bus numbering support to i2c-versatile")
47a9b1379a5e ("i2c-pxa: Initialize early")

However, the story behind it might be a bit different.
Experimenting with async probing in various rcar-specific drivers (e.g.
rcar-du, vsp1, rcar-fcp, rcar-vin), it was noticed that in most of
the cases enabling async probing in one driver introduced some degree of
inconsistency in the initialization of other builtin drivers.

To give an example, with pure sequential driver initialization, based
on 5 dmesg logs, the builtin kernel initialization deviation is
around +/- 5ms, whereas after enabling async probing in e.g. vsp1
driver, the variance is increased to sometimes +/- 80ms or more.

This patch fixes it and keeps the startup time consistent after
switching certain i2c-dependent drivers to asynchronous probing on
H3-es20-Salvator-X target.

Another effect seems to be improving the init time of rcar_i2c_driver
itself from ~7ms to ~1ms (assuming CONFIG_I2C_RCAR=y).

Signed-off-by: Eugeniu Rosca <erosca@de.adit-jv.com>
Signed-off-by: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
---
 drivers/i2c/busses/i2c-rcar.c | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/drivers/i2c/busses/i2c-rcar.c b/drivers/i2c/busses/i2c-rcar.c
index 4159ebcec2bb..502f62052b49 100644
--- a/drivers/i2c/busses/i2c-rcar.c
+++ b/drivers/i2c/busses/i2c-rcar.c
@@ -972,7 +972,18 @@ static struct platform_driver rcar_i2c_driver = {
 	.remove		= rcar_i2c_remove,
 };
 
-module_platform_driver(rcar_i2c_driver);
+static int __init rcar_i2c_driver_init(void)
+{
+	return platform_driver_register(&rcar_i2c_driver);
+}
+
+static void __exit rcar_i2c_driver_exit(void)
+{
+	return platform_driver_unregister(&rcar_i2c_driver);
+}
+
+subsys_initcall(rcar_i2c_driver_init);
+module_exit(rcar_i2c_driver_exit);
 
 MODULE_LICENSE("GPL v2");
 MODULE_DESCRIPTION("Renesas R-Car I2C bus driver");
-- 
2.8.1

             reply	other threads:[~2018-03-16 10:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-16 10:58 Vladimir Zapolskiy [this message]
2018-03-28 14:40 ` [PATCH] i2c: rcar: initialize earlier using subsys_initcall() Eugeniu Rosca
2018-04-03 15:55 ` Wolfram Sang
2018-04-03 16:40   ` Vladimir Zapolskiy
2018-04-03 17:08     ` Wolfram Sang
2018-04-04 21:20       ` Eugeniu Rosca
2018-04-04 21:27       ` Eugeniu Rosca
2018-04-08  7:47         ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1521197932-2073-1-git-send-email-vladimir_zapolskiy@mentor.com \
    --to=vladimir_zapolskiy@mentor.com \
    --cc=erosca@de.adit-jv.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.