From: Wolfgang Grandegger <wg@grandegger.com>
To: Akshay Bhat <nodeax@gmail.com>
Cc: Akshay Bhat <akshay.bhat@timesys.com>,
mkl@pengutronix.de, linux-can@vger.kernel.org,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver
Date: Wed, 15 Mar 2017 08:19:29 +0100 [thread overview]
Message-ID: <15211aa1-7396-391d-de15-b10ff3a3382d@grandegger.com> (raw)
In-Reply-To: <CANiP4c8WMeT1Cr7WDXew1ne7DFR04oaA8Uch0zvyyOf5yCa37A@mail.gmail.com>
Hello Akshay,
Am 15.03.2017 um 05:44 schrieb Akshay Bhat:
> Hi Wolfgang,
>
> On Tue, Mar 14, 2017 at 2:08 PM, Wolfgang Grandegger <wg@grandegger.com> wrote:
> ...snip....
>>> /////disconnect cable
>>> can0 20000088 [8] 00 00 00 19 00 00 28 00 ERRORFRAME
>>> protocol-violation{{}{acknowledge-slot}}
>>> bus-error
>>> error-counter-tx-rx{{40}{0}}
>>> can0 20000088 [8] 00 00 00 19 00 00 58 00 ERRORFRAME
>>> protocol-violation{{}{acknowledge-slot}}
>>> bus-error
>>> error-counter-tx-rx{{88}{0}}
>>> can0 20000088 [8] 00 00 00 19 00 00 80 00 ERRORFRAME
>>> protocol-violation{{}{acknowledge-slot}}
>>> bus-error
>>> error-counter-tx-rx{{128}{0}}
>>
>>
>> TX error warning is missing.
>>
>
> This support was missing in the driver, added in V4 patch.
>
>>> can0 2000008C [8] 00 20 00 19 00 00 80 00 ERRORFRAME
>>> controller-problem{tx-error-passive}
>>> protocol-violation{{}{acknowledge-slot}}
>>> bus-error
>>> error-counter-tx-rx{{128}{0}}
>>
>>
>> Here "tx-error-passiv" is packed with a bus error. What I'm looking for are
>> state change messages similar to:
>>
>> can0 20000204 [8] 00 08 00 00 00 00 60 00 ERRORFRAME
>> controller-problem{tx-error-warning}
>> state-change{tx-error-warning}
>> error-counter-tx-rx{{96}{0}}
>> can0 20000204 [8] 00 30 00 00 00 00 80 00 ERRORFRAME
>> controller-problem{tx-error-passive}
>> state-change{tx-error-passive}
>> error-counter-tx-rx{{128}{0}
>>
>> They should always come, even with "berr-reporting off".
>>
>
> HI-3110 has only 1 bus error interrupt. There is no dedicated state
> change interrupts like other controllers.
To double check: Could you please read INTF, ERR and STATF at the
beginning of the ISR and print it out (using dev_dbg and fiends). Then
run a test with no cable connected and bus error reporting off.
Wolfgang.
next prev parent reply other threads:[~2017-03-15 7:19 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-17 19:22 [PATCH v2 1/2] can: holt_hi311x: document device tree bindings Akshay Bhat
2017-01-17 19:22 ` [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver Akshay Bhat
2017-03-07 15:31 ` Akshay Bhat
2017-03-09 9:59 ` Wolfgang Grandegger
[not found] ` <6df4a9ae-eaba-6f3f-9c23-ae269548b005-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2017-03-09 12:34 ` Akshay Bhat
2017-03-09 12:34 ` Akshay Bhat
2017-03-09 14:45 ` Wolfgang Grandegger
2017-03-09 15:28 ` Akshay Bhat
2017-03-09 17:36 ` Wolfgang Grandegger
[not found] ` <234d9e75-0083-b8b4-c781-add653fdb550-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2017-03-13 15:38 ` Akshay Bhat
2017-03-13 15:38 ` Akshay Bhat
[not found] ` <b3ebb569-b50c-39ad-dec5-0059fbfba8fb-jEh4hwF5bVhBDgjK7y7TUQ@public.gmane.org>
2017-03-14 12:11 ` Wolfgang Grandegger
2017-03-14 12:11 ` Wolfgang Grandegger
2017-03-14 16:20 ` Akshay Bhat
2017-03-14 18:08 ` Wolfgang Grandegger
2017-03-14 21:23 ` Wolfgang Grandegger
[not found] ` <41439729-42d0-d883-2801-2d3607f2aeab-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2017-03-15 4:44 ` Akshay Bhat
2017-03-15 4:44 ` Akshay Bhat
2017-03-15 7:19 ` Wolfgang Grandegger [this message]
2017-03-15 9:42 ` Wolfgang Grandegger
[not found] ` <3dba0948-ffcb-8e80-fb32-62bb0aca6627-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2017-03-16 17:06 ` Akshay Bhat
2017-03-16 17:06 ` Akshay Bhat
2017-03-16 20:02 ` Wolfgang Grandegger
2017-03-16 22:29 ` Akshay Bhat
2017-03-17 7:39 ` Wolfgang Grandegger
2017-03-17 8:17 ` Wolfgang Grandegger
2017-03-17 16:00 ` Akshay Bhat
2017-03-17 17:04 ` Wolfgang Grandegger
[not found] ` <7730cff6-6e85-c98d-0315-bd3888d3aeb1-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2017-03-17 18:28 ` Akshay Bhat
2017-03-17 18:28 ` Akshay Bhat
[not found] ` <ff5d44d1-3bfe-8dae-2aaa-561ab0cb989c-jEh4hwF5bVhBDgjK7y7TUQ@public.gmane.org>
2017-03-18 12:30 ` Wolfgang Grandegger
2017-03-18 12:30 ` Wolfgang Grandegger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15211aa1-7396-391d-de15-b10ff3a3382d@grandegger.com \
--to=wg@grandegger.com \
--cc=akshay.bhat@timesys.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=nodeax@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.