All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Antonio Cardace <anto.cardace@gmail.com>,
	boris.brezillon@free-electrons.com, cyrille.pitchen@wedev4u.fr
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH] mtd: st_spi_fsm: use %*ph to print small buffer
Date: Fri, 16 Mar 2018 16:20:46 +0200	[thread overview]
Message-ID: <1521210046.23017.16.camel@linux.intel.com> (raw)
In-Reply-To: <20180212184130.10238-1-anto.cardace@gmail.com>

On Mon, 2018-02-12 at 18:41 +0000, Antonio Cardace wrote:
> Use %*ph format to print small buffer as hex string.
> 

Any comments so far?

> Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Antonio Cardace <anto.cardace@gmail.com>
> ---
>  drivers/mtd/devices/st_spi_fsm.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/mtd/devices/st_spi_fsm.c
> b/drivers/mtd/devices/st_spi_fsm.c
> index 7bc29d725200..a33f5fd6818c 100644
> --- a/drivers/mtd/devices/st_spi_fsm.c
> +++ b/drivers/mtd/devices/st_spi_fsm.c
> @@ -1868,8 +1868,7 @@ static struct flash_info
> *stfsm_jedec_probe(struct stfsm *fsm)
>  	 */
>  	ext_jedec = id[3] << 8  | id[4];
>  
> -	dev_dbg(fsm->dev, "JEDEC =  0x%08x [%02x %02x %02x %02x
> %02x]\n",
> -		jedec, id[0], id[1], id[2], id[3], id[4]);
> +	dev_dbg(fsm->dev, "JEDEC =  0x%08x [%5ph]\n", jedec, id);
>  
>  	for (info = flash_types; info->name; info++) {
>  		if (info->jedec_id == jedec) {

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

  reply	other threads:[~2018-03-16 14:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-12 18:41 [PATCH] mtd: st_spi_fsm: use %*ph to print small buffer Antonio Cardace
2018-03-16 14:20 ` Andy Shevchenko [this message]
2018-03-18 21:21 ` Boris Brezillon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1521210046.23017.16.camel@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=anto.cardace@gmail.com \
    --cc=boris.brezillon@free-electrons.com \
    --cc=cyrille.pitchen@wedev4u.fr \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.