From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: alsa-devel@alsa-project.org, xen-devel@lists.xenproject.org,
konrad.wilk@oracle.com, tiwai@suse.de
Cc: andr2000@gmail.com,
Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: [PATCH v3 3/5] sndif: Make requests and responses 64 octets long
Date: Mon, 19 Mar 2018 09:22:22 +0200 [thread overview]
Message-ID: <1521444144-12451-4-git-send-email-andr2000__15910.6483719826$1521444108$gmane$org@gmail.com> (raw)
In-Reply-To: <1521444144-12451-1-git-send-email-andr2000@gmail.com>
From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Extend the size of the requests and responses to 64 octets.
Bump protocol version to 2.
Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
---
xen/include/public/io/sndif.h | 22 +++++++++++-----------
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/xen/include/public/io/sndif.h b/xen/include/public/io/sndif.h
index 916be1d3a13f..ec47ff990f2c 100644
--- a/xen/include/public/io/sndif.h
+++ b/xen/include/public/io/sndif.h
@@ -41,7 +41,7 @@
* Protocol version
******************************************************************************
*/
-#define XENSND_PROTOCOL_VERSION 1
+#define XENSND_PROTOCOL_VERSION 2
/*
******************************************************************************
@@ -533,7 +533,7 @@
*
*---------------------------------- Requests ---------------------------------
*
- * All request packets have the same length (32 octets)
+ * All request packets have the same length (64 octets)
* All request packets have common header:
* 0 1 2 3 octet
* +----------------+----------------+----------------+----------------+
@@ -570,7 +570,7 @@
* +----------------+----------------+----------------+----------------+
* |/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/|
* +----------------+----------------+----------------+----------------+
- * | reserved | 32
+ * | reserved | 64
* +----------------+----------------+----------------+----------------+
*
* pcm_rate - uint32_t, stream data rate, Hz
@@ -639,7 +639,7 @@ struct xensnd_page_directory {
* +----------------+----------------+----------------+----------------+
* |/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/|
* +----------------+----------------+----------------+----------------+
- * | reserved | 32
+ * | reserved | 64
* +----------------+----------------+----------------+----------------+
*
* Request read/write - used for read (for capture) or write (for playback):
@@ -657,7 +657,7 @@ struct xensnd_page_directory {
* +----------------+----------------+----------------+----------------+
* |/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/|
* +----------------+----------------+----------------+----------------+
- * | reserved | 32
+ * | reserved | 64
* +----------------+----------------+----------------+----------------+
*
* operation - XENSND_OP_READ for read or XENSND_OP_WRITE for write
@@ -684,7 +684,7 @@ struct xensnd_rw_req {
* +----------------+----------------+----------------+----------------+
* |/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/|
* +----------------+----------------+----------------+----------------+
- * | reserved | 32
+ * | reserved | 64
* +----------------+----------------+----------------+----------------+
*
* operation - XENSND_OP_SET_VOLUME for volume set
@@ -726,7 +726,7 @@ struct xensnd_rw_req {
* +----------------+----------------+----------------+----------------+
* |/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/|
* +----------------+----------------+----------------+----------------+
- * | reserved | 32
+ * | reserved | 64
* +----------------+----------------+----------------+----------------+
*
* operation - XENSND_OP_MUTE for mute or XENSND_OP_UNMUTE for unmute
@@ -759,7 +759,7 @@ struct xensnd_rw_req {
/*
*---------------------------------- Responses --------------------------------
*
- * All response packets have the same length (32 octets)
+ * All response packets have the same length (64 octets)
*
* Response for all requests:
* 0 1 2 3 octet
@@ -772,7 +772,7 @@ struct xensnd_rw_req {
* +----------------+----------------+----------------+----------------+
* |/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/|
* +----------------+----------------+----------------+----------------+
- * | reserved | 32
+ * | reserved | 64
* +----------------+----------------+----------------+----------------+
*
* id - uint16_t, copied from the request
@@ -787,7 +787,7 @@ struct xensnd_req {
union {
struct xensnd_open_req open;
struct xensnd_rw_req rw;
- uint8_t reserved[24];
+ uint8_t reserved[56];
} op;
};
@@ -796,7 +796,7 @@ struct xensnd_resp {
uint8_t operation;
uint8_t reserved;
int32_t status;
- uint8_t reserved1[24];
+ uint8_t reserved1[56];
};
DEFINE_RING_TYPES(xen_sndif, struct xensnd_req, struct xensnd_resp);
--
2.7.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-03-19 7:22 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-19 7:22 [Xen-devel][PATCH v3 0/5] sndif: add explicit back and front synchronization Oleksandr Andrushchenko
2018-03-19 7:22 ` [PATCH v3 1/5] sndif: Introduce protocol version Oleksandr Andrushchenko
2018-03-19 7:22 ` [Xen-devel][PATCH " Oleksandr Andrushchenko
2018-03-19 7:22 ` [Xen-devel][PATCH v3 2/5] sndif: Fix missed "reserved" fields in comments Oleksandr Andrushchenko
2018-03-19 7:22 ` [PATCH " Oleksandr Andrushchenko
2018-03-19 7:22 ` [Xen-devel][PATCH v3 3/5] sndif: Make requests and responses 64 octets long Oleksandr Andrushchenko
2018-03-19 7:22 ` Oleksandr Andrushchenko [this message]
2018-03-19 7:22 ` [PATCH v3 4/5] sndif: Add explicit back and front synchronization Oleksandr Andrushchenko
2018-03-19 7:22 ` [Xen-devel][PATCH " Oleksandr Andrushchenko
2018-03-19 7:22 ` [PATCH v3 5/5] sndif: Add explicit back and front parameter negotiation Oleksandr Andrushchenko
2018-03-19 7:22 ` [Xen-devel][PATCH " Oleksandr Andrushchenko
2018-03-20 20:22 ` [PATCH v3 0/5] sndif: add explicit back and front synchronization Takashi Iwai
2018-03-20 20:22 ` [Xen-devel][PATCH " Takashi Iwai
2018-03-21 7:15 ` [PATCH " Oleksandr Andrushchenko
2018-03-21 7:15 ` [Xen-devel][PATCH " Oleksandr Andrushchenko
2018-03-21 7:20 ` [PATCH " Takashi Iwai
2018-03-21 7:20 ` [Xen-devel][PATCH " Takashi Iwai
2018-03-21 7:25 ` [PATCH " Oleksandr Andrushchenko
2018-03-21 7:25 ` [Xen-devel][PATCH " Oleksandr Andrushchenko
2018-03-27 5:41 ` Oleksandr Andrushchenko
2018-04-03 5:37 ` Oleksandr Andrushchenko
2018-04-10 5:28 ` [PATCH " Oleksandr Andrushchenko
2018-04-10 5:28 ` [Xen-devel][PATCH " Oleksandr Andrushchenko
2018-04-03 5:37 ` [PATCH " Oleksandr Andrushchenko
2018-03-27 5:41 ` Oleksandr Andrushchenko
2018-04-12 14:31 ` Konrad Rzeszutek Wilk
2018-04-12 14:31 ` [Xen-devel][PATCH " Konrad Rzeszutek Wilk
2018-04-12 14:35 ` [PATCH " Oleksandr Andrushchenko
2018-04-12 14:35 ` [Xen-devel][PATCH " Oleksandr Andrushchenko
2018-04-06 9:13 ` [PATCH " Juergen Gross
2018-04-06 9:18 ` [Xen-devel] " Oleksandr Andrushchenko
2018-04-06 9:18 ` Oleksandr Andrushchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='1521444144-12451-4-git-send-email-andr2000__15910.6483719826$1521444108$gmane$org@gmail.com' \
--to=andr2000@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=konrad.wilk@oracle.com \
--cc=oleksandr_andrushchenko@epam.com \
--cc=tiwai@suse.de \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.