All of lore.kernel.org
 help / color / mirror / Atom feed
From: shunki-fujita <shunki-fujita@cybozu.co.jp>
To: akpm@linux-foundation.org
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	viro@zeniv.linux.org.uk, axboe@kernel.dk,
	shunki-fujita@cybozu.co.jp
Subject: [PATCH v2] fs: don't flush pagecache when expanding block device
Date: Mon, 19 Mar 2018 20:00:40 +0900	[thread overview]
Message-ID: <1521457240-153390-1-git-send-email-shunki-fujita@cybozu.co.jp> (raw)
In-Reply-To: <1521183353-144817-1-git-send-email-shunki-fujita@cybozu.co.jp>

When changing the size of a block device, its all caches are freed.
It's necessary on shrinking to prevent spurious I/Os to the disappeared region.
However, on expanding, such kind of I/Os doesn't happen.

Similar things can be considered for btrfs filesystem resize and resize2fs,
but they are designed not to cache drops when expanding.
Therefore this patch removes unnecessary cache drop.

Signed-off-by: Shunki Fujita <shunki-fujita@cybozu.co.jp>
---
Changes in v2:
   - Remove unnecessary changes (Since bdev-> bd_invalidated always 0 after check_disk_size_change ()[1])
   - Add document of check_disk_size_change ()

   [1] https://github.com/torvalds/linux/blob/master/fs/block_dev.c#L1365-L1366

 fs/block_dev.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/fs/block_dev.c b/fs/block_dev.c
index fe09ef9..63f1269 100644
--- a/fs/block_dev.c
+++ b/fs/block_dev.c
@@ -1324,7 +1324,8 @@ static void flush_disk(struct block_device *bdev, bool kill_dirty)
  * @bdev: struct bdev to adjust.
  *
  * This routine checks to see if the bdev size does not match the disk size
- * and adjusts it if it differs.
+ * and adjusts it if it differs. When shrinking the bdev size, its all caches 
+ * are freed.
  */
 void check_disk_size_change(struct gendisk *disk, struct block_device *bdev)
 {
@@ -1337,7 +1338,8 @@ void check_disk_size_change(struct gendisk *disk, struct block_device *bdev)
 		       "%s: detected capacity change from %lld to %lld\n",
 		       disk->disk_name, bdev_size, disk_size);
 		i_size_write(bdev->bd_inode, disk_size);
-		flush_disk(bdev, false);
+		if (bdev_size > disk_size)
+			flush_disk(bdev, false);
 	}
 }
 EXPORT_SYMBOL(check_disk_size_change);
-- 
2.7.4

      parent reply	other threads:[~2018-03-19 11:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-16  6:55 [PATCH] fs: don't flush pagecache when expanding block device shunki-fujita
2018-03-16 22:22 ` Andrew Morton
2018-03-19 10:52 ` Shunki Fujita
2018-03-19 11:00 ` shunki-fujita [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1521457240-153390-1-git-send-email-shunki-fujita@cybozu.co.jp \
    --to=shunki-fujita@cybozu.co.jp \
    --cc=akpm@linux-foundation.org \
    --cc=axboe@kernel.dk \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.