Re: [Qemu-devel] [PATCH] i.MX: Support serial RS-232 break properly

[no-reply@patchew.org]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20180320013657.25038-1-tpiepho@impinj.com
Subject: [Qemu-devel] [PATCH] i.MX: Support serial RS-232 break properly

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/1521468046-10400-1-git-send-email-thuth@redhat.com -> patchew/1521468046-10400-1-git-send-email-thuth@redhat.com
 t [tag update]            patchew/20180319031545.29359-1-richard.henderson@linaro.org -> patchew/20180319031545.29359-1-richard.henderson@linaro.org
 t [tag update]            patchew/20180319110215.16755-1-peter.maydell@linaro.org -> patchew/20180319110215.16755-1-peter.maydell@linaro.org
 t [tag update]            patchew/20180319113544.704-1-laurent@vivier.eu -> patchew/20180319113544.704-1-laurent@vivier.eu
 t [tag update]            patchew/20180319115846.9662-1-kbastian@mail.uni-paderborn.de -> patchew/20180319115846.9662-1-kbastian@mail.uni-paderborn.de
 t [tag update]            patchew/20180319131743.3885-1-peter.maydell@linaro.org -> patchew/20180319131743.3885-1-peter.maydell@linaro.org
 t [tag update]            patchew/20180319213101.6100-1-wsa+renesas@sang-engineering.com -> patchew/20180319213101.6100-1-wsa+renesas@sang-engineering.com
 * [new tag]               patchew/20180320013657.25038-1-tpiepho@impinj.com -> patchew/20180320013657.25038-1-tpiepho@impinj.com
Switched to a new branch 'test'
10224115a7 i.MX: Support serial RS-232 break properly

=== OUTPUT BEGIN ===
Checking PATCH 1/1: i.MX: Support serial RS-232 break properly...
ERROR: spaces required around that '<<' (ctx:VxV)
#53: FILE: include/hw/char/imx_serial.h:29:
+#define URXD_FRMERR     (1<<12)   /* Character has frame error */
                           ^

total: 1 errors, 0 warnings, 24 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org