From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08BD9C433F5 for ; Thu, 7 Oct 2021 21:50:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D6681610A5 for ; Thu, 7 Oct 2021 21:50:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238388AbhJGVwB (ORCPT ); Thu, 7 Oct 2021 17:52:01 -0400 Received: from mail-1.ca.inter.net ([208.85.220.69]:51976 "EHLO mail-1.ca.inter.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234061AbhJGVwB (ORCPT ); Thu, 7 Oct 2021 17:52:01 -0400 Received: from mp-mx11.ca.inter.net (mp-mx11.ca.inter.net [208.85.217.19]) by mail-1.ca.inter.net (Postfix) with ESMTP id 5EB5B2EA1FC; Thu, 7 Oct 2021 17:50:06 -0400 (EDT) Received: from mail-1.ca.inter.net ([208.85.220.69]) by mp-mx11.ca.inter.net (mp-mx11.ca.inter.net [208.85.217.19]) (amavisd-new, port 10024) with ESMTP id E2MlfvHBHwsQ; Thu, 7 Oct 2021 17:50:06 -0400 (EDT) Received: from [192.168.48.23] (host-23-91-187-47.dyn.295.ca [23.91.187.47]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: dgilbert@interlog.com) by mail-1.ca.inter.net (Postfix) with ESMTPSA id EFCC22EA039; Thu, 7 Oct 2021 17:50:05 -0400 (EDT) Reply-To: dgilbert@interlog.com Subject: Re: [PATCH v3 69/88] scsi_debug: Call scsi_done() directly To: Bart Van Assche , "Martin K . Petersen" Cc: linux-scsi@vger.kernel.org, "James E.J. Bottomley" References: <20211007202923.2174984-1-bvanassche@acm.org> <20211007202923.2174984-70-bvanassche@acm.org> From: Douglas Gilbert Message-ID: <1521d98a-acbc-9ab1-fd0d-a7769f20a408@interlog.com> Date: Thu, 7 Oct 2021 17:50:05 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20211007202923.2174984-70-bvanassche@acm.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-CA Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org On 2021-10-07 4:29 p.m., Bart Van Assche wrote: > Conditional statements are faster than indirect calls. Hence call > scsi_done() directly. > > Signed-off-by: Bart Van Assche Acked-by: Douglas Gilbert