* [DPU PATCH 2/3] drm/msm: Fix return type mismatch for dpu_kms_init
@ 2018-03-28 6:18 Rajesh Yadav
2018-04-04 17:13 ` Sean Paul
0 siblings, 1 reply; 2+ messages in thread
From: Rajesh Yadav @ 2018-03-28 6:18 UTC (permalink / raw)
To: dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-arm-msm-u79uwXL29TY76Z2rM5mHXA
Cc: robdclark-Re5JQEeQqe8AvxtiuMwx3w,
seanpaul-F7+t8E8rja9g9hUCZPvPmw, Rajesh Yadav,
hoegsberg-F7+t8E8rja9g9hUCZPvPmw
dpu_kms_init returns pointer to struct msm_kms but
incase of platform_get_irq() failure, int was returned.
Fix the return type to avoid compilation error.
Signed-off-by: Rajesh Yadav <ryadav@codeaurora.org>
---
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
index 8ef75f5..531efa9 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
@@ -2027,7 +2027,7 @@ struct msm_kms *dpu_kms_init(struct drm_device *dev)
irq = platform_get_irq(pdev, 0);
if (irq < 0) {
DPU_ERROR("failed to get irq: %d\n", irq);
- return irq;
+ return ERR_PTR(irq);
}
priv = dev->dev_private;
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
_______________________________________________
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [DPU PATCH 2/3] drm/msm: Fix return type mismatch for dpu_kms_init
2018-03-28 6:18 [DPU PATCH 2/3] drm/msm: Fix return type mismatch for dpu_kms_init Rajesh Yadav
@ 2018-04-04 17:13 ` Sean Paul
0 siblings, 0 replies; 2+ messages in thread
From: Sean Paul @ 2018-04-04 17:13 UTC (permalink / raw)
To: Rajesh Yadav; +Cc: linux-arm-msm, dri-devel, hoegsberg, freedreno
On Wed, Mar 28, 2018 at 11:48:13AM +0530, Rajesh Yadav wrote:
> dpu_kms_init returns pointer to struct msm_kms but
> incase of platform_get_irq() failure, int was returned.
> Fix the return type to avoid compilation error.
>
> Signed-off-by: Rajesh Yadav <ryadav@codeaurora.org>
Reviewed-by: Sean Paul <seanpaul@chromium.org>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
> index 8ef75f5..531efa9 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
> @@ -2027,7 +2027,7 @@ struct msm_kms *dpu_kms_init(struct drm_device *dev)
> irq = platform_get_irq(pdev, 0);
> if (irq < 0) {
> DPU_ERROR("failed to get irq: %d\n", irq);
> - return irq;
> + return ERR_PTR(irq);
> }
>
> priv = dev->dev_private;
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
--
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-04-04 17:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-28 6:18 [DPU PATCH 2/3] drm/msm: Fix return type mismatch for dpu_kms_init Rajesh Yadav
2018-04-04 17:13 ` Sean Paul
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.