From: Chris Wilson <chris@chris-wilson.co.uk>
To: Michel Thierry <michel.thierry@intel.com>,
intel-gfx@lists.freedesktop.org
Cc: Mika@freedesktop.org
Subject: Re: [PATCH 10/15] drm/i915: Avoid sleeping inside per-engine reset
Date: Wed, 28 Mar 2018 22:52:01 +0100 [thread overview]
Message-ID: <152227392121.10679.5794628153336744512@mail.alporthouse.com> (raw)
In-Reply-To: <91ced188-a743-c9dd-9f3e-81a9c684cb2e@intel.com>
Quoting Michel Thierry (2018-03-28 22:47:55)
> On 28/03/18 14:18, Chris Wilson wrote:
> > @@ -2094,7 +2095,7 @@ int intel_gpu_reset(struct drm_i915_private *dev_priv, unsigned engine_mask)
> > int retry;
> > int ret;
> >
> > - might_sleep();
> > + might_sleep_if(engine_mask == ALL_ENGINES);
>
> I think this should also be checking for intel_has_reset_engine.
>
> If i915.reset is not 2, engine_mask can be != ALL_ENGINES and still be a
> full device reset.
Can it?
i915_reset -> intel_gpu_reset(ALL_ENGINES);
i915_reset_engine -> intel_gt_reset_engine -> intel_gpu_reset(BIT(engine->id));
Plus a couple of others poking at intel_gpu_reset(ALL_ENGINES);
Have I missed someone using intel_gpu_reset() directly?
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-03-28 21:52 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-28 21:18 Sleepless per-engine resests Chris Wilson
2018-03-28 21:18 ` [PATCH 01/15] drm/i915/execlists: Refactor out complete_preempt_context() Chris Wilson
2018-03-28 21:18 ` [PATCH 02/15] drm/i915: Move engine reset prepare/finish to backends Chris Wilson
2018-03-28 21:18 ` [PATCH 03/15] drm/i915: Split execlists/guc reset prepartions Chris Wilson
2018-03-28 21:18 ` [PATCH 04/15] drm/i915/execlists: Flush pending preemption events during reset Chris Wilson
2018-03-28 21:18 ` [PATCH 05/15] drm/i915/selftests: Add basic sanitychecks for execlists Chris Wilson
2018-03-28 21:18 ` [PATCH 06/15] drm/i915: Only warn for might_sleep() before a slow wait_for_register Chris Wilson
2018-03-29 9:19 ` Mika Kuoppala
2018-03-28 21:18 ` [PATCH 07/15] drm/i915/breadcrumbs: Keep the fake irq armed across reset Chris Wilson
2018-03-28 21:18 ` [PATCH 08/15] drm/i915: Combine tasklet_kill and tasklet_disable Chris Wilson
2018-03-28 21:18 ` [PATCH 09/15] drm/i915: Stop parking the signaler around reset Chris Wilson
2018-03-28 21:18 ` [PATCH 10/15] drm/i915: Avoid sleeping inside per-engine reset Chris Wilson
2018-03-28 21:47 ` Michel Thierry
2018-03-28 21:52 ` Chris Wilson [this message]
2018-03-28 21:56 ` Michel Thierry
2018-03-28 21:18 ` [PATCH 11/15] drm/i915/execlists: Force preemption via reset on timeout Chris Wilson
2018-03-28 21:26 ` Chris Wilson
2018-03-28 21:18 ` [PATCH 12/15] drm/i915/execlists: Try preempt-reset from softirq context Chris Wilson
2018-03-28 21:18 ` [PATCH 13/15] drm/i915/preemption: Select timeout when scheduling Chris Wilson
2018-03-28 21:18 ` [PATCH 14/15] drm/i915: Use a preemption timeout to enforce interactivity Chris Wilson
2018-03-28 21:18 ` [PATCH 15/15] drm/i915: Allow user control over preempt timeout on the important context Chris Wilson
2018-03-28 22:43 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/15] drm/i915/execlists: Refactor out complete_preempt_context() Patchwork
2018-03-28 23:01 ` ✗ Fi.CI.BAT: failure " Patchwork
2018-03-28 23:38 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=152227392121.10679.5794628153336744512@mail.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=Mika@freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=michel.thierry@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.