From mboxrd@z Thu Jan 1 00:00:00 1970 From: Erwan Velu Subject: Re: About ceph_clock_now() Date: Thu, 21 Jan 2016 14:22:56 -0500 (EST) Message-ID: <1522288191.15295456.1453404176015.JavaMail.zimbra@redhat.com> References: <177186823.10053087.1452614184109.JavaMail.zimbra@redhat.com> <892700092.10054838.1452614393452.JavaMail.zimbra@redhat.com> <20160112173248.GA8218@ultraspiritum.redhat.com> <964746730.10566211.1452681675142.JavaMail.zimbra@redhat.com> <1365711662.13730117.1453220271917.JavaMail.zimbra@redhat.com> <20160119162902.GA21358@ultraspiritum.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mx4-phx2.redhat.com ([209.132.183.25]:48910 "EHLO mx4-phx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752770AbcAUTW4 convert rfc822-to-8bit (ORCPT ); Thu, 21 Jan 2016 14:22:56 -0500 In-Reply-To: <20160119162902.GA21358@ultraspiritum.redhat.com> Sender: ceph-devel-owner@vger.kernel.org List-ID: To: "Adam C. Emerson" Cc: Sage Weil , The Sacred Order of the Squid Cybernetic Hi, I'm sadly not at full time on Ceph but you can find my work in progress= on this PR in my personal branch. I'm thinking of making a single commit explaining this change and propa= gating it to the whole codebase:=20 https://github.com/ErwanAliasr1/ceph/commit/00daa403831c9e0dfffb6f31a48= 723ca3cc3b569 Note this is WIP and I'm currently hiting obvious places where ceph_clo= ck_now() can be replaced. I don't know a lot about the coebase so I'll = ask my questions later about the locations where I have doubts. Cheers, Erwan ----- Mail original ----- De: "Adam C. Emerson" =C3=80: "Erwan Velu" Cc: "Sage Weil" , "The Sacred Order of the Squid Cybe= rnetic" Envoy=C3=A9: Mardi 19 Janvier 2016 17:29:03 Objet: Re: About ceph_clock_now() On 19/01/2016, Erwan Velu wrote: > Before propagating the change to more code base and offer a PR with t= hat, what do you think of this style ? >=20 > Is it aligned with the best-pratices of the project ? >=20 > https://gist.github.com/ErwanAliasr1/f74f7f046e9300ac2c30 One minor thing, you shouldn't use anything in time_detail directly. It= SHOULD be ceph::coarse_mono_clock::now() ('detail' or leading underscores sign= al a 'private' namespace.) Other than that, this looks very good. --=20 Senior Software Engineer Red Hat Storage, Ann Arbor, MI, US IRC: Aemerson@{RedHat, OFTC, Freenode} 0x80F7544B90EDBFB9 E707 86BA 0C1B 62CC 152C 7C12 80F7 544B 90ED BFB9 -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html