From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752000AbdBAJne (ORCPT ); Wed, 1 Feb 2017 04:43:34 -0500 Received: from gloria.sntech.de ([95.129.55.99]:47880 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751890AbdBAJnV (ORCPT ); Wed, 1 Feb 2017 04:43:21 -0500 From: Heiko Stuebner To: Alexander Kochetkov Cc: Daniel Lezcano , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Thomas Gleixner , Mark Rutland , Rob Herring , Russell King , Caesar Wang , Huang Tao Subject: Re: [PATCH v6 4/5] ARM: dts: rockchip: add timer entries to rk3188 SoC Date: Wed, 01 Feb 2017 10:43:12 +0100 Message-ID: <1522448.qizf3bPadS@phil> User-Agent: KMail/5.2.3 (Linux/4.8.0-2-amd64; KDE/5.27.0; x86_64; ; ) In-Reply-To: <1485866596-32254-5-git-send-email-al.kochet@gmail.com> References: <1485866596-32254-1-git-send-email-al.kochet@gmail.com> <1485866596-32254-5-git-send-email-al.kochet@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Dienstag, 31. Januar 2017, 15:43:15 CET schrieb Alexander Kochetkov: > The patch add two timers to all rk3188 based boards. > > The first timer is from alive subsystem and it act as a backup > for the local timers at sleep time. It act the same as other > SoC rockchip timers already present in kernel. > > The second timer is from CPU subsystem and act as replacement > for the arm-global-timer clocksource and sched clock. It run > at stable frequency 24MHz. > > Signed-off-by: Alexander Kochetkov > --- > arch/arm/boot/dts/rk3188.dtsi | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/arch/arm/boot/dts/rk3188.dtsi b/arch/arm/boot/dts/rk3188.dtsi > index 31f81b2..0dc52fe 100644 > --- a/arch/arm/boot/dts/rk3188.dtsi > +++ b/arch/arm/boot/dts/rk3188.dtsi > @@ -106,6 +106,22 @@ > }; > }; > > + timer3: timer@2000e000 { > + compatible = "rockchip,rk3188-timer", "rockchip,rk3288-timer"; > + reg = <0x2000e000 0x20>; > + interrupts = ; > + clocks = <&cru SCLK_TIMER3>, <&cru PCLK_TIMER3>; > + clock-names = "timer", "pclk"; > + }; > + > + timer6: timer@200380a0 { > + compatible = "rockchip,rk3188-timer", "rockchip,rk3288-timer"; > + reg = <0x200380a0 0x20>; > + interrupts = ; > + clocks = <&cru SCLK_TIMER6>, <&cru PCLK_TIMER0>; > + clock-names = "timer", "pclk"; > + }; > + depending on who is picking that up, they can add my Reviewed-by: Heiko Stuebner if needed. I've also double checked the timer clocks - especially the pclks. Timer3 has its own separate pclk, while all other timers are supplied by pclk_timer0. Heiko From mboxrd@z Thu Jan 1 00:00:00 1970 From: heiko@sntech.de (Heiko Stuebner) Date: Wed, 01 Feb 2017 10:43:12 +0100 Subject: [PATCH v6 4/5] ARM: dts: rockchip: add timer entries to rk3188 SoC In-Reply-To: <1485866596-32254-5-git-send-email-al.kochet@gmail.com> References: <1485866596-32254-1-git-send-email-al.kochet@gmail.com> <1485866596-32254-5-git-send-email-al.kochet@gmail.com> Message-ID: <1522448.qizf3bPadS@phil> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Am Dienstag, 31. Januar 2017, 15:43:15 CET schrieb Alexander Kochetkov: > The patch add two timers to all rk3188 based boards. > > The first timer is from alive subsystem and it act as a backup > for the local timers at sleep time. It act the same as other > SoC rockchip timers already present in kernel. > > The second timer is from CPU subsystem and act as replacement > for the arm-global-timer clocksource and sched clock. It run > at stable frequency 24MHz. > > Signed-off-by: Alexander Kochetkov > --- > arch/arm/boot/dts/rk3188.dtsi | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/arch/arm/boot/dts/rk3188.dtsi b/arch/arm/boot/dts/rk3188.dtsi > index 31f81b2..0dc52fe 100644 > --- a/arch/arm/boot/dts/rk3188.dtsi > +++ b/arch/arm/boot/dts/rk3188.dtsi > @@ -106,6 +106,22 @@ > }; > }; > > + timer3: timer at 2000e000 { > + compatible = "rockchip,rk3188-timer", "rockchip,rk3288-timer"; > + reg = <0x2000e000 0x20>; > + interrupts = ; > + clocks = <&cru SCLK_TIMER3>, <&cru PCLK_TIMER3>; > + clock-names = "timer", "pclk"; > + }; > + > + timer6: timer at 200380a0 { > + compatible = "rockchip,rk3188-timer", "rockchip,rk3288-timer"; > + reg = <0x200380a0 0x20>; > + interrupts = ; > + clocks = <&cru SCLK_TIMER6>, <&cru PCLK_TIMER0>; > + clock-names = "timer", "pclk"; > + }; > + depending on who is picking that up, they can add my Reviewed-by: Heiko Stuebner if needed. I've also double checked the timer clocks - especially the pclks. Timer3 has its own separate pclk, while all other timers are supplied by pclk_timer0. Heiko