From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: error in testpmd when CONFIG_RTE_BUILD_SHARED_LIB=y
Date: Thu, 13 Apr 2017 08:53:37 +0200
Message-ID: <15226233.lg7mjYJUEo@xps13>
References: <357262EF-AA7B-4064-963E-FF130E4607E6@atomicrules.com>
 <20170412215520.44c485a2@neon> <f8b70424-7369-c272-1d8f-f90ecb5809f0@nxp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: Olivier MATZ <olivier.matz@6wind.com>, "Richardson,
 Bruce" <bruce.richardson@intel.com>, john miller <john.miller@atomicrules.com>,
 dev@dpdk.org
To: Shreyansh Jain <shreyansh.jain@nxp.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54])
 by dpdk.org (Postfix) with ESMTP id 446B62C27
 for <dev@dpdk.org>; Thu, 13 Apr 2017 08:53:39 +0200 (CEST)
Received: by mail-wm0-f54.google.com with SMTP id u2so39446229wmu.0
 for <dev@dpdk.org>; Wed, 12 Apr 2017 23:53:39 -0700 (PDT)
In-Reply-To: <f8b70424-7369-c272-1d8f-f90ecb5809f0@nxp.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2017-04-13 12:11, Shreyansh Jain:
> On Thursday 13 April 2017 01:25 AM, Olivier MATZ wrote:
> > Hi,
> >
> > On Wed, 12 Apr 2017 14:31:56 +0200
> > Thomas Monjalon <thomas.monjalon@6wind.com> wrote:
> >
> >> 2017-04-12 11:31, Richardson, Bruce:
> >>>
> 
> [...]
> 
> >>
> >> I think the default mempool could be linked.
> >> I don't know how easy it is to transform
> >> 	CONFIG_RTE_MBUF_DEFAULT_MEMPOOL_OPS="ring_mp_mc"
> >> into
> >> 	-lrte_mempool_ring
> >>
> >> Anyone for a patch?
> >
> > This is the default mempool for the mbufs, selected when using the
> > function rte_pktmbuf_pool_create().
> >
> > For non-mbuf mempools, the default is to use the ring handler (see
> > in rte_mempool_create()).
> >
> > So if we want option 2-, it looks that moving this line in rte.app.mk
> > above, outside the if (shared build), would do the job:
> >
> > _LDLIBS-$(CONFIG_RTE_DRIVER_MEMPOOL_RING)   += -lrte_mempool_ring
> >
> > I think both 2- and 3- are acceptable. People using the shared library
> > mode should already provide all the .so in a known location, so that
> > they are loaded by default. This is needed for the PMDs for instance.
> >
> 
> I can send the patch;
> before that, should this fact, that ring is included by default, is to 
> be documented somewhere?

Yes good idea.
Instead of "included", you could say "linked" without the need for -d option.

But actually, the mempool drivers are not documented.
We should totally update this section:
	http://dpdk.org/doc/guides/prog_guide/mempool_lib.html#mempool-handlers
So it should be another patch.