From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751296AbeDDH5O convert rfc822-to-8bit (ORCPT <rfc822;w@1wt.eu>);
        Wed, 4 Apr 2018 03:57:14 -0400
Received: from mail.fireflyinternet.com ([109.228.58.192]:49209 "EHLO
        fireflyinternet.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org
        with ESMTP id S1750908AbeDDH5N (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 4 Apr 2018 03:57:13 -0400
X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 8BIT
To: Xidong Wang <wangxidong_97@163.com>,
        "Jani Nikula" <jani.nikula@linux.intel.com>,
        "Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
        "Rodrigo Vivi" <rodrigo.vivi@intel.com>,
        "David Airlie" <airlied@linux.ie>
From: Chris Wilson <chris@chris-wilson.co.uk>
In-Reply-To: <1522827474-5120-1-git-send-email-wangxidong_97@163.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org, "Xidong Wang" <wangxidong_97@163.com>
References: <1522827474-5120-1-git-send-email-wangxidong_97@163.com>
Message-ID: <152282857443.25182.14236056855796176035@mail.alporthouse.com>
User-Agent: alot/0.3.6
Subject: Re: [PATCH 1/1] drm/i915: Do not use kfree() to free kmem_cache_alloc()
 return value
Date: Wed, 04 Apr 2018 08:56:14 +0100
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Quoting Xidong Wang (2018-04-04 08:37:54)
> In eb_lookup_vmas(), the return value of kmem_cache_alloc() is freed
> with kfree(). I think the expected paired function is kmem_cahce_free().
> 
> Signed-off-by: Xidong Wang <wangxidong_97@163.com>

That is indeed what it should be doing,

Fixes: d1b48c1e7184 ("drm/i915: Replace execbuf vma ht with an idr")
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: <stable@vger.kernel.org> # v4.14+
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris

From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [PATCH 1/1] drm/i915: Do not use kfree() to free
 kmem_cache_alloc() return value
Date: Wed, 04 Apr 2018 08:56:14 +0100
Message-ID: <152282857443.25182.14236056855796176035@mail.alporthouse.com>
References: <1522827474-5120-1-git-send-email-wangxidong_97@163.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
In-Reply-To: <1522827474-5120-1-git-send-email-wangxidong_97@163.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Jani Nikula <jani.nikula@linux.intel.com>, Joonas Lahtinen <joonas.lahtinen@linux.intel.com>, Rodrigo Vivi <rodrigo.vivi@intel.com>, David Airlie <airlied@linux.ie>
Cc: Xidong Wang <wangxidong_97@163.com>, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

UXVvdGluZyBYaWRvbmcgV2FuZyAoMjAxOC0wNC0wNCAwODozNzo1NCkKPiBJbiBlYl9sb29rdXBf
dm1hcygpLCB0aGUgcmV0dXJuIHZhbHVlIG9mIGttZW1fY2FjaGVfYWxsb2MoKSBpcyBmcmVlZAo+
IHdpdGgga2ZyZWUoKS4gSSB0aGluayB0aGUgZXhwZWN0ZWQgcGFpcmVkIGZ1bmN0aW9uIGlzIGtt
ZW1fY2FoY2VfZnJlZSgpLgo+IAo+IFNpZ25lZC1vZmYtYnk6IFhpZG9uZyBXYW5nIDx3YW5neGlk
b25nXzk3QDE2My5jb20+CgpUaGF0IGlzIGluZGVlZCB3aGF0IGl0IHNob3VsZCBiZSBkb2luZywK
CkZpeGVzOiBkMWI0OGMxZTcxODQgKCJkcm0vaTkxNTogUmVwbGFjZSBleGVjYnVmIHZtYSBodCB3
aXRoIGFuIGlkciIpCkNjOiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4K
Q2M6IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+CkNjOiA8c3RhYmxl
QHZnZXIua2VybmVsLm9yZz4gIyB2NC4xNCsKUmV2aWV3ZWQtYnk6IENocmlzIFdpbHNvbiA8Y2hy
aXNAY2hyaXMtd2lsc29uLmNvLnVrPgotQ2hyaXMKX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlz
dHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v
bGlzdGluZm8vaW50ZWwtZ2Z4Cg==