From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751613AbeDFQqZ convert rfc822-to-8bit (ORCPT ); Fri, 6 Apr 2018 12:46:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:59006 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751201AbeDFQqV (ORCPT ); Fri, 6 Apr 2018 12:46:21 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2CB8F217CE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=sboyd@kernel.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT To: Bartosz Golaszewski , Sekhar Nori From: Stephen Boyd In-Reply-To: <57f2182e-09b4-2cab-5602-9d0e029495be@ti.com> Cc: Michael Turquette , David Lechner , linux-clk , devicetree , Linux ARM , Stephen Boyd , Rob Herring , Mark Rutland , Kevin Hilman , Adam Ford , Linux Kernel Mailing List References: <1515377863-20358-1-git-send-email-david@lechnology.com> <1515377863-20358-13-git-send-email-david@lechnology.com> <69bc0848-0698-b936-96a3-2257a5e27809@ti.com> <57f2182e-09b4-2cab-5602-9d0e029495be@ti.com> Message-ID: <152303318048.143116.2883441215887455211@swboyd.mtv.corp.google.com> User-Agent: alot/0.7 Subject: Re: [PATCH v5 12/44] clk: davinci: Add platform information for TI DA850 PSC Date: Fri, 06 Apr 2018 09:46:20 -0700 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Sekhar Nori (2018-04-06 02:37:03) > > Can you please check that and confirm there is no issue with genpd and > using CLK_OF_DECLARE() to initialize clocks? > > Unless you report an issue back, or Mike and Stephen have ideas about > how to handle the dependency between PSC/PLL derived timer clock > initialization and and timer_probe(), I think we need to move back to > using CLK_OF_DECLARE(). In such a case, please use the hybrid approach where the clks required for the clockevent and/or clocksource are registered in the early CLK_OF_DECLARE path but the rest of the clks get registered with a proper platform device and driver. There are examples of this approach on other platforms already. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 To: Bartosz Golaszewski , Sekhar Nori From: Stephen Boyd In-Reply-To: <57f2182e-09b4-2cab-5602-9d0e029495be@ti.com> Cc: Michael Turquette , David Lechner , linux-clk , devicetree , Linux ARM , Stephen Boyd , Rob Herring , Mark Rutland , Kevin Hilman , Adam Ford , Linux Kernel Mailing List References: <1515377863-20358-1-git-send-email-david@lechnology.com> <1515377863-20358-13-git-send-email-david@lechnology.com> <69bc0848-0698-b936-96a3-2257a5e27809@ti.com> <57f2182e-09b4-2cab-5602-9d0e029495be@ti.com> Message-ID: <152303318048.143116.2883441215887455211@swboyd.mtv.corp.google.com> Subject: Re: [PATCH v5 12/44] clk: davinci: Add platform information for TI DA850 PSC Date: Fri, 06 Apr 2018 09:46:20 -0700 List-ID: Quoting Sekhar Nori (2018-04-06 02:37:03) > = > Can you please check that and confirm there is no issue with genpd and = > using CLK_OF_DECLARE() to initialize clocks? > = > Unless you report an issue back, or Mike and Stephen have ideas about = > how to handle the dependency between PSC/PLL derived timer clock = > initialization and and timer_probe(), I think we need to move back to = > using CLK_OF_DECLARE(). = In such a case, please use the hybrid approach where the clks required for the clockevent and/or clocksource are registered in the early CLK_OF_DECLARE path but the rest of the clks get registered with a proper platform device and driver. There are examples of this approach on other platforms already. From mboxrd@z Thu Jan 1 00:00:00 1970 From: sboyd@kernel.org (Stephen Boyd) Date: Fri, 06 Apr 2018 09:46:20 -0700 Subject: [PATCH v5 12/44] clk: davinci: Add platform information for TI DA850 PSC In-Reply-To: <57f2182e-09b4-2cab-5602-9d0e029495be@ti.com> References: <1515377863-20358-1-git-send-email-david@lechnology.com> <1515377863-20358-13-git-send-email-david@lechnology.com> <69bc0848-0698-b936-96a3-2257a5e27809@ti.com> <57f2182e-09b4-2cab-5602-9d0e029495be@ti.com> Message-ID: <152303318048.143116.2883441215887455211@swboyd.mtv.corp.google.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Quoting Sekhar Nori (2018-04-06 02:37:03) > > Can you please check that and confirm there is no issue with genpd and > using CLK_OF_DECLARE() to initialize clocks? > > Unless you report an issue back, or Mike and Stephen have ideas about > how to handle the dependency between PSC/PLL derived timer clock > initialization and and timer_probe(), I think we need to move back to > using CLK_OF_DECLARE(). In such a case, please use the hybrid approach where the clks required for the clockevent and/or clocksource are registered in the early CLK_OF_DECLARE path but the rest of the clks get registered with a proper platform device and driver. There are examples of this approach on other platforms already.