Re: [PATCH 28/36] drm/i915: Enabling rc6 and rps have different requirements, so separate them

From: Chris Wilson <chris@chris-wilson.co.uk>
To: Sagar Arun Kamble <sagar.a.kamble@intel.com>,
	intel-gfx@lists.freedesktop.org
Cc: praveen.paneri@intel.com
Subject: Re: [PATCH 28/36] drm/i915: Enabling rc6 and rps have different requirements, so separate them
Date: Tue, 10 Apr 2018 13:40:13 +0100	[thread overview]
Message-ID: <152336401334.3167.9557997036707053311@mail.alporthouse.com> (raw)
In-Reply-To: <0ef165b4-4bb7-79ff-4ea1-c54156695591@intel.com>

Quoting Sagar Arun Kamble (2018-03-16 14:01:22)
> 
> 
> On 3/14/2018 3:07 PM, Chris Wilson wrote:
> > diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
> > index b9c7b21e5cc8..8a5bf1e26515 100644
> > --- a/drivers/gpu/drm/i915/i915_gem.c
> > +++ b/drivers/gpu/drm/i915/i915_gem.c
> > @@ -3165,10 +3165,12 @@ void i915_gem_reset(struct drm_i915_private *dev_priv)
> >   
> >       i915_gem_restore_fences(dev_priv);
> >   
> > -     if (dev_priv->gt.awake) {
> > -             intel_gt_pm_sanitize(dev_priv);
> > -             intel_gt_pm_enable_rps(dev_priv);
> > +     if (dev_priv->gt_pm.rc6.enabled) {
> > +             dev_priv->gt_pm.rc6.enabled = false;
> >               intel_gt_pm_enable_rc6(dev_priv);
> > +     }
> > +
> I think  patch 31 should precede this one to avoid above changes.

I was always a bit doubtful about patch 31 "Don't fiddle with rps/rc6
across reset", so I left it towards the end so I could easily drop it if
need be. ;)
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx