All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] autofs - mount point create should honour passed in mode
@ 2018-04-13 10:38 Ian Kent
  0 siblings, 0 replies; only message in thread
From: Ian Kent @ 2018-04-13 10:38 UTC (permalink / raw)
  To: Andrew Morton; +Cc: linux-fsdevel, autofs mailing list

The autofs file system mkdir inode operation blindly sets
the created directory mode to S_IFDIR | 0555, ingoring the
passed in mode, which can cause selinux dac_override denials.

But the function also checks if the caller is the daemon (as
no-one else should be able to do anything here) so there's
no point in not honouring the passed in mode, allowing the
daemon to set appropriate mode when required.

Signed-off-by: Ian Kent <raven@themaw.net>
Cc: stable@vger.kernel.org
---
 fs/autofs4/root.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/autofs4/root.c b/fs/autofs4/root.c
index 82e8f6edfb48..b12e37f27530 100644
--- a/fs/autofs4/root.c
+++ b/fs/autofs4/root.c
@@ -749,7 +749,7 @@ static int autofs4_dir_mkdir(struct inode *dir,
 
 	autofs4_del_active(dentry);
 
-	inode = autofs4_get_inode(dir->i_sb, S_IFDIR | 0555);
+	inode = autofs4_get_inode(dir->i_sb, S_IFDIR | mode);
 	if (!inode)
 		return -ENOMEM;
 	d_add(dentry, inode);

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2018-04-13 10:49 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-13 10:38 [PATCH] autofs - mount point create should honour passed in mode Ian Kent

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.