From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751896AbeDMXzQ (ORCPT ); Fri, 13 Apr 2018 19:55:16 -0400 Received: from mga17.intel.com ([192.55.52.151]:59211 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751793AbeDMXzP (ORCPT ); Fri, 13 Apr 2018 19:55:15 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,446,1517904000"; d="scan'208";a="220308799" From: "Mehta, Sohil" To: "gary.hook@amd.com" , "iommu@lists.linux-foundation.org" CC: "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v3 1/2] iommu - Enable debugfs exposure of the IOMMU Thread-Topic: [PATCH v3 1/2] iommu - Enable debugfs exposure of the IOMMU Thread-Index: AQHTzamw6oujwkjOD0OO/ytoQI5d2qP/4BsA Date: Fri, 13 Apr 2018 23:55:13 +0000 Message-ID: <1523663790.2747.4.camel@intel.com> References: <152302042701.47565.17954813724758433858.stgit@sosxen2.amd.com> <152302066417.47565.4017200105445420643.stgit@sosxen2.amd.com> In-Reply-To: <152302066417.47565.4017200105445420643.stgit@sosxen2.amd.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.25.110.4] Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id w3DNtLj5002627 On Fri, 2018-04-06 at 08:17 -0500, Gary R Hook wrote: >  >  > +struct dentry *iommu_debugfs_setup(void) > +{ > + if (!debugfs_initialized()) This check is probably not needed. > + return NULL; > + > + if (!iommu_debugfs_dir) > + iommu_debugfs_dir = debugfs_create_dir("iommu", > NULL); > + > + if (iommu_debugfs_dir) > + pr_warn("WARNING: IOMMU DEBUGFS SUPPORT HAS BEEN > ENABLED IN THIS KERNEL\n"); > + As this gets called for each IOMMU, do you want to use pr_warn_once? > + return iommu_debugfs_dir; > +} > +EXPORT_SYMBOL_GPL(iommu_debugfs_setup); -Sohil From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Mehta, Sohil" Subject: Re: [PATCH v3 1/2] iommu - Enable debugfs exposure of the IOMMU Date: Fri, 13 Apr 2018 23:55:13 +0000 Message-ID: <1523663790.2747.4.camel@intel.com> References: <152302042701.47565.17954813724758433858.stgit@sosxen2.amd.com> <152302066417.47565.4017200105445420643.stgit@sosxen2.amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <152302066417.47565.4017200105445420643.stgit-tq90VzyE+wXkLsZ8J5Uweg@public.gmane.org> Content-Language: en-US Content-ID: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: "gary.hook-5C7GfCeVMHo@public.gmane.org" , "iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org" Cc: "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: iommu@lists.linux-foundation.org T24gRnJpLCAyMDE4LTA0LTA2IGF0IDA4OjE3IC0wNTAwLCBHYXJ5IFIgSG9vayB3cm90ZToNCj7C oA0KPsKgDQo+ICtzdHJ1Y3QgZGVudHJ5ICppb21tdV9kZWJ1Z2ZzX3NldHVwKHZvaWQpDQo+ICt7 DQo+ICsJaWYgKCFkZWJ1Z2ZzX2luaXRpYWxpemVkKCkpDQoNClRoaXMgY2hlY2sgaXMgcHJvYmFi bHkgbm90IG5lZWRlZC4NCg0KPiArCQlyZXR1cm4gTlVMTDsNCj4gKw0KPiArCWlmICghaW9tbXVf ZGVidWdmc19kaXIpDQo+ICsJCWlvbW11X2RlYnVnZnNfZGlyID0gZGVidWdmc19jcmVhdGVfZGly KCJpb21tdSIsDQo+IE5VTEwpOw0KPiArDQo+ICsJaWYgKGlvbW11X2RlYnVnZnNfZGlyKQ0KPiAr CQlwcl93YXJuKCJXQVJOSU5HOiBJT01NVSBERUJVR0ZTIFNVUFBPUlQgSEFTIEJFRU4NCj4gRU5B QkxFRCBJTiBUSElTIEtFUk5FTFxuIik7DQo+ICsNCg0KQXMgdGhpcyBnZXRzIGNhbGxlZCBmb3Ig ZWFjaCBJT01NVSwgZG8geW91IHdhbnQgdG8gdXNlIHByX3dhcm5fb25jZT8NCg0KPiArCXJldHVy biBpb21tdV9kZWJ1Z2ZzX2RpcjsNCj4gK30NCj4gK0VYUE9SVF9TWU1CT0xfR1BMKGlvbW11X2Rl YnVnZnNfc2V0dXApOw0KDQotU29oaWwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KaW9tbXUgbWFpbGluZyBsaXN0CmlvbW11QGxpc3RzLmxpbnV4LWZvdW5k YXRpb24ub3JnCmh0dHBzOi8vbGlzdHMubGludXhmb3VuZGF0aW9uLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2lvbW11