From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752519AbeDNAJD (ORCPT ); Fri, 13 Apr 2018 20:09:03 -0400 Received: from mga02.intel.com ([134.134.136.20]:40560 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751877AbeDNAJB (ORCPT ); Fri, 13 Apr 2018 20:09:01 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,446,1517904000"; d="scan'208";a="220296884" From: "Mehta, Sohil" To: "gary.hook@amd.com" , "iommu@lists.linux-foundation.org" CC: "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v3 2/2] iommu/amd: Add basic debugfs infrastructure for AMD IOMMU Thread-Topic: [PATCH v3 2/2] iommu/amd: Add basic debugfs infrastructure for AMD IOMMU Thread-Index: AQHT04THDyVaDNNW7k6hYyQjJLsxvQ== Date: Sat, 14 Apr 2018 00:08:55 +0000 Message-ID: <1523664612.2747.13.camel@intel.com> References: <152302042701.47565.17954813724758433858.stgit@sosxen2.amd.com> <152302067362.47565.628887796165116844.stgit@sosxen2.amd.com> In-Reply-To: <152302067362.47565.628887796165116844.stgit@sosxen2.amd.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.25.110.4] Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id w3E09xjj002648 On Fri, 2018-04-06 at 08:17 -0500, Gary R Hook wrote: >  > + > +void amd_iommu_debugfs_setup(struct amd_iommu *iommu) > +{ > + char name[MAX_NAME_LEN + 1]; > + struct dentry *d_top; > + > + if (!debugfs_initialized()) Probably not needed. > + return; > + > + mutex_lock(&amd_iommu_debugfs_lock); > + if (!amd_iommu_debugfs) { > + d_top = iommu_debugfs_setup(); > + if (d_top) > + amd_iommu_debugfs = > debugfs_create_dir("amd", d_top); > + } > + mutex_unlock(&amd_iommu_debugfs_lock); You can do the above only once if you iterate over the IOMMUs here  instead of doing it in amd_iommu_init. > + if (amd_iommu_debugfs) { > + snprintf(name, MAX_NAME_LEN, "iommu%02d", iommu- > >index); > + iommu->debugfs = debugfs_create_dir(name, > +     amd_iommu_debugf > s); > + if (!iommu->debugfs) { > + debugfs_remove_recursive(amd_iommu_debugfs); > + amd_iommu_debugfs = NULL; > + } > + } > +} -Sohil From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Mehta, Sohil" Subject: Re: [PATCH v3 2/2] iommu/amd: Add basic debugfs infrastructure for AMD IOMMU Date: Sat, 14 Apr 2018 00:08:55 +0000 Message-ID: <1523664612.2747.13.camel@intel.com> References: <152302042701.47565.17954813724758433858.stgit@sosxen2.amd.com> <152302067362.47565.628887796165116844.stgit@sosxen2.amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <152302067362.47565.628887796165116844.stgit-tq90VzyE+wXkLsZ8J5Uweg@public.gmane.org> Content-Language: en-US Content-ID: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: "gary.hook-5C7GfCeVMHo@public.gmane.org" , "iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org" Cc: "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: iommu@lists.linux-foundation.org T24gRnJpLCAyMDE4LTA0LTA2IGF0IDA4OjE3IC0wNTAwLCBHYXJ5IFIgSG9vayB3cm90ZToNCj7C oA0KPiArDQo+ICt2b2lkIGFtZF9pb21tdV9kZWJ1Z2ZzX3NldHVwKHN0cnVjdCBhbWRfaW9tbXUg KmlvbW11KQ0KPiArew0KPiArCWNoYXIgbmFtZVtNQVhfTkFNRV9MRU4gKyAxXTsNCj4gKwlzdHJ1 Y3QgZGVudHJ5ICpkX3RvcDsNCj4gKw0KPiArCWlmICghZGVidWdmc19pbml0aWFsaXplZCgpKQ0K DQpQcm9iYWJseSBub3QgbmVlZGVkLg0KDQo+ICsJCXJldHVybjsNCj4gKw0KPiArCW11dGV4X2xv Y2soJmFtZF9pb21tdV9kZWJ1Z2ZzX2xvY2spOw0KPiArCWlmICghYW1kX2lvbW11X2RlYnVnZnMp IHsNCj4gKwkJZF90b3AgPSBpb21tdV9kZWJ1Z2ZzX3NldHVwKCk7DQo+ICsJCWlmIChkX3RvcCkN Cj4gKwkJCWFtZF9pb21tdV9kZWJ1Z2ZzID0NCj4gZGVidWdmc19jcmVhdGVfZGlyKCJhbWQiLCBk X3RvcCk7DQo+ICsJfQ0KPiArCW11dGV4X3VubG9jaygmYW1kX2lvbW11X2RlYnVnZnNfbG9jayk7 DQoNCg0KWW91IGNhbiBkbyB0aGUgYWJvdmUgb25seSBvbmNlIGlmIHlvdSBpdGVyYXRlIG92ZXIg dGhlIElPTU1VcyBoZXJlDQrCoGluc3RlYWQgb2YgZG9pbmcgaXQgaW7CoGFtZF9pb21tdV9pbml0 Lg0KDQo+ICsJaWYgKGFtZF9pb21tdV9kZWJ1Z2ZzKSB7DQo+ICsJCXNucHJpbnRmKG5hbWUsIE1B WF9OQU1FX0xFTiwgImlvbW11JTAyZCIsIGlvbW11LQ0KPiA+aW5kZXgpOw0KPiArCQlpb21tdS0+ ZGVidWdmcyA9IGRlYnVnZnNfY3JlYXRlX2RpcihuYW1lLA0KPiArCQkJCQkJwqDCoMKgwqBhbWRf aW9tbXVfZGVidWdmDQo+IHMpOw0KPiArCQlpZiAoIWlvbW11LT5kZWJ1Z2ZzKSB7DQo+ICsJCQlk ZWJ1Z2ZzX3JlbW92ZV9yZWN1cnNpdmUoYW1kX2lvbW11X2RlYnVnZnMpOw0KPiArCQkJYW1kX2lv bW11X2RlYnVnZnMgPSBOVUxMOw0KPiArCQl9DQo+ICsJfQ0KPiArfQ0KDQotU29oaWwKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KaW9tbXUgbWFpbGluZyBs aXN0CmlvbW11QGxpc3RzLmxpbnV4LWZvdW5kYXRpb24ub3JnCmh0dHBzOi8vbGlzdHMubGludXhm b3VuZGF0aW9uLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lvbW11