From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.cn.fujitsu.com ([183.91.158.132]:26883 "EHLO heian.cn.fujitsu.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751191AbeDQGMD (ORCPT ); Tue, 17 Apr 2018 02:12:03 -0400 From: yang xu Subject: [PATCH v3] common/xfs: Add require_xfs_db_write_array function Date: Tue, 17 Apr 2018 14:11:40 +0800 Message-ID: <1523945500-10819-1-git-send-email-xuyang.jy@cn.fujitsu.com> In-Reply-To: <20180417040641.GA5210@magnolia> References: <20180417040641.GA5210@magnolia> MIME-Version: 1.0 Content-Type: text/plain Sender: fstests-owner@vger.kernel.org To: darrick.wong@oracle.com Cc: guaneryu@gmail.com, david@fromorbit.com, fstests@vger.kernel.org, yang xu List-ID: xfsprogs commit 4222d00("db: write via array indexing doesn't work") fixes a bug that xfs_db write can't support array indexing. This function will check whether the bug is fixed on the current xfsprogs. xfs/444 applies the function, and skips if this bug exists. Signed-off-by: yang xu --- common/xfs | 17 +++++++++++++++++ tests/xfs/444 | 1 + 2 files changed, 18 insertions(+) diff --git a/common/xfs b/common/xfs index 3169f87..0b59994 100644 --- a/common/xfs +++ b/common/xfs @@ -701,3 +701,20 @@ _scratch_xfs_set_sb_field() { _scratch_xfs_set_metadata_field "$1" "$2" "sb 0" } + +#Before xfsprogs commit 4222d000ed("db: write via array indexing doesn't work"), +##xfs_db command to write a specific AGFL index doesn't work. +_require_xfs_db_write_array() +{ + local supported=0 + + _require_test + touch $TEST_DIR/$seq.img + $MKFS_XFS_PROG -d file,name=$TEST_DIR/$seq.img,size=512m >/dev/null 2>&1 + $XFS_DB_PROG -x -c "agfl 0" -c "write bno[32] 78" $TEST_DIR/$seq.img \ + >/dev/null 2>&1 + $XFS_DB_PROG -x -c "agfl 0" -c "print bno[32]" $TEST_DIR/$seq.img \ + | grep -q "bno\[32\] = 78" && supported=1 + rm -f $TEST_DIR/$seq.img + [ $supported -eq 0 ] && _notrun "xfs_db write can't support array" +} diff --git a/tests/xfs/444 b/tests/xfs/444 index 141be52..9700422 100755 --- a/tests/xfs/444 +++ b/tests/xfs/444 @@ -54,6 +54,7 @@ _supported_os Linux _require_check_dmesg _require_scratch _require_test_program "punch-alternating" +_require_xfs_db_write_array # This is only a v5 filesystem problem _require_scratch_xfs_crc -- 1.8.3.1