From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: sandeen@redhat.com, darrick.wong@oracle.com
Cc: linux-xfs@vger.kernel.org
Subject: [PATCH 04/11] xfs_repair: zap corrupt remote symlink
Date: Tue, 17 Apr 2018 19:46:57 -0700 [thread overview]
Message-ID: <152401961698.13319.6780338835004190495.stgit@magnolia> (raw)
In-Reply-To: <152401958920.13319.10756339531174871801.stgit@magnolia>
From: Darrick J. Wong <darrick.wong@oracle.com>
If a remote symlink has a corrupted remote block, just zap the symlink.
Fixes total lack of repair activity in xfs/382.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
repair/dinode.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/repair/dinode.c b/repair/dinode.c
index 9af4f05..ceffc52 100644
--- a/repair/dinode.c
+++ b/repair/dinode.c
@@ -1330,6 +1330,13 @@ _("cannot read inode %" PRIu64 ", file block %d, disk block %" PRIu64 "\n"),
lino, i, fsbno);
return 1;
}
+ if (bp->b_error == -EFSCORRUPTED) {
+ do_warn(
+_("Corrupt symlink remote, block %" PRIu64 ", inode %" PRIu64 ".\n"),
+ fsbno, lino);
+ libxfs_putbuf(bp);
+ return 1;
+ }
if (bp->b_error == -EFSBADCRC) {
do_warn(
_("Bad symlink buffer CRC, block %" PRIu64 ", inode %" PRIu64 ".\n"
next prev parent reply other threads:[~2018-04-18 2:47 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-18 2:46 [PATCH 00/11] xfsprogs-4.17: xfs_repair fixes Darrick J. Wong
2018-04-18 2:46 ` [PATCH 01/11] xfs_repair: examine all remote attribute blocks Darrick J. Wong
2018-05-04 18:20 ` Eric Sandeen
2018-05-04 19:23 ` Darrick J. Wong
2018-05-23 3:15 ` [PATCH v2 " Darrick J. Wong
2018-05-23 3:47 ` Allison Henderson
2018-04-18 2:46 ` [PATCH 02/11] xfs_repair: don't leak buffer on xattr remote buf verifier error Darrick J. Wong
2018-05-04 19:16 ` Eric Sandeen
2018-04-18 2:46 ` [PATCH 03/11] xfs_repair: validate some of the log space information Darrick J. Wong
2018-05-04 19:29 ` Eric Sandeen
2018-05-04 20:25 ` Darrick J. Wong
2018-05-04 20:54 ` Eric Sandeen
2018-05-23 3:15 ` [PATCH v2 " Darrick J. Wong
2018-05-23 3:52 ` Allison Henderson
2018-04-18 2:46 ` Darrick J. Wong [this message]
2018-05-04 19:46 ` [PATCH 04/11] xfs_repair: zap corrupt remote symlink Eric Sandeen
2018-05-04 20:22 ` Darrick J. Wong
2018-04-18 2:47 ` [PATCH 05/11] xfs_repair: treat zero da btree pointers as corruption Darrick J. Wong
2018-05-04 19:59 ` Eric Sandeen
2018-04-18 2:47 ` [PATCH 06/11] xfs_repair: invalidate dirty dir buffers when we zap a directory Darrick J. Wong
2018-05-04 20:13 ` Eric Sandeen
2018-04-18 2:47 ` [PATCH 07/11] xfs_repair: only update in-core extent state after scanning full extent Darrick J. Wong
2018-05-04 21:52 ` Eric Sandeen
2018-04-18 2:47 ` [PATCH 08/11] xfs_repair: don't crash if da btree is corrupt Darrick J. Wong
2018-05-04 22:00 ` Eric Sandeen
2018-04-18 2:47 ` [PATCH 09/11] xfs_repair: don't assert if we run across a dir entry with null ino ptr Darrick J. Wong
2018-05-04 22:33 ` Eric Sandeen
2018-05-04 22:45 ` Darrick J. Wong
2018-05-08 16:07 ` Darrick J. Wong
2018-05-08 16:31 ` [PATCH v2 09/11] xfs_repair: actually fix .. entries that point to inode zero Darrick J. Wong
2018-04-18 2:47 ` [PATCH 10/11] xfs_repair: check inode nsec for obviously garbage values Darrick J. Wong
2018-05-04 22:38 ` Eric Sandeen
2018-04-18 2:47 ` [PATCH 11/11] xfs_repair: don't assert on bad '.' entry in no-modify mode Darrick J. Wong
2018-05-04 22:41 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=152401961698.13319.6780338835004190495.stgit@magnolia \
--to=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.