All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alex Kiernan <alex.kiernan@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v1 8/8] spl: disk: usb: Add dependencies to sprintf/strto*
Date: Wed, 18 Apr 2018 09:02:23 +0000	[thread overview]
Message-ID: <1524042143-30213-9-git-send-email-alex.kiernan@gmail.com> (raw)
In-Reply-To: <1524042143-30213-1-git-send-email-alex.kiernan@gmail.com>

If SPL serial support is disabled nothing brings in sprintf, snprintf
or simple_strtoul:

  env/built-in.o: In function `regex_callback':
  env/attr.c:128: undefined reference to `sprintf'
  disk/built-in.o: In function `blk_get_device_by_str':
  disk/part.c:386: undefined reference to `simple_strtoul'
  disk/part.c:395: undefined reference to `simple_strtoul'
  disk/built-in.o: In function `blk_get_device_part_str':
  disk/part.c:522: undefined reference to `simple_strtoul'
  disk/built-in.o: In function `part_set_generic_name':
  disk/part.c:704: undefined reference to `sprintf'
  drivers/built-in.o: In function `init_peripheral_ep':
  drivers/usb/musb-new/musb_gadget.c:1826: undefined reference to `sprintf'
  drivers/built-in.o: In function `musb_core_init':
  drivers/usb/musb-new/musb_core.c:1451: undefined reference to `snprintf'

Add those dependencies here.

Signed-off-by: Alex Kiernan <alex.kiernan@gmail.com>
---

 disk/Kconfig                 | 4 ++++
 drivers/usb/musb-new/Kconfig | 4 ++++
 2 files changed, 8 insertions(+)

diff --git a/disk/Kconfig b/disk/Kconfig
index 8af2a95..f9f8416 100644
--- a/disk/Kconfig
+++ b/disk/Kconfig
@@ -4,6 +4,10 @@ menu "Partition Types"
 config PARTITIONS
 	bool "Enable Partition Labels (disklabels) support"
 	default y
+	select SPL_SPRINTF
+	select TPL_SPRINTF
+	select SPL_STRTO
+	select TPL_STRTO
 	help
 	  Partition Labels (disklabels) Supported:
 	  Zero or more of the following:
diff --git a/drivers/usb/musb-new/Kconfig b/drivers/usb/musb-new/Kconfig
index ea5bae2..46ae794 100644
--- a/drivers/usb/musb-new/Kconfig
+++ b/drivers/usb/musb-new/Kconfig
@@ -5,12 +5,16 @@ comment "MUSB Controller Driver"
 
 config USB_MUSB_HOST
 	bool "MUSB host mode support"
+	select SPL_SPRINTF
+	select TPL_SPRINTF
 	help
 	  Enables the MUSB USB dual-role controller in host mode.
 
 config USB_MUSB_GADGET
 	bool "MUSB gadget mode support"
 	select USB_GADGET_DUALSPEED
+	select SPL_SPRINTF
+	select TPL_SPRINTF
 	help
 	  Enables the MUSB USB dual-role controller in gadget mode.
 
-- 
2.7.4

  parent reply	other threads:[~2018-04-18  9:02 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-18  9:02 [U-Boot] [PATCH v1 0/8] Fix SPL build without CONFIG_SPL_SERIAL_SUPPORT Alex Kiernan
2018-04-18  9:02 ` [U-Boot] [PATCH v1 1/8] Cleanup CONFIG_SPL_SERIAL_SUPPORT migration Alex Kiernan
2018-04-18  9:02 ` [U-Boot] [PATCH v1 2/8] spl: ti: Avoid preloader_console_init if !CONFIG_SPL_SERIAL_SUPPORT Alex Kiernan
2018-04-18  9:02 ` [U-Boot] [PATCH v1 3/8] spl: Add dependency on serial to Ymodem Alex Kiernan
2018-04-18  9:02 ` [U-Boot] [PATCH v1 4/8] spl: ti: Avoid serial calls when serial support is disabled Alex Kiernan
2018-04-18  9:02 ` [U-Boot] [PATCH v1 5/8] spl: Split sprintf, strto* from SPL serial in Kconfig Alex Kiernan
2018-04-18  9:02 ` [U-Boot] [PATCH v1 6/8] spl: Disable printf if not required Alex Kiernan
2018-04-18  9:27   ` Jean-Jacques Hiblot
2018-04-18 10:29     ` Alex Kiernan
2018-04-18  9:02 ` [U-Boot] [PATCH v1 7/8] Consolidate __assert_failed into one implementation Alex Kiernan
2018-04-18  9:02 ` Alex Kiernan [this message]
2018-04-18  9:11   ` [U-Boot] [PATCH v1 8/8] spl: disk: usb: Add dependencies to sprintf/strto* Maxime Ripard
2018-04-18 10:27     ` Alex Kiernan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1524042143-30213-9-git-send-email-alex.kiernan@gmail.com \
    --to=alex.kiernan@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.