Re: [PATCH v2 3/3] drm/i915: Pack params to engine->schedule() into a struct

[Joonas Lahtinen <joonas.lahtinen@linux.intel.com>]

Quoting Chris Wilson (2018-04-17 17:31:32)
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -12839,7 +12839,9 @@ intel_prepare_plane_fb(struct drm_plane *plane,
>  
>         ret = intel_plane_pin_fb(to_intel_plane_state(new_state));
>  
> -       i915_gem_object_wait_priority(obj, 0, I915_PRIORITY_DISPLAY);
> +       i915_gem_object_wait_priority(obj, 0, &(struct i915_sched_attr){
> +                                     .priority = I915_PRIORITY_DISPLAY,
> +                                     });

Just lift the parameter to previous line :P

>  
>         mutex_unlock(&dev_priv->drm.struct_mutex);
>         i915_gem_object_unpin_pages(obj);
> diff --git a/drivers/gpu/drm/i915/intel_engine_cs.c b/drivers/gpu/drm/i915/intel_engine_cs.c
> index b542b1a4dddc..be608f7111f5 100644
> --- a/drivers/gpu/drm/i915/intel_engine_cs.c
> +++ b/drivers/gpu/drm/i915/intel_engine_cs.c
> @@ -1113,17 +1113,29 @@ unsigned int intel_engines_has_context_isolation(struct drm_i915_private *i915)
>         return which;
>  }
>  
> +static void print_sched_attr(struct drm_printer *m,
> +                            const struct drm_i915_private *i915,
> +                            const struct i915_sched_attr *attr)
> +{
> +       if (attr->priority == I915_PRIORITY_INVALID)
> +               return;

This will yield a double space in the output. Just sayin'

> +
> +       drm_printf(m, "prio=%d", attr->priority);
> +}

With the parameter passing normalized, this is:

Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>

Regards, Joonas
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx