From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [RFC PATCH 2/2] HISI LPC: Add PNP device support Date: Fri, 20 Apr 2018 16:28:30 +0300 Message-ID: <1524230910.21176.474.camel@linux.intel.com> References: <1524218846-169934-1-git-send-email-john.garry@huawei.com> <1524218846-169934-3-git-send-email-john.garry@huawei.com> <1524228606.21176.472.camel@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: John Garry , rjw@rjwysocki.net, linux-acpi@vger.kernel.org, lenb@kernel.org, mika.westerberg@linux.intel.com, lorenzo.pieralisi@arm.com Cc: linux-kernel@vger.kernel.org, arnd@arndb.de, graeme.gregory@linaro.org, helgaas@kernel.org, linuxarm@huawei.com, z.liuxinliang@hisilicon.com List-Id: linux-acpi@vger.kernel.org On Fri, 2018-04-20 at 14:09 +0100, John Garry wrote: > On 20/04/2018 13:50, Andy Shevchenko wrote: > > On Fri, 2018-04-20 at 18:07 +0800, John Garry wrote: > > > + if (res->flags | IORESOURCE_IO) > > > > What does this mean? > > Here we check the resource flag for each resource for this PNP device > - > for IO resources we must translate the resource value from the bus > address to the logical PIO address. Please, re-read your code again. -- Andy Shevchenko Intel Finland Oy