All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: shmobile: koelsch: Fix adv7511 IRQ sensing
@ 2015-04-29 13:55 Laurent Pinchart
  2015-04-30  4:56 ` Simon Horman
                   ` (4 more replies)
  0 siblings, 5 replies; 8+ messages in thread
From: Laurent Pinchart @ 2015-04-29 13:55 UTC (permalink / raw)
  To: linux-sh

The adv7511 IRQ is low level triggered, not falling edge triggered. The
wrong sense configuration results in no interrupt being triggered at
all, breaking hotplug detection. Fix it.

Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
 arch/arm/boot/dts/r8a7791-koelsch.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts b/arch/arm/boot/dts/r8a7791-koelsch.dts
index 74c3212f1f11..824ddab9c3ad 100644
--- a/arch/arm/boot/dts/r8a7791-koelsch.dts
+++ b/arch/arm/boot/dts/r8a7791-koelsch.dts
@@ -545,7 +545,7 @@
 		compatible = "adi,adv7511w";
 		reg = <0x39>;
 		interrupt-parent = <&gpio3>;
-		interrupts = <29 IRQ_TYPE_EDGE_FALLING>;
+		interrupts = <29 IRQ_TYPE_LEVEL_LOW>;
 
 		adi,input-depth = <8>;
 		adi,input-colorspace = "rgb";
-- 
Regards,

Laurent Pinchart


^ permalink raw reply related	[flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: shmobile: koelsch: Fix adv7511 IRQ sensing
  2015-04-29 13:55 [PATCH] ARM: shmobile: koelsch: Fix adv7511 IRQ sensing Laurent Pinchart
@ 2015-04-30  4:56 ` Simon Horman
  2015-04-30  7:30 ` Laurent Pinchart
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 8+ messages in thread
From: Simon Horman @ 2015-04-30  4:56 UTC (permalink / raw)
  To: linux-sh

Hi Laurent,

On Wed, Apr 29, 2015 at 04:55:43PM +0300, Laurent Pinchart wrote:
> The adv7511 IRQ is low level triggered, not falling edge triggered. The
> wrong sense configuration results in no interrupt being triggered at
> all, breaking hotplug detection. Fix it.

Would I be correct in adding the following and queuing it up
as a fix for v4.1 and v4.0-stable?

Fixes: 83a0731b39f3 ("ARM: shmobile: koelsch: Add DU HDMI output support")


> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
>  arch/arm/boot/dts/r8a7791-koelsch.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts b/arch/arm/boot/dts/r8a7791-koelsch.dts
> index 74c3212f1f11..824ddab9c3ad 100644
> --- a/arch/arm/boot/dts/r8a7791-koelsch.dts
> +++ b/arch/arm/boot/dts/r8a7791-koelsch.dts
> @@ -545,7 +545,7 @@
>  		compatible = "adi,adv7511w";
>  		reg = <0x39>;
>  		interrupt-parent = <&gpio3>;
> -		interrupts = <29 IRQ_TYPE_EDGE_FALLING>;
> +		interrupts = <29 IRQ_TYPE_LEVEL_LOW>;
>  
>  		adi,input-depth = <8>;
>  		adi,input-colorspace = "rgb";
> -- 
> Regards,
> 
> Laurent Pinchart
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: shmobile: koelsch: Fix adv7511 IRQ sensing
  2015-04-29 13:55 [PATCH] ARM: shmobile: koelsch: Fix adv7511 IRQ sensing Laurent Pinchart
  2015-04-30  4:56 ` Simon Horman
@ 2015-04-30  7:30 ` Laurent Pinchart
  2015-05-01  0:15 ` Simon Horman
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 8+ messages in thread
From: Laurent Pinchart @ 2015-04-30  7:30 UTC (permalink / raw)
  To: linux-sh

Hi Simon,

On Thursday 30 April 2015 13:56:40 Simon Horman wrote:
> Hi Laurent,
> 
> On Wed, Apr 29, 2015 at 04:55:43PM +0300, Laurent Pinchart wrote:
> > The adv7511 IRQ is low level triggered, not falling edge triggered. The
> > wrong sense configuration results in no interrupt being triggered at
> > all, breaking hotplug detection. Fix it.
> 
> Would I be correct in adding the following and queuing it up
> as a fix for v4.1 and v4.0-stable?
> 
> Fixes: 83a0731b39f3 ("ARM: shmobile: koelsch: Add DU HDMI output support")

I think that would be fine. It's not a regression fix in the traditional 
sense, but it fixes a shortcoming of the original commit.

> > Signed-off-by: Laurent Pinchart
> > <laurent.pinchart+renesas@ideasonboard.com>
> > ---
> > 
> >  arch/arm/boot/dts/r8a7791-koelsch.dts | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts
> > b/arch/arm/boot/dts/r8a7791-koelsch.dts index 74c3212f1f11..824ddab9c3ad
> > 100644
> > --- a/arch/arm/boot/dts/r8a7791-koelsch.dts
> > +++ b/arch/arm/boot/dts/r8a7791-koelsch.dts
> > @@ -545,7 +545,7 @@
> >  		compatible = "adi,adv7511w";
> >  		reg = <0x39>;
> >  		interrupt-parent = <&gpio3>;
> > -		interrupts = <29 IRQ_TYPE_EDGE_FALLING>;
> > +		interrupts = <29 IRQ_TYPE_LEVEL_LOW>;
> > 
> >  		adi,input-depth = <8>;
> >  		adi,input-colorspace = "rgb";

-- 
Regards,

Laurent Pinchart


^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: shmobile: koelsch: Fix adv7511 IRQ sensing
  2015-04-29 13:55 [PATCH] ARM: shmobile: koelsch: Fix adv7511 IRQ sensing Laurent Pinchart
  2015-04-30  4:56 ` Simon Horman
  2015-04-30  7:30 ` Laurent Pinchart
@ 2015-05-01  0:15 ` Simon Horman
  2015-05-05 21:17 ` Ben Hutchings
  2015-05-06  4:06 ` Laurent Pinchart
  4 siblings, 0 replies; 8+ messages in thread
From: Simon Horman @ 2015-05-01  0:15 UTC (permalink / raw)
  To: linux-sh

Hi Laurent,

On Thu, Apr 30, 2015 at 10:30:48AM +0300, Laurent Pinchart wrote:
> Hi Simon,
> 
> On Thursday 30 April 2015 13:56:40 Simon Horman wrote:
> > Hi Laurent,
> > 
> > On Wed, Apr 29, 2015 at 04:55:43PM +0300, Laurent Pinchart wrote:
> > > The adv7511 IRQ is low level triggered, not falling edge triggered. The
> > > wrong sense configuration results in no interrupt being triggered at
> > > all, breaking hotplug detection. Fix it.
> > 
> > Would I be correct in adding the following and queuing it up
> > as a fix for v4.1 and v4.0-stable?
> > 
> > Fixes: 83a0731b39f3 ("ARM: shmobile: koelsch: Add DU HDMI output support")
> 
> I think that would be fine. It's not a regression fix in the traditional 
> sense, but it fixes a shortcoming of the original commit.

Thanks, got it.

> > > Signed-off-by: Laurent Pinchart
> > > <laurent.pinchart+renesas@ideasonboard.com>
> > > ---
> > > 
> > >  arch/arm/boot/dts/r8a7791-koelsch.dts | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts
> > > b/arch/arm/boot/dts/r8a7791-koelsch.dts index 74c3212f1f11..824ddab9c3ad
> > > 100644
> > > --- a/arch/arm/boot/dts/r8a7791-koelsch.dts
> > > +++ b/arch/arm/boot/dts/r8a7791-koelsch.dts
> > > @@ -545,7 +545,7 @@
> > >  		compatible = "adi,adv7511w";
> > >  		reg = <0x39>;
> > >  		interrupt-parent = <&gpio3>;
> > > -		interrupts = <29 IRQ_TYPE_EDGE_FALLING>;
> > > +		interrupts = <29 IRQ_TYPE_LEVEL_LOW>;
> > > 
> > >  		adi,input-depth = <8>;
> > >  		adi,input-colorspace = "rgb";
> 
> -- 
> Regards,
> 
> Laurent Pinchart
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: shmobile: koelsch: Fix adv7511 IRQ sensing
  2015-04-29 13:55 [PATCH] ARM: shmobile: koelsch: Fix adv7511 IRQ sensing Laurent Pinchart
                   ` (2 preceding siblings ...)
  2015-05-01  0:15 ` Simon Horman
@ 2015-05-05 21:17 ` Ben Hutchings
  2015-05-06  4:06 ` Laurent Pinchart
  4 siblings, 0 replies; 8+ messages in thread
From: Ben Hutchings @ 2015-05-05 21:17 UTC (permalink / raw)
  To: linux-sh

On Wed, 2015-04-29 at 16:55 +0300, Laurent Pinchart wrote:
> The adv7511 IRQ is low level triggered, not falling edge triggered. The
> wrong sense configuration results in no interrupt being triggered at
> all, breaking hotplug detection. Fix it.

The Lager DT has the same bug; will you send a fix for that or should I?

Ben.

> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
>  arch/arm/boot/dts/r8a7791-koelsch.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts b/arch/arm/boot/dts/r8a7791-koelsch.dts
> index 74c3212f1f11..824ddab9c3ad 100644
> --- a/arch/arm/boot/dts/r8a7791-koelsch.dts
> +++ b/arch/arm/boot/dts/r8a7791-koelsch.dts
> @@ -545,7 +545,7 @@
>  		compatible = "adi,adv7511w";
>  		reg = <0x39>;
>  		interrupt-parent = <&gpio3>;
> -		interrupts = <29 IRQ_TYPE_EDGE_FALLING>;
> +		interrupts = <29 IRQ_TYPE_LEVEL_LOW>;
>  
>  		adi,input-depth = <8>;
>  		adi,input-colorspace = "rgb";



^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: shmobile: koelsch: Fix adv7511 IRQ sensing
  2015-04-29 13:55 [PATCH] ARM: shmobile: koelsch: Fix adv7511 IRQ sensing Laurent Pinchart
                   ` (3 preceding siblings ...)
  2015-05-05 21:17 ` Ben Hutchings
@ 2015-05-06  4:06 ` Laurent Pinchart
  4 siblings, 0 replies; 8+ messages in thread
From: Laurent Pinchart @ 2015-05-06  4:06 UTC (permalink / raw)
  To: linux-sh

Hi Ben,

On Tuesday 05 May 2015 22:17:56 Ben Hutchings wrote:
> On Wed, 2015-04-29 at 16:55 +0300, Laurent Pinchart wrote:
> > The adv7511 IRQ is low level triggered, not falling edge triggered. The
> > wrong sense configuration results in no interrupt being triggered at
> > all, breaking hotplug detection. Fix it.
> 
> The Lager DT has the same bug; will you send a fix for that or should I?

I've sent it and CC'ed you.

> > Signed-off-by: Laurent Pinchart
> > <laurent.pinchart+renesas@ideasonboard.com>
> > ---
> > 
> >  arch/arm/boot/dts/r8a7791-koelsch.dts | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts
> > b/arch/arm/boot/dts/r8a7791-koelsch.dts index 74c3212f1f11..824ddab9c3ad
> > 100644
> > --- a/arch/arm/boot/dts/r8a7791-koelsch.dts
> > +++ b/arch/arm/boot/dts/r8a7791-koelsch.dts
> > @@ -545,7 +545,7 @@
> >  		compatible = "adi,adv7511w";
> >  		reg = <0x39>;
> >  		interrupt-parent = <&gpio3>;
> > -		interrupts = <29 IRQ_TYPE_EDGE_FALLING>;
> > +		interrupts = <29 IRQ_TYPE_LEVEL_LOW>;
> > 
> >  		adi,input-depth = <8>;
> >  		adi,input-colorspace = "rgb";

-- 
Regards,

Laurent Pinchart


^ permalink raw reply	[flat|nested] 8+ messages in thread
* [PATCH] ARM: shmobile: koelsch: Fix adv7511 IRQ sensing
  2015-05-07  5:46 [GIT PULL] Renesas ARM Based SoC Fixes for v4.1 Simon Horman
@ 2015-05-07  5:46   ` Simon Horman
  0 siblings, 0 replies; 8+ messages in thread
From: Simon Horman @ 2015-05-07  5:46 UTC (permalink / raw)
  To: linux-arm-kernel

From: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>

The adv7511 IRQ is low level triggered, not falling edge triggered. The
wrong sense configuration results in no interrupt being triggered at
all, breaking hotplug detection. Fix it.

Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Fixes: 83a0731b39f3 ("ARM: shmobile: koelsch: Add DU HDMI output support")
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 arch/arm/boot/dts/r8a7791-koelsch.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts b/arch/arm/boot/dts/r8a7791-koelsch.dts
index 74c3212f1f11..824ddab9c3ad 100644
--- a/arch/arm/boot/dts/r8a7791-koelsch.dts
+++ b/arch/arm/boot/dts/r8a7791-koelsch.dts
@@ -545,7 +545,7 @@
 		compatible = "adi,adv7511w";
 		reg = <0x39>;
 		interrupt-parent = <&gpio3>;
-		interrupts = <29 IRQ_TYPE_EDGE_FALLING>;
+		interrupts = <29 IRQ_TYPE_LEVEL_LOW>;
 
 		adi,input-depth = <8>;
 		adi,input-colorspace = "rgb";
-- 
2.1.4


^ permalink raw reply related	[flat|nested] 8+ messages in thread
* [PATCH] ARM: shmobile: koelsch: Fix adv7511 IRQ sensing
@ 2015-05-07  5:46   ` Simon Horman
  0 siblings, 0 replies; 8+ messages in thread
From: Simon Horman @ 2015-05-07  5:46 UTC (permalink / raw)
  To: linux-arm-kernel

From: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>

The adv7511 IRQ is low level triggered, not falling edge triggered. The
wrong sense configuration results in no interrupt being triggered at
all, breaking hotplug detection. Fix it.

Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Fixes: 83a0731b39f3 ("ARM: shmobile: koelsch: Add DU HDMI output support")
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 arch/arm/boot/dts/r8a7791-koelsch.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts b/arch/arm/boot/dts/r8a7791-koelsch.dts
index 74c3212f1f11..824ddab9c3ad 100644
--- a/arch/arm/boot/dts/r8a7791-koelsch.dts
+++ b/arch/arm/boot/dts/r8a7791-koelsch.dts
@@ -545,7 +545,7 @@
 		compatible = "adi,adv7511w";
 		reg = <0x39>;
 		interrupt-parent = <&gpio3>;
-		interrupts = <29 IRQ_TYPE_EDGE_FALLING>;
+		interrupts = <29 IRQ_TYPE_LEVEL_LOW>;
 
 		adi,input-depth = <8>;
 		adi,input-colorspace = "rgb";
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2015-05-07  5:46 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-29 13:55 [PATCH] ARM: shmobile: koelsch: Fix adv7511 IRQ sensing Laurent Pinchart
2015-04-30  4:56 ` Simon Horman
2015-04-30  7:30 ` Laurent Pinchart
2015-05-01  0:15 ` Simon Horman
2015-05-05 21:17 ` Ben Hutchings
2015-05-06  4:06 ` Laurent Pinchart
2015-05-07  5:46 [GIT PULL] Renesas ARM Based SoC Fixes for v4.1 Simon Horman
2015-05-07  5:46 ` [PATCH] ARM: shmobile: koelsch: Fix adv7511 IRQ sensing Simon Horman
2015-05-07  5:46   ` Simon Horman

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.