All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ajay Singh <ajay.kathat@microchip.com>
To: <linux-wireless@vger.kernel.org>
Cc: <devel@driverdev.osuosl.org>, <gregkh@linuxfoundation.org>,
	<ganesh.krishna@microchip.com>, <venkateswara.kaja@microchip.com>,
	<aditya.shankar@microchip.com>, <claudiu.beznea@microchip.com>,
	<adham.abozaeid@Microchip.com>,
	Ajay Singh <ajay.kathat@microchip.com>
Subject: [PATCH v2 08/21] staging: wilc1000: remove unused variable scan_while_connected
Date: Wed, 25 Apr 2018 22:48:13 +0530	[thread overview]
Message-ID: <1524676706-13179-9-git-send-email-ajay.kathat@microchip.com> (raw)
In-Reply-To: <1524676706-13179-1-git-send-email-ajay.kathat@microchip.com>

Cleanup patch to remove the unused variable.

Signed-off-by: Ajay Singh <ajay.kathat@microchip.com>
---
 drivers/staging/wilc1000/host_interface.c | 17 -----------------
 1 file changed, 17 deletions(-)

diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
index 12414f4..1b282b0 100644
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -242,8 +242,6 @@ u8 wilc_multicast_mac_addr_list[WILC_MULTICAST_TABLE_SIZE][ETH_ALEN];
 
 static u8 rcv_assoc_resp[MAX_ASSOC_RESP_FRAME_SIZE];
 
-static bool scan_while_connected;
-
 static s8 rssi;
 static u8 set_ip[2][4];
 static u8 get_ip[2][4];
@@ -839,11 +837,6 @@ static s32 handle_scan(struct wilc_vif *vif, struct scan_attr *scan_info)
 	wid_list[index].val = (s8 *)&scan_info->src;
 	index++;
 
-	if (hif_drv->hif_state == HOST_IF_CONNECTED)
-		scan_while_connected = true;
-	else if (hif_drv->hif_state == HOST_IF_IDLE)
-		scan_while_connected = false;
-
 	result = wilc_send_config_pkt(vif, SET_CFG, wid_list,
 				      index,
 				      wilc_get_vif_idx(vif));
@@ -1182,8 +1175,6 @@ static s32 handle_connect_timeout(struct wilc_vif *vif)
 
 	hif_drv->hif_state = HOST_IF_IDLE;
 
-	scan_while_connected = false;
-
 	memset(&info, 0, sizeof(struct connect_info));
 
 	if (hif_drv->usr_conn_req.conn_result) {
@@ -1410,7 +1401,6 @@ static inline void host_int_parse_assoc_resp_info(struct wilc_vif *vif,
 			  jiffies + msecs_to_jiffies(10000));
 	} else {
 		hif_drv->hif_state = HOST_IF_IDLE;
-		scan_while_connected = false;
 	}
 
 	kfree(conn_info.resp_ies);
@@ -1452,7 +1442,6 @@ static inline void host_int_handle_disconnect(struct wilc_vif *vif)
 
 	host_int_free_user_conn_req(hif_drv);
 	hif_drv->hif_state = HOST_IF_IDLE;
-	scan_while_connected = false;
 }
 
 static s32 handle_rcvd_gnrl_async_info(struct wilc_vif *vif,
@@ -1830,8 +1819,6 @@ static void handle_disconnect(struct wilc_vif *vif)
 		netdev_err(vif->ndev, "conn_result = NULL\n");
 	}
 
-	scan_while_connected = false;
-
 	hif_drv->hif_state = HOST_IF_IDLE;
 
 	eth_zero_addr(hif_drv->assoc_bssid);
@@ -3339,8 +3326,6 @@ int wilc_init(struct net_device *dev, struct host_if_drv **hif_drv_handler)
 	vif = netdev_priv(dev);
 	wilc = vif->wilc;
 
-	scan_while_connected = false;
-
 	init_completion(&hif_wait_response);
 
 	hif_drv  = kzalloc(sizeof(*hif_drv), GFP_KERNEL);
@@ -3436,8 +3421,6 @@ int wilc_deinit(struct wilc_vif *vif)
 
 	hif_drv->hif_state = HOST_IF_IDLE;
 
-	scan_while_connected = false;
-
 	memset(&msg, 0, sizeof(struct host_if_msg));
 
 	if (clients_count == 1)	{
-- 
2.7.4

  parent reply	other threads:[~2018-04-25 17:19 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-25 17:18 [PATCH v2 00/21] staging: wilc1000: remove unused code and reorder functions Ajay Singh
2018-04-25 17:18 ` [PATCH v2 01/21] staging: wilc1000: replace crc7_byte() with inline macro CRC7_BYTE Ajay Singh
2018-04-26  7:40   ` Greg KH
2018-04-26  7:54     ` Ajay Singh
2018-04-25 17:18 ` [PATCH v2 02/21] staging: wilc1000: align the #define in wilc_spi file Ajay Singh
2018-04-25 17:18 ` [PATCH v2 03/21] staging: wilc1000: remove unnecessary assingment from 'if' conditions Ajay Singh
2018-04-25 17:18 ` [PATCH v2 04/21] staging: wilc1000: remove 'cmd' variable in wilc_spi functions Ajay Singh
2018-04-25 17:18 ` [PATCH v2 05/21] staging: wicl1000: removed the unsed variables in wilc_parse_network_info() Ajay Singh
2018-04-25 17:18 ` [PATCH v2 06/21] staging: wilc1000: remove inner {} " Ajay Singh
2018-04-25 17:18 ` [PATCH v2 07/21] staging: wilc1000: simplified if conditions in spi_data_write() Ajay Singh
2018-04-25 17:18 ` Ajay Singh [this message]
2018-04-25 17:18 ` [PATCH v2 09/21] staging: wilc1000: remove unsed typedef wilc_debug_func Ajay Singh
2018-04-25 17:18 ` [PATCH v2 10/21] staging: wilc1000: remove used #define HIF_SDIO_GPIO_IRQ Ajay Singh
2018-04-25 17:18 ` [PATCH v2 11/21] staging: wilc1000: remove unused #define related to MAC status Ajay Singh
2018-04-25 17:18 ` [PATCH v2 12/21] staging: wilc1000: rename mac status macros and moved related #define together Ajay Singh
2018-04-25 17:18 ` [PATCH v2 13/21] staging: wilc1000: rename WILC_WFI_stats to avoid uppercase Ajay Singh
2018-04-25 17:18 ` [PATCH v2 14/21] staging: wilc1000: rename num_reg_frame macro to have uppercase in macro name Ajay Singh
2018-04-25 17:18 ` [PATCH v2 15/21] staging: wilc1000: rename wlan init and deinit function prefixed with wil1000 Ajay Singh
2018-04-25 17:18 ` [PATCH v2 16/21] staging: wilc1000: remove unused elements in 'wilc_priv' struct Ajay Singh
2018-04-25 17:18 ` [PATCH v2 17/21] staging: wilc1000: remove unused enum 'stats_flags' Ajay Singh
2018-04-25 17:18 ` [PATCH v2 18/21] staging: wilc1000: rename P2P_LISTEN_STATE variable to use lowercase Ajay Singh
2018-04-25 17:18 ` [PATCH v2 19/21] staging: wilc1000: remove inner block '{}' in handle_remain_on_chan() Ajay Singh
2018-04-25 17:18 ` [PATCH v2 20/21] staging: wilc1000: change function to static in linux_wlan Ajay Singh
2018-04-25 17:18 ` [PATCH v2 21/21] staging: wilc1000: reorder functions to avoid forward declaration " Ajay Singh
2018-04-26  6:16 ` [PATCH v2 00/21] staging: wilc1000: remove unused code and reorder functions Ajay Singh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1524676706-13179-9-git-send-email-ajay.kathat@microchip.com \
    --to=ajay.kathat@microchip.com \
    --cc=adham.abozaeid@Microchip.com \
    --cc=aditya.shankar@microchip.com \
    --cc=claudiu.beznea@microchip.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=ganesh.krishna@microchip.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=venkateswara.kaja@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.