All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Pandiyan, Dhinakaran" <dhinakaran.pandiyan@intel.com>
To: "Latvala, Petri" <petri.latvala@intel.com>
Cc: "igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>,
	"Vivi, Rodrigo" <rodrigo.vivi@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t 20/20] tests/psr: Add more PSR subtests to fast feedback list
Date: Wed, 25 Apr 2018 17:56:51 +0000	[thread overview]
Message-ID: <1524680501.24461.73.camel@dk-H97M-D3H> (raw)
In-Reply-To: <20180425083436.vemclux6qkzodwd6@platvala-desk.ger.corp.intel.com>




On Wed, 2018-04-25 at 11:34 +0300, Petri Latvala wrote:
> On Tue, Apr 24, 2018 at 02:28:17PM -0700, Rodrigo Vivi wrote:
> > On Tue, Apr 24, 2018 at 10:48:43AM -0700, Dhinakaran Pandiyan wrote:
> > > 
> > > 
> > > 
> > > On Tue, 2018-04-24 at 15:32 +0000, Saarinen, Jani wrote:
> > > > HI, 
> > > > 
> > > > > -----Original Message-----
> > > > > From: igt-dev [mailto:igt-dev-bounces@lists.freedesktop.org] On Behalf Of Petri
> > > > > Latvala
> > > > > Sent: tiistai 24. huhtikuuta 2018 12.34
> > > > > To: Pandiyan, Dhinakaran <dhinakaran.pandiyan@intel.com>; Vivi, Rodrigo
> > > > > <rodrigo.vivi@intel.com>
> > > > > Cc: igt-dev@lists.freedesktop.org
> > > > > Subject: Re: [igt-dev] [PATCH i-g-t 20/20] tests/psr: Add more PSR subtests to
> > > > > fast feedback list
> > > > > 
> > > > > 
> > > > > 
> > > > > On 04/24/2018 02:58 AM, Dhinakaran Pandiyan wrote:
> > > > > >
> > > > > >
> > > > > > On Mon, 2018-04-23 at 16:06 -0700, Rodrigo Vivi wrote:
> > > > > >> On Sat, Apr 14, 2018 at 06:13:40PM -0700, Dhinakaran Pandiyan wrote:
> > > > > >>> On Fri, 2018-04-13 at 12:16 +0300, Petri Latvala wrote:
> > > > > >>>> On Wed, Apr 11, 2018 at 07:14:36PM +0300, Pandiyan, Dhinakaran wrote:
> > > > > >>>>> Yeah, that is expected. The kernel patches are not in yet.
> > > > > >>>> The requirement for using --sink-crc is going away when kernel side
> > > > > >>>> patches land? Or how is this planned?
> > > > > >>>>
> > > > > >>> Irrespective of whether or when the kernel patches land, --sink-crc
> > > > > >>> will not be used for CI. --sink-crc is being retained for developers
> > > > > >>> to manually use it for debug and possibly fix the code in future.
> > > > > >>>
> > > > > >>> Having said that, the kernel patches adding time stamp support
> > > > > >>> should land soon, after which the tests will not skip.
> > > > > >> Ok, I finally looked to all patches on this series and I support all of them.
> > > > > >>
> > > > > >> My only concern is actually with patch 14 that is around this discussion here...
> > > > > >>
> > > > > >> For me it seems that or you run with interactive debug on or with
> > > > > >> sink_crc and CI is not running with any so it will all skip.
> > > > > >>
> > > > > >> Unless I missunderstood something on that patch...
> > > > > >>
> > > > > >> If CI still runs without requiring any extra option I'm in favor of
> > > > > >> the whole series and I'm tending to merge it soon...
> > > > > >>
> > > > > > CI will not need any options. Timestamps are supported by default on
> > > > > > all platforms except CHV/VLV. We don't have those platforms in CI and
> > > > > > I am planning to nuke PSR support for them.
> > > > > >
> > > > > 
> > > > > These machines are VLV:
> > > > > fi-byt-j1900
> > > > > fi-byt-n2820
> > > > Also CHV=BSW => fi-bsw-n3050
> > > > 
> > > 
> > > No psr panels on them.
> > 
> > Ok, so it seems no need for waiting...
> > 
> > 
> > Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > on the series.
> > 
> > but let's see if Petri has more concerns.
> 
> 
> No objections except for the fast-feedback.testlist changes. PSR
> additions is acked in practice, but the tests need to first actually
> run.
> 

Petri,

If your concern is about tests getting skipped on PSR capable CI
platforms, that is not a problem anymore. The kernel support was merged
and the tests should not skip on these platforms.

References:
3f983e54fdad drm/i915/psr: Timestamps for PSR entry and exit interrupts.
54fd3149598c drm/i915/psr: Control PSR interrupts via debugfs
e04f7ece1c45 drm/i915: Enable edp psr error interrupts on bdw+
fc34044248b6 drm/i915: Enable edp psr error interrupts on hsw


Anyone with privileges to the patchwork retest button should retest this
series, if there are still concerns.


Rodrigo,

Can you merge the rest of the patches please? Or trigger a retest and
merge the fast-feedback patch too?
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  reply	other threads:[~2018-04-25 17:56 UTC|newest]

Thread overview: 78+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-11  2:37 [igt-dev] [PATCH i-g-t 01/20] tests/psr: Print the reason for skipping when sink lacks PSR support Dhinakaran Pandiyan
2018-04-11  2:37 ` [igt-dev] [PATCH i-g-t 02/20] tests/psr: Remove "psr_" prefix from basic and drrs subtests Dhinakaran Pandiyan
2018-04-13 10:57   ` Katarzyna Dec
2018-04-11  2:37 ` [igt-dev] [PATCH i-g-t 03/20] tests/psr: Rename psr_active() to psr_enabled() Dhinakaran Pandiyan
2018-04-13 10:58   ` Katarzyna Dec
2018-04-11  2:37 ` [igt-dev] [PATCH i-g-t 04/20] tests/psr: Store the debugfs file descriptor Dhinakaran Pandiyan
2018-04-13 10:58   ` Katarzyna Dec
2018-04-11  2:37 ` [igt-dev] [PATCH i-g-t 05/20] tests/psr: Assert sink CRC length and make use of igt_sysfs_read() Dhinakaran Pandiyan
2018-04-13 10:59   ` Katarzyna Dec
2018-04-11  2:37 ` [igt-dev] [PATCH i-g-t 06/20] tests/psr: Optimize check for green frame Dhinakaran Pandiyan
2018-04-13 10:59   ` Katarzyna Dec
2018-04-11  2:37 ` [igt-dev] [PATCH i-g-t 07/20] tests/psr: Kill MMAP_GTT_WAITING Dhinakaran Pandiyan
2018-04-12 11:11   ` Katarzyna Dec
2018-04-16 21:44     ` Pandiyan, Dhinakaran
2018-04-23 23:01       ` Rodrigo Vivi
2018-04-16 22:08     ` Dhinakaran Pandiyan
2018-04-11  2:37 ` [igt-dev] [PATCH i-g-t 08/20] tests/psr: Merge PSR dpms and suspend variants Dhinakaran Pandiyan
2018-04-12 11:20   ` Katarzyna Dec
2018-04-16 21:46     ` Pandiyan, Dhinakaran
2018-04-17  7:58       ` Katarzyna Dec
2018-04-23 23:03       ` Rodrigo Vivi
2018-04-16 22:10     ` Dhinakaran Pandiyan
2018-04-11  2:37 ` [igt-dev] [PATCH i-g-t 09/20] tests/psr: Check for PSR entry more often and only for a second Dhinakaran Pandiyan
2018-04-12 11:25   ` Katarzyna Dec
2018-04-16 22:43     ` Dhinakaran Pandiyan
2018-04-11  2:37 ` [igt-dev] [PATCH i-g-t 10/20] tests/psr: Remove delay between dpms toggle Dhinakaran Pandiyan
2018-04-12 11:26   ` Katarzyna Dec
2018-04-13  0:24     ` Dhinakaran Pandiyan
2018-04-13 11:05       ` Katarzyna Dec
2018-04-11  2:37 ` [igt-dev] [PATCH i-g-t 11/20] tests/psr: Check for drrs status only after checking for PSR Dhinakaran Pandiyan
2018-04-13 11:21   ` Katarzyna Dec
2018-04-11  2:37 ` [igt-dev] [PATCH i-g-t 12/20] tests/sink_crc_basic: Debug print CRC values Dhinakaran Pandiyan
2018-04-13 11:22   ` Katarzyna Dec
2018-04-11  2:37 ` [igt-dev] [PATCH i-g-t 13/20] tests/psr: Get rid of global variable running_with_psr_disabled Dhinakaran Pandiyan
2018-04-13 11:22   ` Katarzyna Dec
2018-04-11  2:37 ` [igt-dev] [PATCH i-g-t 14/20] tests/psr: Make testing with sink CRC non-default Dhinakaran Pandiyan
2018-04-13 11:22   ` Katarzyna Dec
2018-04-11  2:37 ` [igt-dev] [PATCH i-g-t 15/20] tests/psr: Eliminate storing pointers for igt_plane_type Dhinakaran Pandiyan
2018-04-13 11:23   ` Katarzyna Dec
2018-04-11  2:37 ` [igt-dev] [PATCH i-g-t 16/20] tests/psr: Pass data_t pointer to dpms_off_on Dhinakaran Pandiyan
2018-04-13 11:23   ` Katarzyna Dec
2018-04-11  2:37 ` [igt-dev] [PATCH i-g-t 17/20] tests/psr: Prepare for using timestamps Dhinakaran Pandiyan
2018-04-12 12:50   ` Katarzyna Dec
2018-04-13  0:21     ` Dhinakaran Pandiyan
2018-04-13 11:33       ` Katarzyna Dec
2018-04-11  2:37 ` [igt-dev] [PATCH i-g-t 18/20] tests/psr: Check for timestamp support Dhinakaran Pandiyan
2018-04-12 12:52   ` Katarzyna Dec
2018-04-13  0:13     ` Dhinakaran Pandiyan
2018-04-13  0:13       ` Dhinakaran Pandiyan
2018-04-13 11:34       ` Katarzyna Dec
2018-04-11  2:37 ` [igt-dev] [PATCH i-g-t 19/20] tests/psr: Test PSR using interrupt timestamps Dhinakaran Pandiyan
2018-04-12 12:56   ` Katarzyna Dec
2018-04-16 22:49     ` [igt-dev] [PATCH i-g-t v2] " Dhinakaran Pandiyan
2018-04-17 12:53       ` Katarzyna Dec
2018-04-11  2:37 ` [igt-dev] [PATCH i-g-t 20/20] tests/psr: Add more PSR subtests to fast feedback list Dhinakaran Pandiyan
2018-04-11  8:42   ` Petri Latvala
2018-04-11 16:14     ` Pandiyan, Dhinakaran
2018-04-13  9:16       ` Petri Latvala
2018-04-15  1:13         ` Dhinakaran Pandiyan
2018-04-23 23:06           ` Rodrigo Vivi
2018-04-23 23:58             ` Dhinakaran Pandiyan
2018-04-24  9:34               ` Petri Latvala
2018-04-24 15:32                 ` Saarinen, Jani
2018-04-24 17:48                   ` Dhinakaran Pandiyan
2018-04-24 21:28                     ` Rodrigo Vivi
2018-04-25  8:34                       ` Petri Latvala
2018-04-25 17:56                         ` Pandiyan, Dhinakaran [this message]
2018-04-25 20:15                           ` Rodrigo Vivi
2018-04-11  3:07 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,01/20] tests/psr: Print the reason for skipping when sink lacks PSR support Patchwork
2018-04-11  3:53 ` [igt-dev] ✗ Fi.CI.IGT: warning " Patchwork
2018-04-12 11:08 ` [igt-dev] [PATCH i-g-t 01/20] " Katarzyna Dec
2018-04-12 13:03 ` Katarzyna Dec
2018-04-13 10:57 ` Katarzyna Dec
2018-04-16 23:10 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,01/20] tests/psr: Print the reason for skipping when sink lacks PSR support (rev2) Patchwork
2018-04-25 21:00 ` Patchwork
2018-04-26  8:40   ` Petri Latvala
2018-05-09 23:41     ` Dhinakaran Pandiyan
2018-04-26  9:58 ` Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1524680501.24461.73.camel@dk-H97M-D3H \
    --to=dhinakaran.pandiyan@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=petri.latvala@intel.com \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.