From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751234AbeEATeP (ORCPT ); Tue, 1 May 2018 15:34:15 -0400 Received: from gateway22.websitewelcome.com ([192.185.47.100]:38567 "EHLO gateway22.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751126AbeEATeN (ORCPT ); Tue, 1 May 2018 15:34:13 -0400 X-Authority-Reason: nr=8 From: Matheus Castello To: linus.walleij@linaro.org Cc: kbuild-all@01.org, linux-kernel@vger.kernel.org, Matheus Castello Subject: [PATCH v2 2/2] pinctrl: generic: improve apply_setting error verbosity Date: Tue, 1 May 2018 15:10:01 -0400 Message-Id: <1525201801-25682-3-git-send-email-matheus@castello.eng.br> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1525201801-25682-1-git-send-email-matheus@castello.eng.br> References: <201805011855.LvT1SKBS%fengguang.wu@intel.com> <1525201801-25682-1-git-send-email-matheus@castello.eng.br> X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - br164.hostgator.com.br X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - castello.eng.br X-BWhitelist: no X-Source-IP: 191.189.21.134 X-Source-L: No X-Exim-ID: 1fDafh-0042Wq-QP X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (localhost.localdomain) [191.189.21.134]:17937 X-Source-Auth: matheus@castello.eng.br X-Email-Count: 11 X-Source-Cap: Y2FzdGUyNDg7Y2FzdGUyNDg7YnIxNjQuaG9zdGdhdG9yLmNvbS5icg== X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org For generic pinconf: print the dev_error with the pinctrl vendor driver name, error code, the sub-node property name used and the pin that was tried to set. Improves the undestading of the error if use a generic sub-node property that generic-pinconf can do parse but the vendor pinctrl driver does not support. Signed-off-by: Matheus Castello --- drivers/pinctrl/pinconf.c | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/drivers/pinctrl/pinconf.c b/drivers/pinctrl/pinconf.c index d3fe143..ced2b67 100644 --- a/drivers/pinctrl/pinconf.c +++ b/drivers/pinctrl/pinconf.c @@ -21,6 +21,7 @@ #include #include #include +#include #include "core.h" #include "pinconf.h" @@ -169,9 +170,21 @@ int pinconf_apply_setting(const struct pinctrl_setting *setting) setting->data.configs.configs, setting->data.configs.num_configs); if (ret < 0) { +#ifdef CONFIG_OF dev_err(pctldev->dev, - "pin_config_set op failed for pin %d\n", + "%s error %d setting %s for pin %d\n", + pctldev->desc->name, ret, + pinconf_generic_get_param_property_name( + pctldev, setting->data.configs.num_configs, + setting->data.configs.configs), setting->data.configs.group_or_pin); +#endif + + dev_err(pctldev->dev, + "pin_config_set op failed for %s pin %d\n", + pctldev->desc->name, + setting->data.configs.group_or_pin); + return ret; } break; -- 2.7.4