From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751421AbeEBJqS convert rfc822-to-8bit (ORCPT ); Wed, 2 May 2018 05:46:18 -0400 Received: from mail.fireflyinternet.com ([109.228.58.192]:55023 "EHLO fireflyinternet.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750897AbeEBJqP (ORCPT ); Wed, 2 May 2018 05:46:15 -0400 X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT To: Matthias Kaehlcke , "Jani Nikula" , "Rodrigo Vivi" , "David Airlie" From: Chris Wilson In-Reply-To: <20180501182440.70121-1-mka@chromium.org> Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, "Guenter Roeck" , "Matthias Kaehlcke" References: <20180501182440.70121-1-mka@chromium.org> Message-ID: <152525436760.32109.17749926643981003077@mail.alporthouse.com> User-Agent: alot/0.3.6 Subject: Re: [PATCH v3] drm/i915: Disable some extra clang warnings Date: Wed, 02 May 2018 10:46:07 +0100 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Matthias Kaehlcke (2018-05-01 19:24:40) > Commit 39bf4de89ff7 ("drm/i915: Add -Wall -Wextra to our build, set > warnings to full") enabled extra warnings for i915 to spot possible > bugs in new code, and then disabled a subset of these warnings to keep > the current code building without warnings (with gcc). Enabling the > extra warnings also enabled some additional clang-only warnings, as a > result building i915 with clang currently is extremely noisy. For now > also disable the clang warnings sign-compare, sometimes-uninitialized, > unneeded-internal-declaration and initializer-overrides. If desired > they can be re-enabled after the code has been fixed. > > Signed-off-by: Matthias Kaehlcke Reviewed-by: Chris Wilson -Chris From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH v3] drm/i915: Disable some extra clang warnings Date: Wed, 02 May 2018 10:46:07 +0100 Message-ID: <152525436760.32109.17749926643981003077@mail.alporthouse.com> References: <20180501182440.70121-1-mka@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8BIT Return-path: In-Reply-To: <20180501182440.70121-1-mka@chromium.org> Sender: linux-kernel-owner@vger.kernel.org To: Jani Nikula , Rodrigo Vivi , David Airlie Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Guenter Roeck , Matthias Kaehlcke List-Id: dri-devel@lists.freedesktop.org Quoting Matthias Kaehlcke (2018-05-01 19:24:40) > Commit 39bf4de89ff7 ("drm/i915: Add -Wall -Wextra to our build, set > warnings to full") enabled extra warnings for i915 to spot possible > bugs in new code, and then disabled a subset of these warnings to keep > the current code building without warnings (with gcc). Enabling the > extra warnings also enabled some additional clang-only warnings, as a > result building i915 with clang currently is extremely noisy. For now > also disable the clang warnings sign-compare, sometimes-uninitialized, > unneeded-internal-declaration and initializer-overrides. If desired > they can be re-enabled after the code has been fixed. > > Signed-off-by: Matthias Kaehlcke Reviewed-by: Chris Wilson -Chris