From: Chris Wilson <chris@chris-wilson.co.uk>
To: Ville Syrjala <ville.syrjala@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
FadeMind <fademind@gmail.com>,
Dave Jones <davej@codemonkey.org.uk>
Subject: Re: [PATCH] drm/i915: Correctly populate user mode h/vdisplay with pipe src size during readout
Date: Wed, 02 May 2018 16:33:30 +0100 [thread overview]
Message-ID: <152527521035.28472.13649497170542687297@mail.alporthouse.com> (raw)
In-Reply-To: <20180426163015.14232-1-ville.syrjala@linux.intel.com>
Quoting Ville Syrjala (2018-04-26 17:30:15)
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> During state readout we first read out the pipe src size, store
> that information in the user mode h/vdisplay, but later on we overwrite
> that with the actual crtc timings. That makes our read out crtc state
> inconsistent with itself when the BIOS has enabled the panel fitter to
> scale the pipe contents. Let's preserve the pipe src size based
> information in the user mode to make things consistent again.
The question I don't feel answered is: If this is the BIOS mode, why
aren't we filling it from get_hw_state?
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-05-02 15:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-26 16:30 [PATCH] drm/i915: Correctly populate user mode h/vdisplay with pipe src size during readout Ville Syrjala
2018-04-27 8:29 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2018-04-27 8:47 ` ✓ Fi.CI.BAT: success " Patchwork
2018-04-27 11:08 ` ✓ Fi.CI.IGT: " Patchwork
2018-05-02 15:33 ` Chris Wilson [this message]
2018-05-02 15:52 ` [PATCH] " Ville Syrjälä
2018-05-02 15:57 ` Chris Wilson
2018-05-02 16:14 ` Ville Syrjälä
2018-05-02 16:23 ` Chris Wilson
2018-05-03 6:50 ` Jani Nikula
2018-05-03 15:11 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=152527521035.28472.13649497170542687297@mail.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=davej@codemonkey.org.uk \
--cc=fademind@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.