From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-eopbgr10042.outbound.protection.outlook.com ([40.107.1.42]:55200 "EHLO EUR02-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751708AbeECAmd (ORCPT ); Wed, 2 May 2018 20:42:33 -0400 From: Li Jun Subject: [PATCH v5 13/14] staging: typec: tcpci: Only touch target bit when enable vconn Date: Thu, 3 May 2018 08:24:53 +0800 Message-Id: <1525307094-27402-14-git-send-email-jun.li@nxp.com> In-Reply-To: <1525307094-27402-1-git-send-email-jun.li@nxp.com> References: <1525307094-27402-1-git-send-email-jun.li@nxp.com> MIME-Version: 1.0 Content-Type: text/plain Sender: devicetree-owner@vger.kernel.org To: robh+dt@kernel.org, gregkh@linuxfoundation.org, heikki.krogerus@linux.intel.com, linux@roeck-us.net Cc: jun.li@nxp.com, a.hajda@samsung.com, cw00.choi@samsung.com, shufan_lee@richtek.com, peter.chen@nxp.com, gsomlo@gmail.com, devicetree@vger.kernel.org, linux-usb@vger.kernel.org, linux-imx@nxp.com List-ID: We need regmap_update_bits to avoid touch any other bits when enable or disable vconn. Reviewed-by: Guenter Roeck Signed-off-by: Li Jun --- drivers/staging/typec/tcpci.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/staging/typec/tcpci.c b/drivers/staging/typec/tcpci.c index 5c0c5e3..2818a4d 100644 --- a/drivers/staging/typec/tcpci.c +++ b/drivers/staging/typec/tcpci.c @@ -218,12 +218,9 @@ static int tcpci_set_vconn(struct tcpc_dev *tcpc, bool enable) return ret; } - ret = regmap_write(tcpci->regmap, TCPC_POWER_CTRL, - enable ? TCPC_POWER_CTRL_VCONN_ENABLE : 0); - if (ret < 0) - return ret; - - return 0; + return regmap_update_bits(tcpci->regmap, TCPC_POWER_CTRL, + TCPC_POWER_CTRL_VCONN_ENABLE, + enable ? TCPC_POWER_CTRL_VCONN_ENABLE : 0); } static int tcpci_set_roles(struct tcpc_dev *tcpc, bool attached, -- 2.7.4 From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v5,13/14] staging: typec: tcpci: Only touch target bit when enable vconn From: Jun Li Message-Id: <1525307094-27402-14-git-send-email-jun.li@nxp.com> Date: Thu, 3 May 2018 08:24:53 +0800 To: robh+dt@kernel.org, gregkh@linuxfoundation.org, heikki.krogerus@linux.intel.com, linux@roeck-us.net Cc: jun.li@nxp.com, a.hajda@samsung.com, cw00.choi@samsung.com, shufan_lee@richtek.com, peter.chen@nxp.com, gsomlo@gmail.com, devicetree@vger.kernel.org, linux-usb@vger.kernel.org, linux-imx@nxp.com List-ID: V2UgbmVlZCByZWdtYXBfdXBkYXRlX2JpdHMgdG8gYXZvaWQgdG91Y2ggYW55IG90aGVyIGJpdHMg d2hlbgplbmFibGUgb3IgZGlzYWJsZSB2Y29ubi4KClJldmlld2VkLWJ5OiBHdWVudGVyIFJvZWNr IDxsaW51eEByb2Vjay11cy5uZXQ+ClNpZ25lZC1vZmYtYnk6IExpIEp1biA8anVuLmxpQG54cC5j b20+Ci0tLQogZHJpdmVycy9zdGFnaW5nL3R5cGVjL3RjcGNpLmMgfCA5ICsrKy0tLS0tLQogMSBm aWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKSwgNiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQg YS9kcml2ZXJzL3N0YWdpbmcvdHlwZWMvdGNwY2kuYyBiL2RyaXZlcnMvc3RhZ2luZy90eXBlYy90 Y3BjaS5jCmluZGV4IDVjMGM1ZTMuLjI4MThhNGQgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvc3RhZ2lu Zy90eXBlYy90Y3BjaS5jCisrKyBiL2RyaXZlcnMvc3RhZ2luZy90eXBlYy90Y3BjaS5jCkBAIC0y MTgsMTIgKzIxOCw5IEBAIHN0YXRpYyBpbnQgdGNwY2lfc2V0X3Zjb25uKHN0cnVjdCB0Y3BjX2Rl diAqdGNwYywgYm9vbCBlbmFibGUpCiAJCQlyZXR1cm4gcmV0OwogCX0KIAotCXJldCA9IHJlZ21h cF93cml0ZSh0Y3BjaS0+cmVnbWFwLCBUQ1BDX1BPV0VSX0NUUkwsCi0JCQkgICBlbmFibGUgPyBU Q1BDX1BPV0VSX0NUUkxfVkNPTk5fRU5BQkxFIDogMCk7Ci0JaWYgKHJldCA8IDApCi0JCXJldHVy biByZXQ7Ci0KLQlyZXR1cm4gMDsKKwlyZXR1cm4gcmVnbWFwX3VwZGF0ZV9iaXRzKHRjcGNpLT5y ZWdtYXAsIFRDUENfUE9XRVJfQ1RSTCwKKwkJCQlUQ1BDX1BPV0VSX0NUUkxfVkNPTk5fRU5BQkxF LAorCQkJCWVuYWJsZSA/IFRDUENfUE9XRVJfQ1RSTF9WQ09OTl9FTkFCTEUgOiAwKTsKIH0KIAog c3RhdGljIGludCB0Y3BjaV9zZXRfcm9sZXMoc3RydWN0IHRjcGNfZGV2ICp0Y3BjLCBib29sIGF0 dGFjaGVkLAo=