From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id C0D366E249 for ; Thu, 3 May 2018 16:56:00 +0000 (UTC) MIME-Version: 1.0 From: Joonas Lahtinen In-Reply-To: <20180502092807.28266-1-chris@chris-wilson.co.uk> References: <20180502092807.28266-1-chris@chris-wilson.co.uk> Message-ID: <152536655771.15663.15614570347092183928@jlahtine-desk.ger.corp.intel.com> Date: Thu, 03 May 2018 19:55:57 +0300 Subject: Re: [igt-dev] [PATCH i-g-t] igt/sw_sync: Wrap threaded counter manipulation with mb List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Chris Wilson , igt-dev@lists.freedesktop.org List-ID: UXVvdGluZyBDaHJpcyBXaWxzb24gKDIwMTgtMDUtMDIgMTI6Mjg6MDcpCj4gc3dfc3luYy9zeW5j X211bHRpX2NvbnN1bWVyX3Byb2R1Y2VyIHdhcyBjb21tdW5pY2F0aW5nIGJldHdlZW4gdGhyZWFk cwo+IHVzaW5nIHRoZSBzd19zeW5jIGlvY3RsIGFuZCBtYW5pcHVsYXRpbmcgYSBzaGFyZWQgdm9s YXRpbGUgY291bnRlci4KPiBIb3dldmVyLCB0aGUgaW9jdGwgaXRzZWxmIGRvZXMgbm90IGltcGx5 IGEgbWVtb3J5IGJhcnJpZXIsIGFuZCBzbwo+IGRpZmZlcmVudCBDUFVzIG1heSBzZWUgZGlmZmVy ZW50IHN0YXRlcyBvZiB0aGUgY291bnRlciAodGhlIHZvbGF0aWxlCj4gbWFraW5nIEdDQyBwZXJm b3JtIHRoZSBvcGVyYXRpb24gaW4gc3RhZ2VzIG1ha2luZyB0aGUgcmFjZSBldmVuIG1vcmUKPiBs aWtlbHkpLiBJbnN0ZWFkIG9mIHVzaW5nIHZvbGF0aWxlLCB1c2UgbG9ja2VkIG9wZXJhdGlvbnMg dG8gbWFrZSB0aGUKPiBjb3VudGVyIG1hbmlwdWxhdGlvbiB0aHJlYWQtc2FmZS4KPiAKPiBSZWZl cmVuY2VzOiBodHRwczovL2J1Z3MuZnJlZWRlc2t0b3Aub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDYz NDQKPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51 az4KPiAtLS0KPiAgdGVzdHMvc3dfc3luYy5jIHwgMjQgKysrKysrKysrKystLS0tLS0tLS0tLS0t Cj4gIDEgZmlsZSBjaGFuZ2VkLCAxMSBpbnNlcnRpb25zKCspLCAxMyBkZWxldGlvbnMoLSkKPiAK PiBkaWZmIC0tZ2l0IGEvdGVzdHMvc3dfc3luYy5jIGIvdGVzdHMvc3dfc3luYy5jCj4gaW5kZXgg MjBkZmJiYjk4Li5jNjg2N2UwOTcgMTAwNjQ0Cj4gLS0tIGEvdGVzdHMvc3dfc3luYy5jCj4gKysr IGIvdGVzdHMvc3dfc3luYy5jCj4gQEAgLTQzLDcgKzQzLDcgQEAgSUdUX1RFU1RfREVTQ1JJUFRJ T04oIlRlc3QgU1cgU3luYyBGcmFtZXdvcmsiKTsKPiAgdHlwZWRlZiBzdHJ1Y3Qgewo+ICAgICAg ICAgaW50IHRpbWVsaW5lOwo+ICAgICAgICAgdWludDMyX3QgdGhyZWFkX2lkOwo+IC0gICAgICAg dm9sYXRpbGUgdWludDMyX3QgKiB2b2xhdGlsZSBjb3VudGVyOwo+ICsgICAgICAgdWludDMyX3Qg KmNvdW50ZXI7Cj4gICAgICAgICBzZW1fdCAqc2VtOwo+ICB9IGRhdGFfdDsKPiAgCj4gQEAgLTUw OCw3ICs1MDgsNyBAQCBzdGF0aWMgdm9pZCAqIHRlc3Rfc3luY19tdWx0aV9jb25zdW1lcl90aHJl YWQodm9pZCAqYXJnKQo+ICAgICAgICAgICAgICAgICBpZiAoc3luY19mZW5jZV93YWl0KGZlbmNl LCAxMDAwKSA8IDApCj4gICAgICAgICAgICAgICAgICAgICAgICAgcmV0dXJuICh2b2lkICopIDE7 Cj4gIAo+IC0gICAgICAgICAgICAgICBpZiAoKihkYXRhLT5jb3VudGVyKSAhPSBuZXh0X3BvaW50 KQo+ICsgICAgICAgICAgICAgICBpZiAoUkVBRF9PTkNFKCpkYXRhLT5jb3VudGVyKSAhPSBuZXh0 X3BvaW50KQo+ICAgICAgICAgICAgICAgICAgICAgICAgIHJldHVybiAodm9pZCAqKSAxOwo+ICAK PiAgICAgICAgICAgICAgICAgc2VtX3Bvc3QoZGF0YS0+c2VtKTsKPiBAQCAtNTI0LDcgKzUyNCw3 IEBAIHN0YXRpYyB2b2lkIHRlc3Rfc3luY19tdWx0aV9jb25zdW1lcih2b2lkKQo+ICAgICAgICAg cHRocmVhZF90IHRocmVhZF9hcnJbTVVMVElfQ09OU1VNRVJfVEhSRUFEU107Cj4gICAgICAgICBz ZW1fdCBzZW07Cj4gICAgICAgICBpbnQgdGltZWxpbmU7Cj4gLSAgICAgICB2b2xhdGlsZSB1aW50 MzJfdCBjb3VudGVyID0gMDsKPiArICAgICAgIHVpbnQzMl90IGNvdW50ZXIgPSAwOwo+ICAgICAg ICAgdWludHB0cl90IHRocmVhZF9yZXQgPSAwOwo+ICAgICAgICAgZGF0YV90IGRhdGE7Cj4gICAg ICAgICBpbnQgaSwgcmV0Owo+IEBAIC01NTIsNyArNTUyLDcgQEAgc3RhdGljIHZvaWQgdGVzdF9z eW5jX211bHRpX2NvbnN1bWVyKHZvaWQpCj4gICAgICAgICB7Cj4gICAgICAgICAgICAgICAgIHNl bV93YWl0KCZzZW0pOwo+ICAKPiAtICAgICAgICAgICAgICAgY291bnRlcisrOwo+ICsgICAgICAg ICAgICAgICBfX3N5bmNfZmV0Y2hfYW5kX2FkZCgmY291bnRlciwgMSk7Cj4gICAgICAgICAgICAg ICAgIHN3X3N5bmNfdGltZWxpbmVfaW5jKHRpbWVsaW5lLCAxKTsKPiAgICAgICAgIH0KPiAgCj4g QEAgLTU2Nyw4ICs1NjcsOCBAQCBzdGF0aWMgdm9pZCB0ZXN0X3N5bmNfbXVsdGlfY29uc3VtZXIo dm9pZCkKPiAgICAgICAgIGNsb3NlKHRpbWVsaW5lKTsKPiAgICAgICAgIHNlbV9kZXN0cm95KCZz ZW0pOwo+ICAKPiAtICAgICAgIGlndF9hc3NlcnRfZihjb3VudGVyID09IE1VTFRJX0NPTlNVTUVS X1RIUkVBRFMgKiBNVUxUSV9DT05TVU1FUl9JVEVSQVRJT05TLAo+IC0gICAgICAgICAgICAgICAg ICAgICJDb3VudGVyIGhhcyB1bmV4cGVjdGVkIHZhbHVlLlxuIik7Cj4gKyAgICAgICBpZ3RfYXNz ZXJ0X2VxKGNvdW50ZXIsCj4gKyAgICAgICAgICAgICAgICAgICAgIE1VTFRJX0NPTlNVTUVSX1RI UkVBRFMgKiBNVUxUSV9DT05TVU1FUl9JVEVSQVRJT05TKTsKPiAgCj4gICAgICAgICBpZ3RfYXNz ZXJ0X2YodGhyZWFkX3JldCA9PSAwLCAiQSBzeW5jIHRocmVhZCByZXBvcnRlZCBmYWlsdXJlLlxu Iik7Cj4gIH0KPiBAQCAtNTg5LDExICs1ODksOSBAQCBzdGF0aWMgdm9pZCAqIHRlc3Rfc3luY19t dWx0aV9jb25zdW1lcl9wcm9kdWNlcl90aHJlYWQodm9pZCAqYXJnKQo+ICAgICAgICAgICAgICAg ICBpZiAoc3luY19mZW5jZV93YWl0KGZlbmNlLCAxMDAwKSA8IDApCj4gICAgICAgICAgICAgICAg ICAgICAgICAgcmV0dXJuICh2b2lkICopIDE7Cj4gIAo+IC0gICAgICAgICAgICAgICBpZiAoKihk YXRhLT5jb3VudGVyKSAhPSBuZXh0X3BvaW50KQo+ICsgICAgICAgICAgICAgICBpZiAoX19zeW5j X2ZldGNoX2FuZF9hZGQoZGF0YS0+Y291bnRlciwgMSkgIT0gbmV4dF9wb2ludCkKPiAgICAgICAg ICAgICAgICAgICAgICAgICByZXR1cm4gKHZvaWQgKikgMTsKPiAgCj4gLSAgICAgICAgICAgICAg ICgqZGF0YS0+Y291bnRlcikrKzsKClRoaXMgaXMgYSBiZWhhdmlvciBjaGFuZ2UsIHRoZSBjb3Vu dGVyIGdldHMgaW5jcmVtZW50ZWQgYWx3YXlzIDooCgpSZWdhcmRzLCBKb29uYXMKCj4gLQo+ICAg ICAgICAgICAgICAgICAvKiBLaWNrIG9mZiB0aGUgbmV4dCB0aHJlYWQuICovCj4gICAgICAgICAg ICAgICAgIHN3X3N5bmNfdGltZWxpbmVfaW5jKHRpbWVsaW5lLCAxKTsKPiAgCj4gQEAgLTYwNyw3 ICs2MDUsNyBAQCBzdGF0aWMgdm9pZCB0ZXN0X3N5bmNfbXVsdGlfY29uc3VtZXJfcHJvZHVjZXIo dm9pZCkKPiAgICAgICAgIGRhdGFfdCBkYXRhX2FycltNVUxUSV9DT05TVU1FUl9QUk9EVUNFUl9U SFJFQURTXTsKPiAgICAgICAgIHB0aHJlYWRfdCB0aHJlYWRfYXJyW01VTFRJX0NPTlNVTUVSX1BS T0RVQ0VSX1RIUkVBRFNdOwo+ICAgICAgICAgaW50IHRpbWVsaW5lOwo+IC0gICAgICAgdm9sYXRp bGUgdWludDMyX3QgY291bnRlciA9IDA7Cj4gKyAgICAgICB1aW50MzJfdCBjb3VudGVyID0gMDsK PiAgICAgICAgIHVpbnRwdHJfdCB0aHJlYWRfcmV0ID0gMDsKPiAgICAgICAgIGRhdGFfdCBkYXRh Owo+ICAgICAgICAgaW50IGksIHJldDsKPiBAQCAtNjM4LDkgKzYzNiw5IEBAIHN0YXRpYyB2b2lk IHRlc3Rfc3luY19tdWx0aV9jb25zdW1lcl9wcm9kdWNlcih2b2lkKQo+ICAKPiAgICAgICAgIGNs b3NlKHRpbWVsaW5lKTsKPiAgCj4gLSAgICAgICBpZ3RfYXNzZXJ0X2YoY291bnRlciA9PSBNVUxU SV9DT05TVU1FUl9QUk9EVUNFUl9USFJFQURTICoKPiAtICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIE1VTFRJX0NPTlNVTUVSX1BST0RVQ0VSX0lURVJBVElPTlMsCj4gLSAgICAgICAgICAg ICAgICAgICAgIkNvdW50ZXIgaGFzIHVuZXhwZWN0ZWQgdmFsdWUuXG4iKTsKPiArICAgICAgIGln dF9hc3NlcnRfZXEoY291bnRlciwKPiArICAgICAgICAgICAgICAgICAgICAgTVVMVElfQ09OU1VN RVJfUFJPRFVDRVJfVEhSRUFEUyAqCj4gKyAgICAgICAgICAgICAgICAgICAgIE1VTFRJX0NPTlNV TUVSX1BST0RVQ0VSX0lURVJBVElPTlMpOwo+ICAKPiAgICAgICAgIGlndF9hc3NlcnRfZih0aHJl YWRfcmV0ID09IDAsICJBIHN5bmMgdGhyZWFkIHJlcG9ydGVkIGZhaWx1cmUuXG4iKTsKPiAgfQo+ IC0tIAo+IDIuMTcuMAo+IAo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCj4gaWd0LWRldiBtYWlsaW5nIGxpc3QKPiBpZ3QtZGV2QGxpc3RzLmZyZWVkZXNr dG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v aWd0LWRldgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpp Z3QtZGV2IG1haWxpbmcgbGlzdAppZ3QtZGV2QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lndC1kZXYK