From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from fireflyinternet.com (mail.fireflyinternet.com [109.228.58.192]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7E2EC6E704 for ; Thu, 3 May 2018 19:40:58 +0000 (UTC) MIME-Version: 1.0 From: Chris Wilson References: <20180502092807.28266-1-chris@chris-wilson.co.uk> <152536655771.15663.15614570347092183928@jlahtine-desk.ger.corp.intel.com> In-Reply-To: <152536655771.15663.15614570347092183928@jlahtine-desk.ger.corp.intel.com> Message-ID: <152537645311.16610.651740206977321997@mail.alporthouse.com> Date: Thu, 03 May 2018 20:40:53 +0100 Subject: Re: [igt-dev] [PATCH i-g-t] igt/sw_sync: Wrap threaded counter manipulation with mb List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Joonas Lahtinen , igt-dev@lists.freedesktop.org List-ID: UXVvdGluZyBKb29uYXMgTGFodGluZW4gKDIwMTgtMDUtMDMgMTc6NTU6NTcpCj4gUXVvdGluZyBD aHJpcyBXaWxzb24gKDIwMTgtMDUtMDIgMTI6Mjg6MDcpCj4gPiBzd19zeW5jL3N5bmNfbXVsdGlf Y29uc3VtZXJfcHJvZHVjZXIgd2FzIGNvbW11bmljYXRpbmcgYmV0d2VlbiB0aHJlYWRzCj4gPiB1 c2luZyB0aGUgc3dfc3luYyBpb2N0bCBhbmQgbWFuaXB1bGF0aW5nIGEgc2hhcmVkIHZvbGF0aWxl IGNvdW50ZXIuCj4gPiBIb3dldmVyLCB0aGUgaW9jdGwgaXRzZWxmIGRvZXMgbm90IGltcGx5IGEg bWVtb3J5IGJhcnJpZXIsIGFuZCBzbwo+ID4gZGlmZmVyZW50IENQVXMgbWF5IHNlZSBkaWZmZXJl bnQgc3RhdGVzIG9mIHRoZSBjb3VudGVyICh0aGUgdm9sYXRpbGUKPiA+IG1ha2luZyBHQ0MgcGVy Zm9ybSB0aGUgb3BlcmF0aW9uIGluIHN0YWdlcyBtYWtpbmcgdGhlIHJhY2UgZXZlbiBtb3JlCj4g PiBsaWtlbHkpLiBJbnN0ZWFkIG9mIHVzaW5nIHZvbGF0aWxlLCB1c2UgbG9ja2VkIG9wZXJhdGlv bnMgdG8gbWFrZSB0aGUKPiA+IGNvdW50ZXIgbWFuaXB1bGF0aW9uIHRocmVhZC1zYWZlLgo+ID4g Cj4gPiBSZWZlcmVuY2VzOiBodHRwczovL2J1Z3MuZnJlZWRlc2t0b3Aub3JnL3Nob3dfYnVnLmNn aT9pZD0xMDYzNDQKPiA+IFNpZ25lZC1vZmYtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMt d2lsc29uLmNvLnVrPgo+ID4gLS0tCj4gPiAgdGVzdHMvc3dfc3luYy5jIHwgMjQgKysrKysrKysr KystLS0tLS0tLS0tLS0tCj4gPiAgMSBmaWxlIGNoYW5nZWQsIDExIGluc2VydGlvbnMoKyksIDEz IGRlbGV0aW9ucygtKQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEvdGVzdHMvc3dfc3luYy5jIGIvdGVz dHMvc3dfc3luYy5jCj4gPiBpbmRleCAyMGRmYmJiOTguLmM2ODY3ZTA5NyAxMDA2NDQKPiA+IC0t LSBhL3Rlc3RzL3N3X3N5bmMuYwo+ID4gKysrIGIvdGVzdHMvc3dfc3luYy5jCj4gPiBAQCAtNDMs NyArNDMsNyBAQCBJR1RfVEVTVF9ERVNDUklQVElPTigiVGVzdCBTVyBTeW5jIEZyYW1ld29yayIp Owo+ID4gIHR5cGVkZWYgc3RydWN0IHsKPiA+ICAgICAgICAgaW50IHRpbWVsaW5lOwo+ID4gICAg ICAgICB1aW50MzJfdCB0aHJlYWRfaWQ7Cj4gPiAtICAgICAgIHZvbGF0aWxlIHVpbnQzMl90ICog dm9sYXRpbGUgY291bnRlcjsKPiA+ICsgICAgICAgdWludDMyX3QgKmNvdW50ZXI7Cj4gPiAgICAg ICAgIHNlbV90ICpzZW07Cj4gPiAgfSBkYXRhX3Q7Cj4gPiAgCj4gPiBAQCAtNTA4LDcgKzUwOCw3 IEBAIHN0YXRpYyB2b2lkICogdGVzdF9zeW5jX211bHRpX2NvbnN1bWVyX3RocmVhZCh2b2lkICph cmcpCj4gPiAgICAgICAgICAgICAgICAgaWYgKHN5bmNfZmVuY2Vfd2FpdChmZW5jZSwgMTAwMCkg PCAwKQo+ID4gICAgICAgICAgICAgICAgICAgICAgICAgcmV0dXJuICh2b2lkICopIDE7Cj4gPiAg Cj4gPiAtICAgICAgICAgICAgICAgaWYgKCooZGF0YS0+Y291bnRlcikgIT0gbmV4dF9wb2ludCkK PiA+ICsgICAgICAgICAgICAgICBpZiAoUkVBRF9PTkNFKCpkYXRhLT5jb3VudGVyKSAhPSBuZXh0 X3BvaW50KQo+ID4gICAgICAgICAgICAgICAgICAgICAgICAgcmV0dXJuICh2b2lkICopIDE7Cj4g PiAgCj4gPiAgICAgICAgICAgICAgICAgc2VtX3Bvc3QoZGF0YS0+c2VtKTsKPiA+IEBAIC01MjQs NyArNTI0LDcgQEAgc3RhdGljIHZvaWQgdGVzdF9zeW5jX211bHRpX2NvbnN1bWVyKHZvaWQpCj4g PiAgICAgICAgIHB0aHJlYWRfdCB0aHJlYWRfYXJyW01VTFRJX0NPTlNVTUVSX1RIUkVBRFNdOwo+ ID4gICAgICAgICBzZW1fdCBzZW07Cj4gPiAgICAgICAgIGludCB0aW1lbGluZTsKPiA+IC0gICAg ICAgdm9sYXRpbGUgdWludDMyX3QgY291bnRlciA9IDA7Cj4gPiArICAgICAgIHVpbnQzMl90IGNv dW50ZXIgPSAwOwo+ID4gICAgICAgICB1aW50cHRyX3QgdGhyZWFkX3JldCA9IDA7Cj4gPiAgICAg ICAgIGRhdGFfdCBkYXRhOwo+ID4gICAgICAgICBpbnQgaSwgcmV0Owo+ID4gQEAgLTU1Miw3ICs1 NTIsNyBAQCBzdGF0aWMgdm9pZCB0ZXN0X3N5bmNfbXVsdGlfY29uc3VtZXIodm9pZCkKPiA+ICAg ICAgICAgewo+ID4gICAgICAgICAgICAgICAgIHNlbV93YWl0KCZzZW0pOwo+ID4gIAo+ID4gLSAg ICAgICAgICAgICAgIGNvdW50ZXIrKzsKPiA+ICsgICAgICAgICAgICAgICBfX3N5bmNfZmV0Y2hf YW5kX2FkZCgmY291bnRlciwgMSk7Cj4gPiAgICAgICAgICAgICAgICAgc3dfc3luY190aW1lbGlu ZV9pbmModGltZWxpbmUsIDEpOwo+ID4gICAgICAgICB9Cj4gPiAgCj4gPiBAQCAtNTY3LDggKzU2 Nyw4IEBAIHN0YXRpYyB2b2lkIHRlc3Rfc3luY19tdWx0aV9jb25zdW1lcih2b2lkKQo+ID4gICAg ICAgICBjbG9zZSh0aW1lbGluZSk7Cj4gPiAgICAgICAgIHNlbV9kZXN0cm95KCZzZW0pOwo+ID4g IAo+ID4gLSAgICAgICBpZ3RfYXNzZXJ0X2YoY291bnRlciA9PSBNVUxUSV9DT05TVU1FUl9USFJF QURTICogTVVMVElfQ09OU1VNRVJfSVRFUkFUSU9OUywKPiA+IC0gICAgICAgICAgICAgICAgICAg ICJDb3VudGVyIGhhcyB1bmV4cGVjdGVkIHZhbHVlLlxuIik7Cj4gPiArICAgICAgIGlndF9hc3Nl cnRfZXEoY291bnRlciwKPiA+ICsgICAgICAgICAgICAgICAgICAgICBNVUxUSV9DT05TVU1FUl9U SFJFQURTICogTVVMVElfQ09OU1VNRVJfSVRFUkFUSU9OUyk7Cj4gPiAgCj4gPiAgICAgICAgIGln dF9hc3NlcnRfZih0aHJlYWRfcmV0ID09IDAsICJBIHN5bmMgdGhyZWFkIHJlcG9ydGVkIGZhaWx1 cmUuXG4iKTsKPiA+ICB9Cj4gPiBAQCAtNTg5LDExICs1ODksOSBAQCBzdGF0aWMgdm9pZCAqIHRl c3Rfc3luY19tdWx0aV9jb25zdW1lcl9wcm9kdWNlcl90aHJlYWQodm9pZCAqYXJnKQo+ID4gICAg ICAgICAgICAgICAgIGlmIChzeW5jX2ZlbmNlX3dhaXQoZmVuY2UsIDEwMDApIDwgMCkKPiA+ICAg ICAgICAgICAgICAgICAgICAgICAgIHJldHVybiAodm9pZCAqKSAxOwo+ID4gIAo+ID4gLSAgICAg ICAgICAgICAgIGlmICgqKGRhdGEtPmNvdW50ZXIpICE9IG5leHRfcG9pbnQpCj4gPiArICAgICAg ICAgICAgICAgaWYgKF9fc3luY19mZXRjaF9hbmRfYWRkKGRhdGEtPmNvdW50ZXIsIDEpICE9IG5l eHRfcG9pbnQpCj4gPiAgICAgICAgICAgICAgICAgICAgICAgICByZXR1cm4gKHZvaWQgKikgMTsK PiA+ICAKPiA+IC0gICAgICAgICAgICAgICAoKmRhdGEtPmNvdW50ZXIpKys7Cj4gCj4gVGhpcyBp cyBhIGJlaGF2aW9yIGNoYW5nZSwgdGhlIGNvdW50ZXIgZ2V0cyBpbmNyZW1lbnRlZCBhbHdheXMg OigKCkJ1dCBpdCBkb2Vzbid0IG1hdHRlciwgc2luY2UgdGhlIHJldHVybiAxIGhlcmUgaXMgZmFp bHVyZS4gQW5kIGFueQp0aHJlYWQgcmVwb3J0aW5nIGZhaWx1cmUgaXMgZW5vdWdoLgotQ2hyaXMK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KaWd0LWRldiBt YWlsaW5nIGxpc3QKaWd0LWRldkBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pZ3QtZGV2Cg==