Re: [PATCH v3] toolchain-scripts: preserve host path in environment setup script

From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Chin Huat Ang <chin.huat.ang@intel.com>,
	openembedded-core@lists.openembedded.org
Subject: Re: [PATCH v3] toolchain-scripts: preserve host path in environment setup script
Date: Fri, 04 May 2018 16:04:38 +0100	[thread overview]
Message-ID: <1525446278.3857.13.camel@linuxfoundation.org> (raw)
In-Reply-To: <1524643213-5505-1-git-send-email-chin.huat.ang@intel.com>

On Wed, 2018-04-25 at 16:00 +0800, Chin Huat Ang wrote:
> The environment setup script generated in the build directory sets
> the PATH
> variable by expanding ${PATH} which would have host paths filtered.
> Sourcing
> this script to run runqemu will not work as it complains host stty
> (/bin/stty)
> cannot be found.
> 
> To resolve this, the script no longer expands ${PATH} during
> generation time,
> instead it will now source oe-init-build-env to initialize the build
> environment so that all host paths will be preserved. Also be sure to
> prepend
> STAGING_BINDIR_TOOLCHAIN to the PATH variable so that the toolchain
> from the
> build directory can be found.
> 
> [YOCTO #12695]
> 
> Signed-off-by: Chin Huat Ang <chin.huat.ang@intel.com>
> ---
>  meta/classes/toolchain-scripts.bbclass | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

This didn't work as expected on machines which have /bin/sh pointing to
dash, the oe-selftests showed failures.

I've added a followup patch which addresses that problem which allowed
me to merge the patches.

Cheers,

Richard