All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Clark <mjc@sifive.com>
To: qemu-devel@nongnu.org
Cc: patches@groups.riscv.org, KONRAD Frederic <frederic.konrad@adacore.com>
Subject: [Qemu-devel] [PULL 3/3] riscv: requires libfdt
Date: Tue,  8 May 2018 11:14:53 +1200	[thread overview]
Message-ID: <1525734893-10299-4-git-send-email-mjc@sifive.com> (raw)
In-Reply-To: <1525734893-10299-1-git-send-email-mjc@sifive.com>

From: KONRAD Frederic <frederic.konrad@adacore.com>

When compiling on a machine without libfdt installed the configure script
should try to get libfdt from the git or should die because otherwise
CONFIG_LIBFDT is not set and the build process end in an error in the link
phase.. eg:

hw/riscv/virt.o: In function `riscv_virt_board_init':
qemu/src/hw/riscv/virt.c:317: undefined reference to `qemu_fdt_setprop_cell'
qemu/src/hw/riscv/virt.c:319: undefined reference to `qemu_fdt_setprop_cell'
qemu/src/hw/riscv/virt.c:345: undefined reference to `qemu_fdt_dumpdtb'
collect2: error: ld returned 1 exit status
make[1]: *** [qemu-system-riscv64] Error 1
make: *** [subdir-riscv64-softmmu] Error 2

Reviewed-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Michael Clark <mjc@sifive.com>
Signed-off-by: KONRAD Frederic <frederic.konrad@adacore.com>

Message-Id: <1525360636-18229-4-git-send-email-frederic.konrad@adacore.com>
---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure b/configure
index 1443422e83f1..479e9a787e6e 100755
--- a/configure
+++ b/configure
@@ -3761,7 +3761,7 @@ fi
 fdt_required=no
 for target in $target_list; do
   case $target in
-    aarch64*-softmmu|arm*-softmmu|ppc*-softmmu|microblaze*-softmmu|mips64el-softmmu)
+    aarch64*-softmmu|arm*-softmmu|ppc*-softmmu|microblaze*-softmmu|mips64el-softmmu|riscv*-softmmu)
       fdt_required=yes
     ;;
   esac
-- 
2.7.0

  parent reply	other threads:[~2018-05-07 23:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-07 23:14 [Qemu-devel] [PULL 0/3] RISC-V: QEMU 2.13 Minor Fixes Michael Clark
2018-05-07 23:14 ` [Qemu-devel] [PULL 1/3] riscv: spike: allow base == 0 Michael Clark
2018-05-07 23:14 ` [Qemu-devel] [PULL 2/3] riscv: htif: increase the priority of the htif subregion Michael Clark
2018-05-07 23:14 ` Michael Clark [this message]
2018-05-08 16:05 ` [Qemu-devel] [PULL 0/3] RISC-V: QEMU 2.13 Minor Fixes Peter Maydell
2018-05-08 19:57   ` Michael Clark
2018-05-08 20:07 Michael Clark
2018-05-08 20:07 ` [Qemu-devel] [PULL 3/3] riscv: requires libfdt Michael Clark
2018-05-09 10:20 [Qemu-devel] [PULL 0/3] RISC-V: QEMU 2.13 Minor Fixes Michael Clark
2018-05-09 10:20 ` [Qemu-devel] [PULL 3/3] riscv: requires libfdt Michael Clark

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1525734893-10299-4-git-send-email-mjc@sifive.com \
    --to=mjc@sifive.com \
    --cc=frederic.konrad@adacore.com \
    --cc=patches@groups.riscv.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.