All of lore.kernel.org
 help / color / mirror / Atom feed
From: Philipp Zabel <p.zabel@pengutronix.de>
To: Jan Luebbe <jlu@pengutronix.de>, linux-media@vger.kernel.org
Cc: slongerbeam@gmail.com, kernel@pengutronix.de
Subject: Re: [PATCH v2 0/2] media: imx: add capture support for RGB565_2X8 on parallel bus
Date: Tue, 08 May 2018 16:25:04 +0200	[thread overview]
Message-ID: <1525789504.18091.9.camel@pengutronix.de> (raw)
In-Reply-To: <20180508141411.26620-1-jlu@pengutronix.de>

On Tue, 2018-05-08 at 16:14 +0200, Jan Luebbe wrote:
> The IPU can only capture RGB565 with two 8-bit cycles in bayer/generic
> mode on the parallel bus, compared to a specific mode on MIPI CSI-2.
> To handle this, we extend imx_media_pixfmt with a cycles per pixel
> field, which is used for generic formats on the parallel bus.
> 
> Before actually adding RGB565_2X8 support for the parallel bus, this
> series simplifies handing of the the different configurations for RGB565
> between parallel and MIPI CSI-2 in imx-media-capture. This avoids having
> to explicitly pass on the format in the second patch.
> 
> Changes since v1:
>   - fixed problems reported the kbuild test robot
>   - added helper functions as suggested by Steve Longerbeam
>     (is_parallel_bus and requires_passthrough)
>   - removed passthough format check in csi_link_validate() (suggested by
>     Philipp Zabel during internal review)

The theory is that IC only supports AYUV8_1X32 and RGB888_1X24 input,
and any passthrough format on the CSI sink will differ from those.
Mismatching formats are already caught by v4l2_subdev_link_validate
called on the ipu?_vdic or ipu?_ic_prp entities' sink pads.

regards
Philipp

  parent reply	other threads:[~2018-05-08 14:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-08 14:14 [PATCH v2 0/2] media: imx: add capture support for RGB565_2X8 on parallel bus Jan Luebbe
2018-05-08 14:14 ` [PATCH v2 1/2] media: imx: capture: refactor enum_/try_fmt Jan Luebbe
2018-05-08 14:14 ` [PATCH v2 2/2] media: imx: add support for RGB565_2X8 on parallel bus Jan Luebbe
2018-05-08 14:25 ` Philipp Zabel [this message]
2018-05-08 23:24   ` [PATCH v2 0/2] media: imx: add capture " Steve Longerbeam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1525789504.18091.9.camel@pengutronix.de \
    --to=p.zabel@pengutronix.de \
    --cc=jlu@pengutronix.de \
    --cc=kernel@pengutronix.de \
    --cc=linux-media@vger.kernel.org \
    --cc=slongerbeam@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.